Fix small bug in nfnl_subsys_open (uninitialized values)

Fix small bug in nfnl_subsys_open (uninitialized values)

[Victor Stinner]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

Hi,

I found a bug in libnfnetlink, function nfnl_subsys_open(). I attached a patch 
to fix it.

The problem is that callback structures weren't initialized. So sometimes, 
bytes are nul, sometimes... not.

Victor Stinner
http://www.inl.fr/

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: libnfnetlink_subsys_open.patch --]
[-- Type: text/x-diff; charset="us-ascii"; name="libnfnetlink_subsys_open.patch", Size: 366 bytes --]

Index: src/libnfnetlink.c
===================================================================
--- src/libnfnetlink.c	(révision 6716)
+++ src/libnfnetlink.c	(copie de travail)
@@ -244,7 +244,7 @@
 		return NULL;
 	}
 
-	ssh->cb = malloc(sizeof(*(ssh->cb)) * cb_count);
+	ssh->cb = calloc(cb_count, sizeof(*(ssh->cb)));
 	if (!ssh->cb)
 		return NULL;
 

Re: Fix small bug in nfnl_subsys_open (uninitialized values)

[Pablo Neira Ayuso]

Victor Stinner wrote:
> I found a bug in libnfnetlink, function nfnl_subsys_open(). I attached a patch 
> to fix it.
> 
> The problem is that callback structures weren't initialized. So sometimes, 
> bytes are nul, sometimes... not.

Applied, thanks Victor.

-- 
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris