From: Richard Knutsson <ricknu-0@student.ltu.se>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: akpm@osdl.org, Jeff Dike <jdike@addtoit.com>,
linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [uml-devel] [PATCH 4/8] UML - audio driver formatting
Date: Tue, 02 Jan 2007 09:27:12 +0100 [thread overview]
Message-ID: <459A1760.7010805@student.ltu.se> (raw)
In-Reply-To: <20070101182322.b365543a.rdunlap@xenotime.net>
Randy Dunlap wrote:
> On Tue, 02 Jan 2007 02:52:33 +0100 Richard Knutsson wrote:
>
>
>> Jeff Dike wrote:
>>
>>> Whitespace and style fixes.
>>>
>>> Signed-off-by: Jeff Dike <jdike@addtoit.com>
>>> --
>>> arch/um/drivers/hostaudio_kern.c | 160 +++++++++++++++++----------------------
>>> 1 file changed, 73 insertions(+), 87 deletions(-)
>>>
>>> Index: linux-2.6.18-mm/arch/um/drivers/hostaudio_kern.c
>>> ===================================================================
>>> --- linux-2.6.18-mm.orig/arch/um/drivers/hostaudio_kern.c 2006-12-29 21:13:41.000000000 -0500
>>> +++ linux-2.6.18-mm/arch/um/drivers/hostaudio_kern.c 2006-12-29 21:13:42.000000000 -0500
>>> @@ -15,11 +15,11 @@
>>> #include "os.h"
>>>
>>> struct hostaudio_state {
>>> - int fd;
>>> + int fd;
>>> };
>>>
>>> struct hostmixer_state {
>>> - int fd;
>>> + int fd;
>>> };
>>>
>>> #define HOSTAUDIO_DEV_DSP "/dev/sound/dsp"
>>> @@ -72,12 +72,12 @@ MODULE_PARM_DESC(mixer, MIXER_HELP);
>>> static ssize_t hostaudio_read(struct file *file, char __user *buffer,
>>> size_t count, loff_t *ppos)
>>> {
>>> - struct hostaudio_state *state = file->private_data;
>>> + struct hostaudio_state *state = file->private_data;
>>> void *kbuf;
>>> int err;
>>>
>>> #ifdef DEBUG
>>> - printk("hostaudio: read called, count = %d\n", count);
>>> + printk("hostaudio: read called, count = %d\n", count);
>>> #endif
>>>
>>> kbuf = kmalloc(count, GFP_KERNEL);
>>> @@ -91,7 +91,7 @@ static ssize_t hostaudio_read(struct fil
>>> if(copy_to_user(buffer, kbuf, err))
>>> err = -EFAULT;
>>>
>>> - out:
>>> +out:
>>>
>>>
>> Isn't labels _suppose_ to be spaced? (due to "grep", if I'm not mistaken)...
>>
>
> There was some noise about that (due to 'patch' IIRC).
> I tested it and could not cause a problem with labels beginning
> in column 0. Can you?
>
Can't say I have (even thou I have not tried so much). You seem to have
it covered, sorry for adding to the noise.
>
>>> kfree(kbuf);
>>> return(err);
>>> }
>>>
>
>
>
Richard Knutson
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
WARNING: multiple messages have this Message-ID (diff)
From: Richard Knutsson <ricknu-0@student.ltu.se>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Jeff Dike <jdike@addtoit.com>,
akpm@osdl.org, linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: Re: [PATCH 4/8] UML - audio driver formatting
Date: Tue, 02 Jan 2007 09:27:12 +0100 [thread overview]
Message-ID: <459A1760.7010805@student.ltu.se> (raw)
In-Reply-To: <20070101182322.b365543a.rdunlap@xenotime.net>
Randy Dunlap wrote:
> On Tue, 02 Jan 2007 02:52:33 +0100 Richard Knutsson wrote:
>
>
>> Jeff Dike wrote:
>>
>>> Whitespace and style fixes.
>>>
>>> Signed-off-by: Jeff Dike <jdike@addtoit.com>
>>> --
>>> arch/um/drivers/hostaudio_kern.c | 160 +++++++++++++++++----------------------
>>> 1 file changed, 73 insertions(+), 87 deletions(-)
>>>
>>> Index: linux-2.6.18-mm/arch/um/drivers/hostaudio_kern.c
>>> ===================================================================
>>> --- linux-2.6.18-mm.orig/arch/um/drivers/hostaudio_kern.c 2006-12-29 21:13:41.000000000 -0500
>>> +++ linux-2.6.18-mm/arch/um/drivers/hostaudio_kern.c 2006-12-29 21:13:42.000000000 -0500
>>> @@ -15,11 +15,11 @@
>>> #include "os.h"
>>>
>>> struct hostaudio_state {
>>> - int fd;
>>> + int fd;
>>> };
>>>
>>> struct hostmixer_state {
>>> - int fd;
>>> + int fd;
>>> };
>>>
>>> #define HOSTAUDIO_DEV_DSP "/dev/sound/dsp"
>>> @@ -72,12 +72,12 @@ MODULE_PARM_DESC(mixer, MIXER_HELP);
>>> static ssize_t hostaudio_read(struct file *file, char __user *buffer,
>>> size_t count, loff_t *ppos)
>>> {
>>> - struct hostaudio_state *state = file->private_data;
>>> + struct hostaudio_state *state = file->private_data;
>>> void *kbuf;
>>> int err;
>>>
>>> #ifdef DEBUG
>>> - printk("hostaudio: read called, count = %d\n", count);
>>> + printk("hostaudio: read called, count = %d\n", count);
>>> #endif
>>>
>>> kbuf = kmalloc(count, GFP_KERNEL);
>>> @@ -91,7 +91,7 @@ static ssize_t hostaudio_read(struct fil
>>> if(copy_to_user(buffer, kbuf, err))
>>> err = -EFAULT;
>>>
>>> - out:
>>> +out:
>>>
>>>
>> Isn't labels _suppose_ to be spaced? (due to "grep", if I'm not mistaken)...
>>
>
> There was some noise about that (due to 'patch' IIRC).
> I tested it and could not cause a problem with labels beginning
> in column 0. Can you?
>
Can't say I have (even thou I have not tried so much). You seem to have
it covered, sorry for adding to the noise.
>
>>> kfree(kbuf);
>>> return(err);
>>> }
>>>
>
>
>
Richard Knutson
next prev parent reply other threads:[~2007-01-02 8:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-01 19:47 [uml-devel] [PATCH 4/8] UML - audio driver formatting Jeff Dike
2007-01-01 19:47 ` Jeff Dike
2007-01-02 1:52 ` [uml-devel] " Richard Knutsson
2007-01-02 1:52 ` Richard Knutsson
2007-01-02 2:23 ` [uml-devel] " Randy Dunlap
2007-01-02 2:23 ` Randy Dunlap
2007-01-02 8:27 ` Richard Knutsson [this message]
2007-01-02 8:27 ` Richard Knutsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=459A1760.7010805@student.ltu.se \
--to=ricknu-0@student.ltu.se \
--cc=akpm@osdl.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.