From: Mark Lord <liml@rtr.ca>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: implement HDIO_GET_IDENTITY
Date: Tue, 02 Jan 2007 13:18:32 -0500 [thread overview]
Message-ID: <459AA1F8.7080402@rtr.ca> (raw)
In-Reply-To: <459A9D81.8040904@gmail.com>
Tejun Heo wrote:
> Mark Lord wrote:
..
>> hdparm *does* try to issue the PACKET IDENTIFY whenever
>> a regular IDENTIFY fails. Currently these all go through
>> the HDIO_DRIVE_CMD ioctl(). I don't have a system set up
>> here that has any ATAPI over libata to test with.
>> Could you perhaps try and see where that ioctl() is failing?
>
> Ah.. Okay, so that's the second HDIO_DRIVE_CMD. I'll test why the
> second one is failing tomorrow.
>
Okay, I suspect it's failing because libata-scsi *always*
forces passthru commands to go via atapi_xlat, even when
the command itself is not a PACKET command. Doh!
I'll see if there's a sensible easy fix for it, and maybe post
a patch here unless you beat me to it.
Cheers
next prev parent reply other threads:[~2007-01-02 18:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-02 11:18 [PATCH 1/3] libata: straighten out ATA_ID_* constants Tejun Heo
2007-01-02 11:19 ` [PATCH 2/3] libata: use ata_id_c_string() Tejun Heo
2007-01-02 11:20 ` [PATCH] libata: implement HDIO_GET_IDENTITY Tejun Heo
2007-01-02 11:21 ` [PATCH *3/3*] " Tejun Heo
2007-01-02 17:47 ` [PATCH] " Mark Lord
2007-01-02 17:59 ` Tejun Heo
2007-01-02 18:18 ` Mark Lord [this message]
2007-01-02 21:52 ` Mark Lord
2007-01-08 2:29 ` Jeff Garzik
2007-01-08 4:00 ` Tejun Heo
2007-01-25 1:22 ` Jeff Garzik
2007-01-25 5:14 ` Mark Lord
2007-01-25 7:42 ` Jeff Garzik
2007-01-09 10:42 ` [PATCH 1/3] libata: straighten out ATA_ID_* constants Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=459AA1F8.7080402@rtr.ca \
--to=liml@rtr.ca \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.