All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: implement HDIO_GET_IDENTITY
Date: Mon, 08 Jan 2007 13:00:28 +0900	[thread overview]
Message-ID: <45A1C1DC.5050807@gmail.com> (raw)
In-Reply-To: <45A1AC6E.40704@pobox.com>

Jeff Garzik wrote:
> Tejun Heo wrote:
>> 'hdparm -I' doesn't work with ATAPI devices and sg_sat is not widely
>> spread yet leaving no easy way to access ATAPI IDENTIFY data.
>> Implement HDIO_GET_IDENTITY such that at least 'hdparm -i' works.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
> 
> Are you certain this works for both big-endian and little-endian?
> 
> A quick "it works" test by somebody on sata_svw (ppc64) or another
> big-endian platform would be nice.

I think it does.  What the code does is identical to what drivers/ide
does.  Anyways, it doesn't really matter, I think we should drop this
patch (3/3 only, that is).  The reason why I implemented this was to get
ATAPI ID data using 'hdparm -i' but as Mark Lord pointed out, 'hdparm
-I' can do IDENTIFY PACKET DEVICE if the kernel is fixed.  I think
that's the way to go.

Thanks.

-- 
tejun

  reply	other threads:[~2007-01-08  4:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-02 11:18 [PATCH 1/3] libata: straighten out ATA_ID_* constants Tejun Heo
2007-01-02 11:19 ` [PATCH 2/3] libata: use ata_id_c_string() Tejun Heo
2007-01-02 11:20   ` [PATCH] libata: implement HDIO_GET_IDENTITY Tejun Heo
2007-01-02 11:21     ` [PATCH *3/3*] " Tejun Heo
2007-01-02 17:47     ` [PATCH] " Mark Lord
2007-01-02 17:59       ` Tejun Heo
2007-01-02 18:18         ` Mark Lord
2007-01-02 21:52           ` Mark Lord
2007-01-08  2:29     ` Jeff Garzik
2007-01-08  4:00       ` Tejun Heo [this message]
2007-01-25  1:22     ` Jeff Garzik
2007-01-25  5:14       ` Mark Lord
2007-01-25  7:42         ` Jeff Garzik
2007-01-09 10:42 ` [PATCH 1/3] libata: straighten out ATA_ID_* constants Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45A1C1DC.5050807@gmail.com \
    --to=htejun@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.