From: Heiner Kallweit <hkallweit1@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
Madalin-cristian Bucur <madalin.bucur@nxp.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc: "andrew@lunn.ch" <andrew@lunn.ch>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH v2] net: phy: aquantia: readd XGMII support for AQR107
Date: Wed, 15 May 2019 19:25:14 +0200 [thread overview]
Message-ID: <459eba93-e499-a78b-4318-907748033ccf@gmail.com> (raw)
In-Reply-To: <a7ba6f22-066e-5ab0-c42f-c275db579f32@gmail.com>
On 15.05.2019 18:19, Florian Fainelli wrote:
> On 5/15/19 8:07 AM, Madalin-cristian Bucur wrote:
>> XGMII interface mode no longer works on AQR107 after the recent changes,
>> adding back support.
>>
>> Fixes: 570c8a7d5303 ("net: phy: aquantia: check for supported interface modes in config_init")
>>
>> Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
>
> Just so you know for future submissions, there is no need for a newline
> between your Fixes: and Signed-off-by: tag, it's just a normal tag.
>
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>
I checked the datasheet and AQR107 doesn't support XGMII. It supports USXGMII,
maybe XGMII is used as workaround because phy_interface_t doesn't cover
USXGMII yet. If it makes the board work again, I think using XGMII is fine for
now. But we should add USXGMII and the remove this workaround.
next prev parent reply other threads:[~2019-05-15 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 15:07 [PATCH v2] net: phy: aquantia: readd XGMII support for AQR107 Madalin-cristian Bucur
2019-05-15 16:19 ` Florian Fainelli
2019-05-15 17:25 ` Heiner Kallweit [this message]
2019-05-15 18:44 ` Andrew Lunn
2019-05-15 18:55 ` Heiner Kallweit
2019-05-16 19:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=459eba93-e499-a78b-4318-907748033ccf@gmail.com \
--to=hkallweit1@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.