[PATCH v2] net: phy: aquantia: readd XGMII support for AQR107

[PATCH v2] net: phy: aquantia: readd XGMII support for AQR107

[Madalin-cristian Bucur]

XGMII interface mode no longer works on AQR107 after the recent changes,
adding back support.

Fixes: 570c8a7d5303 ("net: phy: aquantia: check for supported interface modes in config_init")

Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
---
 drivers/net/phy/aquantia_main.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/phy/aquantia_main.c b/drivers/net/phy/aquantia_main.c
index eed4fe3d871f..0fedd28fdb6e 100644
--- a/drivers/net/phy/aquantia_main.c
+++ b/drivers/net/phy/aquantia_main.c
@@ -487,6 +487,7 @@ static int aqr107_config_init(struct phy_device *phydev)
 	/* Check that the PHY interface type is compatible */
 	if (phydev->interface != PHY_INTERFACE_MODE_SGMII &&
 	    phydev->interface != PHY_INTERFACE_MODE_2500BASEX &&
+	    phydev->interface != PHY_INTERFACE_MODE_XGMII &&
 	    phydev->interface != PHY_INTERFACE_MODE_10GKR)
 		return -ENODEV;
 
-- 
2.1.0

Re: [PATCH v2] net: phy: aquantia: readd XGMII support for AQR107

[Florian Fainelli]

On 5/15/19 8:07 AM, Madalin-cristian Bucur wrote:
> XGMII interface mode no longer works on AQR107 after the recent changes,
> adding back support.
> 
> Fixes: 570c8a7d5303 ("net: phy: aquantia: check for supported interface modes in config_init")
> 
> Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>

Just so you know for future submissions, there is no need for a newline
between your Fixes: and Signed-off-by: tag, it's just a normal tag.

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Re: [PATCH v2] net: phy: aquantia: readd XGMII support for AQR107

[Heiner Kallweit]

On 15.05.2019 18:19, Florian Fainelli wrote:
> On 5/15/19 8:07 AM, Madalin-cristian Bucur wrote:
>> XGMII interface mode no longer works on AQR107 after the recent changes,
>> adding back support.
>>
>> Fixes: 570c8a7d5303 ("net: phy: aquantia: check for supported interface modes in config_init")
>>
>> Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
> 
> Just so you know for future submissions, there is no need for a newline
> between your Fixes: and Signed-off-by: tag, it's just a normal tag.
> 
> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> 
I checked the datasheet and AQR107 doesn't support XGMII. It supports USXGMII,
maybe XGMII is used as workaround because phy_interface_t doesn't cover
USXGMII yet. If it makes the board work again, I think using XGMII is fine for
now. But we should add USXGMII and the remove this workaround.

Re: [PATCH v2] net: phy: aquantia: readd XGMII support for AQR107

[Andrew Lunn]

On Wed, May 15, 2019 at 07:25:14PM +0200, Heiner Kallweit wrote:
> On 15.05.2019 18:19, Florian Fainelli wrote:
> > On 5/15/19 8:07 AM, Madalin-cristian Bucur wrote:
> >> XGMII interface mode no longer works on AQR107 after the recent changes,
> >> adding back support.
> >>
> >> Fixes: 570c8a7d5303 ("net: phy: aquantia: check for supported interface modes in config_init")
> >>
> >> Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
> > 
> > Just so you know for future submissions, there is no need for a newline
> > between your Fixes: and Signed-off-by: tag, it's just a normal tag.
> > 
> > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> > 
> I checked the datasheet and AQR107 doesn't support XGMII. It supports USXGMII,
> maybe XGMII is used as workaround because phy_interface_t doesn't cover
> USXGMII yet. If it makes the board work again, I think using XGMII is fine for
> now. But we should add USXGMII and the remove this workaround.

Hi Heiner

We should add USXGMII anyway. But that is net-next material, if it is
not the fix we go with.

    Andrew

Re: [PATCH v2] net: phy: aquantia: readd XGMII support for AQR107

[Heiner Kallweit]

On 15.05.2019 20:44, Andrew Lunn wrote:
> On Wed, May 15, 2019 at 07:25:14PM +0200, Heiner Kallweit wrote:
>> On 15.05.2019 18:19, Florian Fainelli wrote:
>>> On 5/15/19 8:07 AM, Madalin-cristian Bucur wrote:
>>>> XGMII interface mode no longer works on AQR107 after the recent changes,
>>>> adding back support.
>>>>
>>>> Fixes: 570c8a7d5303 ("net: phy: aquantia: check for supported interface modes in config_init")
>>>>
>>>> Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
>>>
>>> Just so you know for future submissions, there is no need for a newline
>>> between your Fixes: and Signed-off-by: tag, it's just a normal tag.
>>>
>>> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
>>>
>> I checked the datasheet and AQR107 doesn't support XGMII. It supports USXGMII,
>> maybe XGMII is used as workaround because phy_interface_t doesn't cover
>> USXGMII yet. If it makes the board work again, I think using XGMII is fine for
>> now. But we should add USXGMII and the remove this workaround.
> 
> Hi Heiner
> 
> We should add USXGMII anyway. But that is net-next material, if it is
> not the fix we go with.
> 
Right. It's a very small patch, I added it to my tree already.

>     Andrew
> 
Heiner

Re: [PATCH v2] net: phy: aquantia: readd XGMII support for AQR107

[David Miller]

From: Madalin-cristian Bucur <madalin.bucur@nxp.com>
Date: Wed, 15 May 2019 15:07:44 +0000

> XGMII interface mode no longer works on AQR107 after the recent changes,
> adding back support.
> 
> Fixes: 570c8a7d5303 ("net: phy: aquantia: check for supported interface modes in config_init")
> Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>

Applied, thanks.