[PATCH] check for handle creation failures in seobject

[PATCH] check for handle creation failures in seobject

[Karl MacMillan]

seobject.py assumes that handle creation always succeeds, though this is 
not always the case. This patch checks for that failure.

Signed-off-by: Karl MacMillan <kmacmillan@mentalrootkit.com>

diff -r 4400130009b8 policycoreutils/semanage/seobject.py
--- a/policycoreutils/semanage/seobject.py	Fri Jan 05 11:19:01 2007 -0500
+++ b/policycoreutils/semanage/seobject.py	Fri Jan 05 11:24:32 2007 -0500
@@ -208,6 +208,9 @@ class semanageRecords:
  class semanageRecords:
  	def __init__(self):
  		self.sh = semanage_handle_create()
+                if not self.sh:
+                       raise ValueError(_("Could not create semanage 
handle"))
+
  		self.semanaged = semanage_is_managed(self.sh)

  		if not self.semanaged:

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: [PATCH] check for handle creation failures in seobject

[Karl MacMillan]

Karl MacMillan wrote:
> seobject.py assumes that handle creation always succeeds, though this is 
> not always the case. This patch checks for that failure.
> 
> Signed-off-by: Karl MacMillan <kmacmillan@mentalrootkit.com>
> 

Another try without line wrapping and with tabs instead of spaces.


diff -r 5e7683c788a4 policycoreutils/semanage/seobject.py
--- a/policycoreutils/semanage/seobject.py	Fri Jan 05 12:05:19 2007 -0500
+++ b/policycoreutils/semanage/seobject.py	Fri Jan 05 12:08:34 2007 -0500
@@ -208,6 +208,9 @@ class semanageRecords:
  class semanageRecords:
  	def __init__(self):
  		self.sh = semanage_handle_create()
+		if not self.sh:
+		       raise ValueError(_("Could not create semanage handle"))
+		
  		self.semanaged = semanage_is_managed(self.sh)

  		if not self.semanaged:


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: [PATCH] check for handle creation failures in seobject

[Joshua Brindle]

Karl MacMillan wrote:
> Karl MacMillan wrote:
>> seobject.py assumes that handle creation always succeeds, though this 
>> is not always the case. This patch checks for that failure.
>>
>> Signed-off-by: Karl MacMillan <kmacmillan@mentalrootkit.com>
>>
>
> Another try without line wrapping and with tabs instead of spaces.
>
>
> diff -r 5e7683c788a4 policycoreutils/semanage/seobject.py
> --- a/policycoreutils/semanage/seobject.py    Fri Jan 05 12:05:19 2007 
> -0500
> +++ b/policycoreutils/semanage/seobject.py    Fri Jan 05 12:08:34 2007 
> -0500
> @@ -208,6 +208,9 @@ class semanageRecords:
>  class semanageRecords:
>      def __init__(self):
>          self.sh = semanage_handle_create()
> +        if not self.sh:
> +               raise ValueError(_("Could not create semanage handle"))
> +       
>          self.semanaged = semanage_is_managed(self.sh)
>
>          if not self.semanaged:
>
Acked-By: Joshua Brindle <jbrindle@tresys.com>


--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

Re: [PATCH] check for handle creation failures in seobject

[Joshua Brindle]

Karl MacMillan wrote:
> Karl MacMillan wrote:
>> seobject.py assumes that handle creation always succeeds, though this 
>> is not always the case. This patch checks for that failure.
>>
>> Signed-off-by: Karl MacMillan <kmacmillan@mentalrootkit.com>
>>
>
> Another try without line wrapping and with tabs instead of spaces.
>
>
Merged this along with the libsemanage error code propagation and the 
disk reduction patches as of libsemanage 1.9.2 and policycoreutils 1.33.10



--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.