Re: [gentuu@gmail.com: iptables static build bug]

Re: [gentuu@gmail.com: iptables static build bug]

[Patrick McHardy]

Harald Welte wrote:
> Hi all,
> 
> Please verify this bug report / patch, thanks!


The tryload stuff has always been a mystery for me, so someone else
should probably have a look at this ..


> ------------------------------------------------------------------------
> 
> Subject:
> iptables static build bug
> From:
> "Tux P" <gentuu@gmail.com>
> Date:
> Mon, 18 Dec 2006 11:29:10 +0200
> To:
> marc@mbsi.ca
> 
> [...]
> I found subj. Static iptables tries to load kernel modules
> (modprobe fails and shows pesky message about every iptables run)
> regardless their static present in the kernel.
> 
> and created a simple patch to fix this.
> Please look (also attached):
> 
> --- iptables-1.3.7/iptables.c.orig      2006-12-04 03:15:20.000000000 -0800
> +++ iptables-1.3.7/iptables.c   2006-12-18 00:50:51.000000000 -0800
> @@ -774,7 +774,7 @@
>        }
> #else
>        if (ptr && !ptr->loaded) {
> -               if (tryload != DONT_LOAD)
> +               if (tryload != DONT_LOAD && tryload != DURING_LOAD)
>                        ptr->loaded = 1;
>                else
>                        ptr = NULL;
> @@ -1093,7 +1093,7 @@
>        }
> #else
>        if (ptr && !ptr->loaded) {
> -               if (tryload != DONT_LOAD)
> +               if (tryload != DONT_LOAD && tryload != DURING_LOAD)
>                        ptr->loaded = 1;
>                else
>                        ptr = NULL;
> 
> 
> 
> Thanks
> 
> Nick
> 

[gentuu@gmail.com: iptables static build bug]

[Harald Welte]

[-- Attachment #1.1: Type: text/plain, Size: 432 bytes --]

Hi all,

Please verify this bug report / patch, thanks!

-- 
- Harald Welte <laforge@netfilter.org>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #1.2: Type: message/rfc822, Size: 4323 bytes --]

[-- Attachment #1.2.1.1.1: Type: text/plain, Size: 972 bytes --]

Hi *,

I found subj. Static iptables tries to load kernel modules
(modprobe fails and shows pesky message about every iptables run)
regardless their static present in the kernel.

and created a simple patch to fix this.
Please look (also attached):

--- iptables-1.3.7/iptables.c.orig      2006-12-04 03:15:20.000000000 -0800
+++ iptables-1.3.7/iptables.c   2006-12-18 00:50:51.000000000 -0800
@@ -774,7 +774,7 @@
        }
 #else
        if (ptr && !ptr->loaded) {
-               if (tryload != DONT_LOAD)
+               if (tryload != DONT_LOAD && tryload != DURING_LOAD)
                        ptr->loaded = 1;
                else
                        ptr = NULL;
@@ -1093,7 +1093,7 @@
        }
 #else
        if (ptr && !ptr->loaded) {
-               if (tryload != DONT_LOAD)
+               if (tryload != DONT_LOAD && tryload != DURING_LOAD)
                        ptr->loaded = 1;
                else
                        ptr = NULL;



Thanks

Nick

[-- Attachment #1.2.1.2: static_iptables_modprobe.patch --]
[-- Type: application/octet-stream, Size: 517 bytes --]

--- iptables-1.3.7/iptables.c.orig	2006-12-04 03:15:20.000000000 -0800
+++ iptables-1.3.7/iptables.c	2006-12-18 00:50:51.000000000 -0800
@@ -774,7 +774,7 @@
 	}
 #else
 	if (ptr && !ptr->loaded) {
-		if (tryload != DONT_LOAD)
+		if (tryload != DONT_LOAD && tryload != DURING_LOAD)
 			ptr->loaded = 1;
 		else
 			ptr = NULL;
@@ -1093,7 +1093,7 @@
 	}
 #else
 	if (ptr && !ptr->loaded) {
-		if (tryload != DONT_LOAD)
+		if (tryload != DONT_LOAD && tryload != DURING_LOAD)
 			ptr->loaded = 1;
 		else
 			ptr = NULL;

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]