All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: Roland Dreier <rdreier@cisco.com>
Cc: kvm-devel <kvm-devel@lists.sourceforge.net>,
	linux-kernel@vger.kernel.org
Subject: Re: [kvm-devel] guest crash on 2.6.20-rc4
Date: Thu, 11 Jan 2007 10:06:20 +0200	[thread overview]
Message-ID: <45A5EFFC.2080609@qumranet.com> (raw)
In-Reply-To: <ada8xgay3b7.fsf@cisco.com>

Roland Dreier wrote:
>  >  	if (is_writeble_pte(*shadow_ent))
>  > -		return 0;
>  > +		return 1;
>
> With this patch, it looks like my guest is surviving the load that
> triggered the oops before.  So I think this fixes the issue I saw as well.
> I assume you'll send this in for 2.6.20?
>   

The patch actually replaces one bug (guest pagefaults on writable dirty 
ptes, under certain conditions) with another, rarer one (spinning on a 
user-mode pagefault on writable dirty kernel ptes).  I'll do it right 
and re-test, then send for .20 along with a few friends.


-- 
error compiling committee.c: too many arguments to function


WARNING: multiple messages have this Message-ID (diff)
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
Cc: kvm-devel
	<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: guest crash on 2.6.20-rc4
Date: Thu, 11 Jan 2007 10:06:20 +0200	[thread overview]
Message-ID: <45A5EFFC.2080609@qumranet.com> (raw)
In-Reply-To: <ada8xgay3b7.fsf-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>

Roland Dreier wrote:
>  >  	if (is_writeble_pte(*shadow_ent))
>  > -		return 0;
>  > +		return 1;
>
> With this patch, it looks like my guest is surviving the load that
> triggered the oops before.  So I think this fixes the issue I saw as well.
> I assume you'll send this in for 2.6.20?
>   

The patch actually replaces one bug (guest pagefaults on writable dirty 
ptes, under certain conditions) with another, rarer one (spinning on a 
user-mode pagefault on writable dirty kernel ptes).  I'll do it right 
and re-test, then send for .20 along with a few friends.


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

  reply	other threads:[~2007-01-11  8:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-08 16:18 guest crash on 2.6.20-rc4 Roland Dreier
2007-01-09  8:53 ` [kvm-devel] " Avi Kivity
2007-01-09  8:53   ` Avi Kivity
2007-01-09 21:26 ` [kvm-devel] " Avi Kivity
2007-01-10 18:31   ` Roland Dreier
2007-01-10 21:33   ` Roland Dreier
2007-01-10 21:33     ` Roland Dreier
2007-01-11  8:06     ` Avi Kivity [this message]
2007-01-11  8:06       ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45A5EFFC.2080609@qumranet.com \
    --to=avi@qumranet.com \
    --cc=kvm-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdreier@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.