Re: [PATCH] Remove CONFIG_NET_WIRELESS

Re: [PATCH] Remove CONFIG_NET_WIRELESS

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

On Sat, 2007-01-13 at 18:17 +0100, Maarten Lankhorst wrote:
> Remove CONFIG_NET_WIRELESS
> Nothing uses this, and it breaks the kernel build if a wireless device is used with a unsupported type of bus.
> Verified this with a grep.

I don't really care about the symbol and I'm in favour of removing it if
it is useless, but I don't understand the rationale. How does enabling
this cause anything to fail?

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

Re: [PATCH] Remove CONFIG_NET_WIRELESS

[Maarten Lankhorst]

Johannes Berg schreef:
> On Sat, 2007-01-13 at 18:17 +0100, Maarten Lankhorst wrote:
>   
>> Remove CONFIG_NET_WIRELESS
>> Nothing uses this, and it breaks the kernel build if a wireless device is used with a unsupported type of bus.
>> Verified this with a grep.
>>     
>
> I don't really care about the symbol and I'm in favour of removing it if
> it is useless, but I don't understand the rationale. How does enabling
> this cause anything to fail?
>
> johannes
>   
Enabling this doesn't cause anything to fail, but my wireless router
doesn't have a pci bus, but instead a native SSB, so CONFIG_NET_WIRELESS
isn't selected. This in turn causes wext-common.o to not be built, so I
get missing symbols and a build breakage. That's why I made
wext-common.o depend on CONFIG_WIRELESS_EXT instead of
CONFIG_NET_WIRELESS. Since nothing else uses CONFIG_NET_WIRELESS I
decided to kill that symbol.

maarten

Re: [PATCH] Remove CONFIG_NET_WIRELESS

[Johannes Berg]

[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

On Mon, 2007-01-15 at 13:55 +0100, Maarten Lankhorst wrote:
> Johannes Berg schreef:
> > On Sat, 2007-01-13 at 18:17 +0100, Maarten Lankhorst wrote:
> >   
> >> Remove CONFIG_NET_WIRELESS
> >> Nothing uses this, and it breaks the kernel build if a wireless device is used with a unsupported type of bus.
> >> Verified this with a grep.
> >>     
> >
> > I don't really care about the symbol and I'm in favour of removing it if
> > it is useless, but I don't understand the rationale. How does enabling
> > this cause anything to fail?
> >
> > johannes
> >   
> Enabling this doesn't cause anything to fail, but my wireless router
> doesn't have a pci bus, but instead a native SSB, so CONFIG_NET_WIRELESS
> isn't selected. This in turn causes wext-common.o to not be built, so I
> get missing symbols and a build breakage. That's why I made
> wext-common.o depend on CONFIG_WIRELESS_EXT instead of
> CONFIG_NET_WIRELESS. Since nothing else uses CONFIG_NET_WIRELESS I
> decided to kill that symbol.

Ok, that makes sense to me. Let's put this in but with this better
description rather than the original one.

johannes

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 190 bytes --]

Re: [PATCH] Remove CONFIG_NET_WIRELESS

[Jiri Benc]

On Mon, 15 Jan 2007 13:31:06 +0000, Johannes Berg wrote:
> On Mon, 2007-01-15 at 13:55 +0100, Maarten Lankhorst wrote:
> > Enabling this doesn't cause anything to fail, but my wireless router
> > doesn't have a pci bus, but instead a native SSB, so CONFIG_NET_WIRELESS
> > isn't selected. This in turn causes wext-common.o to not be built, so I
> > get missing symbols and a build breakage. That's why I made
> > wext-common.o depend on CONFIG_WIRELESS_EXT instead of
> > CONFIG_NET_WIRELESS. Since nothing else uses CONFIG_NET_WIRELESS I
> > decided to kill that symbol.
> 
> Ok, that makes sense to me. Let's put this in but with this better
> description rather than the original one.

The original mail with patch apparently didn't get to netdev (I haven't
received it and it's not in netdev archive). Maarten, could you resend
it please?

Thanks,

 Jiri

-- 
Jiri Benc
SUSE Labs

Re: [PATCH] Remove CONFIG_NET_WIRELESS

[Maarten Lankhorst]

Jiri Benc schreef:
> On Mon, 15 Jan 2007 13:31:06 +0000, Johannes Berg wrote:
>   
>> On Mon, 2007-01-15 at 13:55 +0100, Maarten Lankhorst wrote:
>>     
>>> Enabling this doesn't cause anything to fail, but my wireless router
>>> doesn't have a pci bus, but instead a native SSB, so CONFIG_NET_WIRELESS
>>> isn't selected. This in turn causes wext-common.o to not be built, so I
>>> get missing symbols and a build breakage. That's why I made
>>> wext-common.o depend on CONFIG_WIRELESS_EXT instead of
>>> CONFIG_NET_WIRELESS. Since nothing else uses CONFIG_NET_WIRELESS I
>>> decided to kill that symbol.
>>>       
>> Ok, that makes sense to me. Let's put this in but with this better
>> description rather than the original one.
>>     
>
> The original mail with patch apparently didn't get to netdev (I haven't
> received it and it's not in netdev archive). Maarten, could you resend
> it please?
>
> Thanks,
>
>  Jiri
>
>   
Sorry, must have missed sending it to netdev, original message follows.

Remove CONFIG_NET_WIRELESS
Nothing uses this, and it breaks the kernel build if a wireless device is used with a unsupported type of bus.
Verified this with a grep.

Signed-off-by: Maarten Lankhorst <m.b.lankhorst@gmail.com>

diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
index 03dbe60..b9620c6 100644
--- a/drivers/net/wireless/Kconfig
+++ b/drivers/net/wireless/Kconfig
@@ -544,11 +544,5 @@ source "drivers/net/wireless/zd1211rw/Kc
 
 source "drivers/net/wireless/d80211/Kconfig"
 
-# yes, this works even when no drivers are selected
-config NET_WIRELESS
-	bool
-	depends on NET_RADIO && (ISA || PCI || PPC_PMAC || PCMCIA)
-	default y
-
 endmenu
 
diff --git a/net/wireless/Makefile b/net/wireless/Makefile
index f285440..44ae23a 100644
--- a/net/wireless/Makefile
+++ b/net/wireless/Makefile
@@ -12,5 +12,5 @@ obj-ny :=
 
 # this needs to be compiled in...
 obj-$(CONFIG_CFG80211_WEXT_COMPAT) += wext-compat.o
-obj-$(CONFIG_CFG80211_WEXT_COMPAT)$(CONFIG_NET_WIRELESS) += wext-common.o
+obj-$(CONFIG_CFG80211_WEXT_COMPAT)$(CONFIG_WIRELESS_EXT) += wext-common.o
 obj-y += $(obj-yy) $(obj-yn) $(obj-ny)