From: Jeff Garzik <jeff@garzik.org>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: Akira Iguchi <akira2.iguchi@toshiba.co.jp>,
linux-ide@vger.kernel.org, linuxppc-dev@ozlabs.org,
kou.ishizaki@toshiba.co.jp, benh@kernel.crashing.org,
arnd@arndb.de, paulus@samba.org, linas@austin.ibm.com
Subject: Re: [PATCH 3/4] libata-sff.c: add another IRQ calls
Date: Tue, 16 Jan 2007 17:05:45 -0500 [thread overview]
Message-ID: <45AD4C39.3050202@garzik.org> (raw)
In-Reply-To: <20070116120450.1bb44ebb@localhost.localdomain>
Alan wrote:
> On Tue, 16 Jan 2007 19:46:23 +0900
> Akira Iguchi <akira2.iguchi@toshiba.co.jp> wrote:
>
>> When enabling IRQ, ap->ops->irq_on is checked.
>> Because most drivers can use ata_irq_on() as is, this
>> patch allows ap->ops->irq_on to be NULL.
>> If it is NULL, ata_irq_on() are used.
>
>
> I believe you can now remove the if(ap->ioaddr.ctl_addr) check as any
> device lacking a ctl_addr can now provide an irq_on() method using your
> changes.
>
> You've fixed the FIXME
Agreed.
Abstracting out the Control/Alt-Status register block operations has
been a long-standing TODO that I knew would be required, sometime down
the line. I certainly support adding such abstractions, as they are
required for several non-x86 IDE drivers, not just Cell.
Jeff
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jeff@garzik.org>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: arnd@arndb.de, linuxppc-dev@ozlabs.org,
linux-ide@vger.kernel.org, paulus@samba.org
Subject: Re: [PATCH 3/4] libata-sff.c: add another IRQ calls
Date: Tue, 16 Jan 2007 17:05:45 -0500 [thread overview]
Message-ID: <45AD4C39.3050202@garzik.org> (raw)
In-Reply-To: <20070116120450.1bb44ebb@localhost.localdomain>
Alan wrote:
> On Tue, 16 Jan 2007 19:46:23 +0900
> Akira Iguchi <akira2.iguchi@toshiba.co.jp> wrote:
>
>> When enabling IRQ, ap->ops->irq_on is checked.
>> Because most drivers can use ata_irq_on() as is, this
>> patch allows ap->ops->irq_on to be NULL.
>> If it is NULL, ata_irq_on() are used.
>
>
> I believe you can now remove the if(ap->ioaddr.ctl_addr) check as any
> device lacking a ctl_addr can now provide an irq_on() method using your
> changes.
>
> You've fixed the FIXME
Agreed.
Abstracting out the Control/Alt-Status register block operations has
been a long-standing TODO that I knew would be required, sometime down
the line. I certainly support adding such abstractions, as they are
required for several non-x86 IDE drivers, not just Cell.
Jeff
next prev parent reply other threads:[~2007-01-16 22:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200701161046.l0GAkE5u029367@toshiba.co.jp>
2007-01-16 12:04 ` [PATCH 3/4] libata-sff.c: add another IRQ calls Alan
2007-01-16 12:04 ` Alan
2007-01-16 22:05 ` Jeff Garzik [this message]
2007-01-16 22:05 ` Jeff Garzik
2007-01-16 10:46 Akira Iguchi
-- strict thread matches above, loose matches on Subject: below --
2007-01-16 10:46 Akira Iguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45AD4C39.3050202@garzik.org \
--to=jeff@garzik.org \
--cc=akira2.iguchi@toshiba.co.jp \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=kou.ishizaki@toshiba.co.jp \
--cc=linas@austin.ibm.com \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.