* unstable changeset 13416 (save restore: vcpu context support) ...
@ 2007-01-19 9:24 Gerd Hoffmann
2007-01-19 11:40 ` Keir Fraser
0 siblings, 1 reply; 4+ messages in thread
From: Gerd Hoffmann @ 2007-01-19 9:24 UTC (permalink / raw)
To: Xen devel list
Hi,
... adds hvmcpu_context to vcpu_guest_context, thus making it binary
incompatible. Is that ABI change ok? Looks like it is dom0 API only,
so I think we are fine, but I think I better ask ...
cheers,
Gerd
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: unstable changeset 13416 (save restore: vcpu context support) ...
2007-01-19 9:24 unstable changeset 13416 (save restore: vcpu context support) Gerd Hoffmann
@ 2007-01-19 11:40 ` Keir Fraser
2007-01-22 2:06 ` Zhai, Edwin
0 siblings, 1 reply; 4+ messages in thread
From: Keir Fraser @ 2007-01-19 11:40 UTC (permalink / raw)
To: Gerd Hoffmann, Xen devel list
It's used by SMP guests when bringing up APs. So that change will have to be
reverted. Thanks for spotting it!
-- Keir
On 19/1/07 09:24, "Gerd Hoffmann" <kraxel@novell.com> wrote:
> Hi,
>
> ... adds hvmcpu_context to vcpu_guest_context, thus making it binary
> incompatible. Is that ABI change ok? Looks like it is dom0 API only,
> so I think we are fine, but I think I better ask ...
>
> cheers,
> Gerd
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: unstable changeset 13416 (save restore: vcpu context support) ...
2007-01-19 11:40 ` Keir Fraser
@ 2007-01-22 2:06 ` Zhai, Edwin
2007-01-22 8:37 ` Keir Fraser
0 siblings, 1 reply; 4+ messages in thread
From: Zhai, Edwin @ 2007-01-22 2:06 UTC (permalink / raw)
To: Keir Fraser; +Cc: Xen devel list, Gerd Hoffmann
On Fri, Jan 19, 2007 at 11:40:03AM +0000, Keir Fraser wrote:
>
> It's used by SMP guests when bringing up APs. So that change will have to be
> reverted. Thanks for spotting it!
keir,
could you elaborate on this? does it means SMP guest save/restore failure?
thanks,
>
> -- Keir
>
> On 19/1/07 09:24, "Gerd Hoffmann" <kraxel@novell.com> wrote:
>
> > Hi,
> >
> > ... adds hvmcpu_context to vcpu_guest_context, thus making it binary
> > incompatible. Is that ABI change ok? Looks like it is dom0 API only,
> > so I think we are fine, but I think I better ask ...
> >
> > cheers,
> > Gerd
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xensource.com
> > http://lists.xensource.com/xen-devel
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>
--
best rgds,
edwin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: unstable changeset 13416 (save restore: vcpu context support) ...
2007-01-22 2:06 ` Zhai, Edwin
@ 2007-01-22 8:37 ` Keir Fraser
0 siblings, 0 replies; 4+ messages in thread
From: Keir Fraser @ 2007-01-22 8:37 UTC (permalink / raw)
To: Zhai, Edwin, Keir Fraser; +Cc: Xen devel list, Gerd Hoffmann
On 22/1/07 2:06 am, "Zhai, Edwin" <edwin.zhai@intel.com> wrote:
>> It's used by SMP guests when bringing up APs. So that change will have to be
>> reverted. Thanks for spotting it!
>
> keir,
> could you elaborate on this? does it means SMP guest save/restore failure?
The change to vcpu_guest_context would have broken SMP bringup for old
guests, since they know about the old layout of vcpu_guest_context.
Reverting that change will have broken HVM save/restore entirely, but Tim
has been making cleanups that should have fixed this again.
-- Keir
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-01-22 8:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-19 9:24 unstable changeset 13416 (save restore: vcpu context support) Gerd Hoffmann
2007-01-19 11:40 ` Keir Fraser
2007-01-22 2:06 ` Zhai, Edwin
2007-01-22 8:37 ` Keir Fraser
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.