[KJ] script to flag "dead" CONFIG variables

[KJ] script to flag "dead" CONFIG variables

[Robert P. J. Day]

  it's all written up here:

http://www.fsdev.dreamhosters.com/wiki/index.php?titleÞad_CONFIG_variables

rday

-- 
===============================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
===============================================
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] script to flag "dead" CONFIG variables

[walter harms]

hi robert,
are you aware of ifnames ? it is part auf the autoconf tools
and lists all the #if #elif etc.

that should surface all important vars and a compare with kconfig should show up
any dead variables.
bonus points for collecting all #defines also.

re,
 wh



Robert P. J. Day wrote:
>   it's all written up here:
> 
> http://www.fsdev.dreamhosters.com/wiki/index.php?titleÞad_CONFIG_variables
> 
> rday
> 
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] script to flag "dead" CONFIG variables

[Robert P. J. Day]

On Wed, 24 Jan 2007, walter harms wrote:

> hi robert,
> are you aware of ifnames ? it is part auf the autoconf tools
> and lists all the #if #elif etc.

um ... yeah, that'll make my life *way* easier.  :-)  thanks.

> that should surface all important vars and a compare with kconfig
> should show up any dead variables. bonus points for collecting all
> #defines also.

i'll see what i can do with that.

rday

-- 
===============================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://www.fsdev.dreamhosters.com/wiki/index.php?title=Kernel_Janitor%27s_Todo_List
===============================================
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] script to flag "dead" CONFIG variables

[Robert P. J. Day]

On Wed, 24 Jan 2007, walter harms wrote:

> hi robert, are you aware of ifnames ? it is part auf the autoconf
> tools and lists all the #if #elif etc.
>
> that should surface all important vars and a compare with kconfig
> should show up any dead variables. bonus points for collecting all
> #defines also.

ok, i've rewritten the script using "ifnames" and i'm getting a *lot*
more "dead" config variables, just based on the fact that i'm pulling
more CONFIG variables out of preprocessor lines than i was before.

the updated script is again at:

http://www.fsdev.dreamhosters.com/wiki/index.php?titleÞad_CONFIG_variables

and it's taking a *while* to run.  yowch.  so far, it's found 407 dead
variables as compared to 284 last time, and it's still working on the
"S"s.

rday

-- 
===============================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://www.fsdev.dreamhosters.com/wiki/index.php?title=Kernel_Janitor%27s_Todo_List
===============================================
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] script to flag "dead" CONFIG variables

[Alexey Dobriyan]

On Wed, Jan 24, 2007 at 07:36:54AM -0500, Robert P. J. Day wrote:
>   it's all written up here:
>
> http://www.fsdev.dreamhosters.com/wiki/index.php?titleÞad_CONFIG_variables

That's a good script.

There is another failure mode: CONFIG_FOO is defined, all right, but
code tests for FOO. ARCH_HAS_ILOG2_U32 and _U64, haven't seen more.

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] script to flag "dead" CONFIG variables

[Robert P. J. Day]

On Thu, 25 Jan 2007, Alexey Dobriyan wrote:

> On Wed, Jan 24, 2007 at 07:36:54AM -0500, Robert P. J. Day wrote:
> >   it's all written up here:
> >
> > http://www.fsdev.dreamhosters.com/wiki/index.php?titleÞad_CONFIG_variables
>
> That's a good script.
>
> There is another failure mode: CONFIG_FOO is defined, all right, but
> code tests for FOO. ARCH_HAS_ILOG2_U32 and _U64, haven't seen more.

hmmmmmm ... that could be trickier since, if you see code testing for
FOO, maybe it's the case that it really *should* be testing for FOO
(which isn't defined anywhere), and the fact that some Kconfig file
defines CONFIG_FOO is a complete coincidence.  stranger things have
happened, but i suspect i can add some kind of check for that.

also, based on what i saw in some early runs, am i right in assuming
that, if you select the kernel feature FUBAR to be built as a module,
that will define the macro CONFIG_FUBAR_MODULE as opposed to just
CONFIG_FUBAR?  that's the assumption i was making, and i can probably
clean up that script a bit more.

rday

p.s.  if that MODULE assumption is correct, where in the configuration
process does that macro get defined that way?  i'm just curious.

-- 
===============================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://www.fsdev.dreamhosters.com/wiki/index.php?title=Kernel_Janitor%27s_Todo_List
===============================================
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] script to flag "dead" CONFIG variables

[Robert P. J. Day]

On Thu, 25 Jan 2007, Alexey Dobriyan wrote:

> On Wed, Jan 24, 2007 at 07:36:54AM -0500, Robert P. J. Day wrote:
> >   it's all written up here:
> >
> > http://www.fsdev.dreamhosters.com/wiki/index.php?titleÞad_CONFIG_variables
>
> That's a good script.

i just uploaded a slightly cleaned-up version to the wiki page.  when
i wrote it, i was guessing i might find a couple dozen variables or
so, and i could do a little cleanup in my spare time to fix them.

at the moment, i get 347 hits, and there's no way i'm going to touch
*that* kind of job.  better if individual subsystem maintainers run
that script on their own stuff and deal with the output, methinks.

rday

-- 
===============================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://www.fsdev.dreamhosters.com/wiki/index.php?title=Kernel_Janitor%27s_Todo_List
===============================================
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors