From: Jeff Garzik <jeff@garzik.org>
To: Akira Iguchi <akira2.iguchi@toshiba.co.jp>
Cc: linux-ide@vger.kernel.org, linuxppc-dev@ozlabs.org,
kou.ishizaki@toshiba.co.jp, benh@kernel.crashing.org,
arnd@arndb.de, paulus@samba.org, linas@austin.ibm.com,
alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH 1/4] libata.h: add another IRQ calls
Date: Wed, 24 Jan 2007 20:10:45 -0500 [thread overview]
Message-ID: <45B80395.50302@garzik.org> (raw)
In-Reply-To: <200701161045.l0GAjwJ0029209@toshiba.co.jp>
Akira Iguchi wrote:
> Two IRQ calls are added in ata_port_operations.
> - irq_on() is used to enable interrupts.
> - irq_ack() is used to acknowledge a device interrupt.
>
> And there are additional function declarations which are
> used in pata_scc.c.
>
> Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
> Signed-off-by: Akira Iguchi <akira2.iguchi@toshiba.co.jp>
After this round of comments, please resend the entire patchset, so that
I have everything straight.
> @@ -761,6 +763,9 @@ extern void ata_port_queue_task(struct a
> extern u32 ata_wait_register(void __iomem *reg, u32 mask, u32 val,
> unsigned long interval_msec,
> unsigned long timeout_msec);
> +unsigned int ata_dev_try_classify(struct ata_port *, unsigned int, u8 *);
> +struct ata_probe_ent *ata_probe_ent_alloc(struct device *,
> + const struct ata_port_info *);
>
To properly export these functions, (a) remove their declarations from
drivers/ata/libata.h and (b) add EXPORT_SYMBOL_GPL() declarations.
Jeff
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jeff@garzik.org>
To: Akira Iguchi <akira2.iguchi@toshiba.co.jp>
Cc: arnd@arndb.de, linuxppc-dev@ozlabs.org,
linux-ide@vger.kernel.org, paulus@samba.org,
alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH 1/4] libata.h: add another IRQ calls
Date: Wed, 24 Jan 2007 20:10:45 -0500 [thread overview]
Message-ID: <45B80395.50302@garzik.org> (raw)
In-Reply-To: <200701161045.l0GAjwJ0029209@toshiba.co.jp>
Akira Iguchi wrote:
> Two IRQ calls are added in ata_port_operations.
> - irq_on() is used to enable interrupts.
> - irq_ack() is used to acknowledge a device interrupt.
>
> And there are additional function declarations which are
> used in pata_scc.c.
>
> Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
> Signed-off-by: Akira Iguchi <akira2.iguchi@toshiba.co.jp>
After this round of comments, please resend the entire patchset, so that
I have everything straight.
> @@ -761,6 +763,9 @@ extern void ata_port_queue_task(struct a
> extern u32 ata_wait_register(void __iomem *reg, u32 mask, u32 val,
> unsigned long interval_msec,
> unsigned long timeout_msec);
> +unsigned int ata_dev_try_classify(struct ata_port *, unsigned int, u8 *);
> +struct ata_probe_ent *ata_probe_ent_alloc(struct device *,
> + const struct ata_port_info *);
>
To properly export these functions, (a) remove their declarations from
drivers/ata/libata.h and (b) add EXPORT_SYMBOL_GPL() declarations.
Jeff
next parent reply other threads:[~2007-01-25 1:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200701161045.l0GAjwJ0029209@toshiba.co.jp>
2007-01-25 1:10 ` Jeff Garzik [this message]
2007-01-25 1:10 ` [PATCH 1/4] libata.h: add another IRQ calls Jeff Garzik
2007-01-16 10:46 Akira Iguchi
-- strict thread matches above, loose matches on Subject: below --
2007-01-16 10:46 Akira Iguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45B80395.50302@garzik.org \
--to=jeff@garzik.org \
--cc=akira2.iguchi@toshiba.co.jp \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=kou.ishizaki@toshiba.co.jp \
--cc=linas@austin.ibm.com \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.