From: Jeff Garzik <jeff@garzik.org>
To: Akira Iguchi <akira2.iguchi@toshiba.co.jp>
Cc: Mikael Pettersson <mikpe@it.uu.se>,
alan@lxorguk.ukuu.org.uk, benh@kernel.crashing.org,
arnd@arndb.de, kou.ishizaki@toshiba.co.jp, linas@austin.ibm.com,
linux-ide@vger.kernel.org, linuxppc-dev@ozlabs.org,
paulus@samba.org
Subject: Re: [PATCH] driver/ata: PATA driver for Celleb
Date: Wed, 24 Jan 2007 20:20:33 -0500 [thread overview]
Message-ID: <45B805E1.1030906@garzik.org> (raw)
In-Reply-To: <200701180129.l0I1TL48013407@toshiba.co.jp>
Akira Iguchi wrote:
> This is the patch for PATA controller of Celleb.
> It depends on the previous "add another IRQ calls" patch.
>
> Because this driver needs special taskfile accesses, there is
> a copy of ata_std_softreset(). ata_dev_try_classify() is exported
> so that it can be used in this function.
>
> Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
> Signed-off-by: Akira Iguchi <akira2.iguchi@toshiba.co.jp>
The driver looks OK, the only thing I wonder is: can you use the iomap
interface to eliminate the rest of the duplicated code?
See Tejun's latest patchset "[PATCHSET] Managed device resources, take
#3" which completes the conversion of libata to using the lib/iomap.c
interface.
Jeff
WARNING: multiple messages have this Message-ID (diff)
From: Jeff Garzik <jeff@garzik.org>
To: Akira Iguchi <akira2.iguchi@toshiba.co.jp>
Cc: Mikael Pettersson <mikpe@it.uu.se>,
arnd@arndb.de, linuxppc-dev@ozlabs.org,
linux-ide@vger.kernel.org, paulus@samba.org,
alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] driver/ata: PATA driver for Celleb
Date: Wed, 24 Jan 2007 20:20:33 -0500 [thread overview]
Message-ID: <45B805E1.1030906@garzik.org> (raw)
In-Reply-To: <200701180129.l0I1TL48013407@toshiba.co.jp>
Akira Iguchi wrote:
> This is the patch for PATA controller of Celleb.
> It depends on the previous "add another IRQ calls" patch.
>
> Because this driver needs special taskfile accesses, there is
> a copy of ata_std_softreset(). ata_dev_try_classify() is exported
> so that it can be used in this function.
>
> Signed-off-by: Kou Ishizaki <kou.ishizaki@toshiba.co.jp>
> Signed-off-by: Akira Iguchi <akira2.iguchi@toshiba.co.jp>
The driver looks OK, the only thing I wonder is: can you use the iomap
interface to eliminate the rest of the duplicated code?
See Tejun's latest patchset "[PATCHSET] Managed device resources, take
#3" which completes the conversion of libata to using the lib/iomap.c
interface.
Jeff
next prev parent reply other threads:[~2007-01-25 1:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-17 9:24 [PATCH 2/4] libata-core.c: add another IRQ calls Mikael Pettersson
2007-01-17 9:24 ` Mikael Pettersson
2007-01-17 16:49 ` Jeff Garzik
2007-01-17 16:49 ` Jeff Garzik
2007-01-17 20:31 ` Mikael Pettersson
2007-01-17 20:31 ` Mikael Pettersson
2007-01-18 0:55 ` Akira Iguchi
2007-01-18 1:29 ` [PATCH] driver/ata: PATA driver for Celleb Akira Iguchi
2007-01-18 1:29 ` Akira Iguchi
2007-01-25 1:20 ` Jeff Garzik [this message]
2007-01-25 1:20 ` Jeff Garzik
2007-01-25 3:45 ` Benjamin Herrenschmidt
2007-01-25 3:45 ` Benjamin Herrenschmidt
2007-01-25 1:17 ` [PATCH 2/4] libata-core.c: add another IRQ calls Jeff Garzik
2007-01-25 1:17 ` Jeff Garzik
2007-01-18 0:55 ` Akira Iguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45B805E1.1030906@garzik.org \
--to=jeff@garzik.org \
--cc=akira2.iguchi@toshiba.co.jp \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=kou.ishizaki@toshiba.co.jp \
--cc=linas@austin.ibm.com \
--cc=linux-ide@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikpe@it.uu.se \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.