All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@suse.de>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: xen-devel@lists.xensource.com, xen-ia64-devel@lists.xensource.com
Subject: Re: [PATCH] fix cross compiling ia64 on x86
Date: Tue, 30 Jan 2007 14:49:14 +0100	[thread overview]
Message-ID: <45BF4CDA.1090103@suse.de> (raw)
In-Reply-To: <20070130122214.GH25482%yamahata@valinux.co.jp>

> diff -r 5bb084098493 -r 94c3db4748b2 xen/include/public/foreign/Makefile
> --- a/xen/include/public/foreign/Makefile	Mon Jan 29 13:22:21 2007 +0000
> +++ b/xen/include/public/foreign/Makefile	Tue Jan 30 16:51:51 2007 +0900
> @@ -14,12 +14,8 @@ clean:
>  	rm -f *.pyc *.o *~
>  
>  check-headers: checker
> -ifeq ($(CROSS_COMPILE),)
>  	./checker > $(XEN_TARGET_ARCH).size
>  	diff -u reference.size $(XEN_TARGET_ARCH).size
> -else
> -	@echo "cross build: skipping check"
> -endif
>  
>  x86_32.h: ../arch-x86/xen-x86_32.h ../arch-x86/xen.h ../xen.h $(scripts)
>  	python mkheader.py $* $@ $(filter %.h,$^)

Ok.

> diff -r 5bb084098493 -r 94c3db4748b2 xen/include/public/foreign/mkchecker.py
> --- a/xen/include/public/foreign/mkchecker.py	Mon Jan 29 13:22:21 2007 +0000
> +++ b/xen/include/public/foreign/mkchecker.py	Tue Jan 30 16:51:51 2007 +0900
> @@ -38,10 +38,7 @@ for struct in structs:
>  for struct in structs:
>      f.write('\tprintf("%%-20s |", "%s");\n' % struct);
>      for a in archs:
> -        if a == arch:
> -            s = struct; # native
> -        else:
> -            s = struct + "_" + a;
> +        s = struct + "_" + a;
>          f.write('#ifdef %s_has_no_%s\n' % (a, struct));
>          f.write('\tprintf("%8s", "-");\n');
>          f.write("#else\n");

No.  I intentionally use the native version here (struct foo instead of
struct foo_arch) to catch possible inconsistencies.

cheers,
  Gerd

-- 
Gerd Hoffmann <kraxel@suse.de>

  reply	other threads:[~2007-01-30 13:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-30 12:22 [PATCH] fix cross compiling ia64 on x86 Isaku Yamahata
2007-01-30 13:49 ` Gerd Hoffmann [this message]
2007-01-31  2:26   ` Isaku Yamahata
2007-01-31 11:30     ` Gerd Hoffmann
2007-02-01  2:55       ` [PATCH] fix corss compile ia64 build on x86 (Re: [PATCH] fix cross compiling ia64 on x86) Isaku Yamahata
2007-01-30 13:55 ` [PATCH] fix cross compiling ia64 on x86 Keir Fraser
2007-01-30 13:56   ` Keir Fraser
2007-01-30 14:24 ` [Xen-devel] " Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45BF4CDA.1090103@suse.de \
    --to=kraxel@suse.de \
    --cc=xen-devel@lists.xensource.com \
    --cc=xen-ia64-devel@lists.xensource.com \
    --cc=yamahata@valinux.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.