From: Jeff Garzik <jeff@garzik.org>
To: "Eric D. Mudama" <edmudama@gmail.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/1] libata: rearrange dmesg info to add full ATA revision
Date: Wed, 31 Jan 2007 10:23:24 -0500 [thread overview]
Message-ID: <45C0B46C.5080905@garzik.org> (raw)
In-Reply-To: <20070131060040.GA3361@bounceswoosh.org>
Eric D. Mudama wrote:
> Per Jeff's suggestion, this patch rearranges the info printed for ATA
> drives into dmesg to add the full ATA firmware revision and model
> information, while keeping the output to 2 lines.
>
> Signed-off-by: Eric D. Mudama <edmudama@gmail.com>
>
> ---
>
> This extra information is helpful for debugging drive-related issues
> on ATA drives connected with libata, especially when the user can't
> easily run hdparm.
>
> Update: added Tejun's formatting requests, and created the constants
> necessary.
>
> Diff is against 2.6.20-rc6 (roughly). Here's a snippet of my new
> dmesg with this patch, showing the full and truncated firmware
> revision information:
Looks pretty good to me at first glance. I'll review it again tonight
or tomorrow, when I make the next "apply SATA patches" pass.
FWIW, since this is not a bug fix, it will be going into 2.6.21 rather
than 2.6.20. As such, it will be applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
branch 'upstream' rather than branch 'upstream-fixes'.
Or, in shorthand, libata-dev.git#upstream.
Cheers and thanks,
Jeff
next prev parent reply other threads:[~2007-01-31 15:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-31 2:10 [PATCH 1/1] libata: rearrange dmesg info to add full ATA revision Eric D. Mudama
2007-01-31 3:57 ` Tejun Heo
2007-01-31 4:54 ` Tejun Heo
2007-01-31 9:16 ` Jeff Garzik
2007-01-31 6:00 ` Eric D. Mudama
2007-01-31 15:23 ` Jeff Garzik [this message]
2007-02-07 0:42 ` Jeff Garzik
2007-02-07 2:31 ` Eric D. Mudama
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C0B46C.5080905@garzik.org \
--to=jeff@garzik.org \
--cc=edmudama@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.