Re: [PATCH 1/1] libata: rearrange dmesg info to add full ATA revision

[Jeff Garzik <jeff@garzik.org>]

Eric D. Mudama wrote:
> Per Jeff's suggestion, this patch rearranges the info printed for ATA
> drives into dmesg to add the full ATA firmware revision and model
> information, while keeping the output to 2 lines.
> 
> Signed-off-by: Eric D. Mudama <edmudama@gmail.com>

> diff --git a/include/linux/ata.h b/include/linux/ata.h
> index 1df9416..aa9c1fd 100644
> --- a/include/linux/ata.h
> +++ b/include/linux/ata.h
> @@ -60,6 +60,8 @@ enum {
>  
>  	ATA_PCI_CTL_OFS		= 2,
>  	ATA_SERNO_LEN		= 20,
> +	ATA_ID_PROD_LEN         = 40,
> +	ATA_ID_FW_REV_LEN       = 16,
>  	ATA_UDMA0		= (1 << 0),
>  	ATA_UDMA1		= ATA_UDMA0 | (1 << 1),
>  	ATA_UDMA2		= ATA_UDMA1 | (1 << 2),

applied to netdev#upstream, sans the above part.  I'm not sure where you 
got 16 there?  It's 8 ASCII chars in the spec.

	Jeff