All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: bzolnier@gmail.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] amd74xx: don't configure udma mode higher than BIOS did
Date: Mon, 05 Feb 2007 21:33:03 +0900	[thread overview]
Message-ID: <45C723FF.2060405@gmail.com> (raw)
In-Reply-To: <45C72012.7050605@gmail.com>

Forgot to reply about some stuff.  Adding.

Tejun Heo wrote:
> Alan wrote:
>>> This patch makes amd74xx not configure udma mode higher than BIOS did.
>>> If BIOS configured the device <= udma44, udma33 is the maximum speed.
>> NAK
>>
>> The boot firmware for AMD/Nvidia chips is only run on PC, and the data is
>> only valid on some of them, in some cases, and not after a suspend/resume
>> cycle.

To prevent that, the value is cached on driver probe and written back on
driver detach on pata_amd, which is necessary even when there is no
suspend/resume as mode programming alters the content of the register.
amd74xx cannot be unloaded, so caching is enough.  Also, doesn't
suspend/resume cycle store and restore PCI space anyway?

Thanks.

-- 
tejun

  reply	other threads:[~2007-02-05 12:33 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-05  7:58 [PATCH] amd74xx: don't configure udma mode higher than BIOS did Tejun Heo
2007-02-05 11:24 ` Alan
2007-02-05 12:16   ` Tejun Heo
2007-02-05 12:33     ` Tejun Heo [this message]
2007-02-05 13:24       ` Alan
2007-02-05 14:17         ` Tejun Heo
2007-02-05 13:22     ` Alan
2007-02-05 14:07       ` Tejun Heo
2007-02-05 14:34         ` Nvidia cable detection problems (was [PATCH] amd74xx: don't configure udma mode higher than BIOS did) Alan
2007-02-05 14:50           ` Tejun Heo
2007-02-05 15:49             ` Alan
     [not found]             ` <58cb370e0702050709w1b7682dr5dff9e7ce69465a@mail.gmail.com>
2007-02-05 17:08               ` Allen Martin
2007-02-05 17:08                 ` Allen Martin
2007-02-05 18:12                 ` Alan
2007-02-05 18:12                   ` Alan
2007-02-05 18:36                   ` Tejun Heo
2007-02-05 18:55                     ` Bartlomiej Zolnierkiewicz
2007-02-05 19:15                       ` Tejun Heo
2007-02-05 21:27                       ` Bartlomiej Zolnierkiewicz
2007-02-05 22:02                         ` Alan
2007-02-05 22:00                           ` Bartlomiej Zolnierkiewicz
2007-02-05 19:13                     ` Alan
2007-02-05 21:43                       ` Jeff Garzik
2007-02-05 21:11                 ` Nvidia cable detection problems & ACPI (beware, slight off-top) Oleg Verych
2007-02-05 22:04                   ` Alan
2007-02-05 21:55                     ` Jeff Garzik
2007-02-05 22:42                       ` Oleg Verych
2007-02-05 22:51                         ` Jeff Garzik
2007-02-05 15:32         ` [PATCH] amd74xx: don't configure udma mode higher than BIOS did Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45C723FF.2060405@gmail.com \
    --to=htejun@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.