Re: [PATCH]: __devinit and __devexit changes to various sound drivers

Re: [PATCH]: __devinit and __devexit changes to various sound drivers

[Takashi Iwai]

At Thu, 8 Feb 2007 12:09:48 -0500,
Prarit Bhargava wrote:
> 
> __devinit and __devexit fixups to resolve MODPOST warnings:
> 
> WARNING: sound/drivers/snd-dummy.o - Section mismatch: reference to
> .init.text:snd_dummy_probe from .data.rel.local between 'snd_dummy_driver' (at
> offset 0x0) and 'snd_dummy_controls'
> WARNING: sound/drivers/snd-mtpav.o - Section mismatch: reference to
> .init.text:snd_mtpav_probe from .data.rel.local between 'snd_mtpav_driver' (at
> offset 0x0) and 'snd_mtpav_input'
> WARNING: sound/drivers/snd-virmidi.o - Section mismatch: reference to
> .init.text:snd_virmidi_probe from .data.rel.local after 'snd_virmidi_driver' (at
> offset 0x0)
> 
> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
(snip)
> 
> --- linux-2.6.19.ia64.orig/sound/drivers/dummy.c	2007-02-07 09:56:36.000000000 -0500
> +++ linux-2.6.19.ia64/sound/drivers/dummy.c	2007-02-08 11:53:11.000000000 -0500
> @@ -579,7 +579,7 @@ static int __init snd_card_dummy_new_mix
>  	return 0;
>  }
>  
> -static int __init snd_dummy_probe(struct platform_device *devptr)
> +static int __devinit snd_dummy_probe(struct platform_device *devptr)
>  {
>  	struct snd_card *card;
>  	struct snd_dummy *dummy;
> @@ -635,7 +635,7 @@ static int snd_dummy_suspend(struct plat
>  	return 0;
>  }
>  	
> -static int snd_dummy_resume(struct platform_device *pdev)
> +static int __devexit snd_dummy_resume(struct platform_device *pdev)

You're shooting the wrong function :)

Also, if we change this (obviously correct), we should change all
__init* to __devinit* accordingly.  Care to fix these?


Thanks,

Takashi

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

Re: [PATCH]: __devinit and __devexit changes to various sound drivers

[Prarit Bhargava]

>>  	
>> -static int snd_dummy_resume(struct platform_device *pdev)
>> +static int __devexit snd_dummy_resume(struct platform_device *pdev)
>>     
>
>   

> You're shooting the wrong function :)
>   


Whoops. :)  My bad.
> Also, if we change this (obviously correct), we should change all
> __init* to __devinit* accordingly.  Care to fix these?
>
>
>   

No problem -- I'll take care of that and send another patch.

(To be honest, I haven't compiled _everything_ in the directory.  I've 
been lazily working of the fedora .config ;) )

Be back in a few days ...

P.

> Thanks,
>
> Takashi
>   

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642