[PATCH] sunrpc: remove dead variable 'rpciod_running'

[PATCH] sunrpc: remove dead variable 'rpciod_running'

[Christoph Hellwig]

rpciod_running is not used at all, but due to the way DECLARE_MUTEX_LOCKED
works we don't get a warning for it.


Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: linux-2.6/net/sunrpc/sched.c
===================================================================
--- linux-2.6.orig/net/sunrpc/sched.c	2007-02-06 15:55:43.000000000 +0100
+++ linux-2.6/net/sunrpc/sched.c	2007-02-06 15:55:45.000000000 +0100
@@ -973,8 +973,6 @@
 	spin_unlock(&rpc_sched_lock);
 }
 
-static DECLARE_MUTEX_LOCKED(rpciod_running);
-
 static void rpciod_killall(void)
 {
 	unsigned long flags;

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

Re: [PATCH] sunrpc: remove dead variable 'rpciod_running'

[Chuck Lever]

[-- Attachment #1: Type: text/plain, Size: 674 bytes --]

At a glance, this looks reasonable.

Christoph Hellwig wrote:
> rpciod_running is not used at all, but due to the way DECLARE_MUTEX_LOCKED
> works we don't get a warning for it.
> 
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: linux-2.6/net/sunrpc/sched.c
> ===================================================================
> --- linux-2.6.orig/net/sunrpc/sched.c	2007-02-06 15:55:43.000000000 +0100
> +++ linux-2.6/net/sunrpc/sched.c	2007-02-06 15:55:45.000000000 +0100
> @@ -973,8 +973,6 @@
>  	spin_unlock(&rpc_sched_lock);
>  }
>  
> -static DECLARE_MUTEX_LOCKED(rpciod_running);
> -
>  static void rpciod_killall(void)
>  {
>  	unsigned long flags;


[-- Attachment #2: chuck.lever.vcf --]
[-- Type: text/x-vcard, Size: 265 bytes --]

begin:vcard
fn:Chuck Lever
n:Lever;Chuck
org:Oracle Corporation;Corporate Architecture Linux Projects Group
email;internet:chuck dot lever at nospam oracle dot com
title:Principal Member of Staff
tel;work:+1 248 614 5091
x-mozilla-html:FALSE
version:2.1
end:vcard


[-- Attachment #3: Type: text/plain, Size: 374 bytes --]

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642

[-- Attachment #4: Type: text/plain, Size: 140 bytes --]

_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

Re: [PATCH] sunrpc: remove dead variable 'rpciod_running'

[Christoph Hellwig]

On Fri, Feb 09, 2007 at 08:06:49PM +0000, Christoph Hellwig wrote:
> rpciod_running is not used at all, but due to the way DECLARE_MUTEX_LOCKED
> works we don't get a warning for it.

Looks like this one is still not in.  Any chance to send it to Linus
in this merge cycle?

> Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> Index: linux-2.6/net/sunrpc/sched.c
> ===================================================================
> --- linux-2.6.orig/net/sunrpc/sched.c	2007-02-06 15:55:43.000000000 +0100
> +++ linux-2.6/net/sunrpc/sched.c	2007-02-06 15:55:45.000000000 +0100
> @@ -973,8 +973,6 @@
>  	spin_unlock(&rpc_sched_lock);
>  }
>  
> -static DECLARE_MUTEX_LOCKED(rpciod_running);
> -
>  static void rpciod_killall(void)
>  {
>  	unsigned long flags;
---end quoted text---

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

Re: [PATCH] sunrpc: remove dead variable 'rpciod_running'

[Trond Myklebust]

On Sun, 2007-05-13 at 16:10 +0100, Christoph Hellwig wrote:
> On Fri, Feb 09, 2007 at 08:06:49PM +0000, Christoph Hellwig wrote:
> > rpciod_running is not used at all, but due to the way DECLARE_MUTEX_LOCKED
> > works we don't get a warning for it.
> 
> Looks like this one is still not in.  Any chance to send it to Linus
> in this merge cycle?

Oops. My bad. I must have dropped it by accident... I'll send it in.

Cheers
  Trond

> 
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > 
> > Index: linux-2.6/net/sunrpc/sched.c
> > ===================================================================
> > --- linux-2.6.orig/net/sunrpc/sched.c	2007-02-06 15:55:43.000000000 +0100
> > +++ linux-2.6/net/sunrpc/sched.c	2007-02-06 15:55:45.000000000 +0100
> > @@ -973,8 +973,6 @@
> >  	spin_unlock(&rpc_sched_lock);
> >  }
> >  
> > -static DECLARE_MUTEX_LOCKED(rpciod_running);
> > -
> >  static void rpciod_killall(void)
> >  {
> >  	unsigned long flags;
> ---end quoted text---
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by DB2 Express
> Download DB2 Express C - the FREE version of DB2 express and take
> control of your XML. No limits. Just data. Click to get it now.
> http://sourceforge.net/powerbar/db2/
> _______________________________________________
> NFS maillist  -  NFS@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs