From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] need a better name for existing "FIELD_SIZE" macro sound/.
Date: Mon, 12 Feb 2007 16:33:13 +0000 [thread overview]
Message-ID: <45D096C9.8070203@bfs.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0702120748030.23229@CPE00045a9c397f-CM001225dbafb6>
in my old kernel code is is only used inside the vx driver.
IMHO it can be replaced with VX_FIELD_SIZE
is is only used by functions in .h (eek) and one .c code.
re,
wh
Robert P. J. Day wrote:
> one of the outstanding tasks in the wiki is to use the
> "FIELD_SIZE()" macro (currently defined as FIELD_SIZEOF but that's
> being renamed in the patch) in include/linux/kernel.h to simplify some
> code in the tree. i had already submitted that patch without noticing
> that a few files under the sound/ directory already define a
> "FIELD_SIZE" macro which clashes:
>
> $ grep -rw FIELD_SIZE *
>
> andrew morton suggested that the easiest solution is to just rename
> the one under the sound/ directory, but i have no idea what that macro
> represents. anyone know what's going on there and can recommend a
> better (and less universally intrusive) name that doesn't steal prime
> macro naming real estate?
>
> once the name "FIELD_SIZE" is reclaimed from those sound files, i
> can resubmit the global patch. thanks.
>
> rday
>
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2007-02-12 16:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-12 12:54 [KJ] need a better name for existing "FIELD_SIZE" macro under Robert P. J. Day
2007-02-12 16:33 ` walter harms [this message]
2007-02-12 16:54 ` [KJ] need a better name for existing "FIELD_SIZE" macro sound/ Robert P. J. Day
2007-02-12 18:12 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D096C9.8070203@bfs.de \
--to=wharms@bfs.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.