From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] need a better name for existing "FIELD_SIZE" macro sound/.
Date: Mon, 12 Feb 2007 18:12:32 +0000 [thread overview]
Message-ID: <45D0AE10.6090705@bfs.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0702120748030.23229@CPE00045a9c397f-CM001225dbafb6>
Robert P. J. Day wrote:
> On Mon, 12 Feb 2007, walter harms wrote:
>
>> in my old kernel code is is only used inside the vx driver.
>> IMHO it can be replaced with VX_FIELD_SIZE
>>
>> is is only used by functions in .h (eek) and one .c code.
>
> that's not quite true in the latest "git pull":
>
> $ grep -rwl FIELD_SIZE sound
> sound/drivers/vx/vx_cmd.h
> sound/drivers/vx/vx_pcm.c
> sound/pci/pcxhr/pcxhr_core.h
> sound/pci/pcxhr/pcxhr_hwdep.c
> sound/pci/pcxhr/pcxhr_core.c
>
> i *could* submit a patch renaming that macro to VX_FIELD_SIZE and
> PCXHR_FIELD_SIZE respectively but, if you want to look at those files
> more closely, it *seems* that that field represents the same thing in
> each, and i'd hate to deliberately rename a macro to two different
> names for no good reason when they represent the same thing.
your are right picking a later kernel code reveals it.
I guess they are something like controlfield the comment in
pcxhr_hwdep.c /* test 8 or 2 phys in */
seem to point to that.
Just rename it, perhaps you can make emums ?
the simple fact to have 2 common named macros show that the want to be renamed.
The alsa-page seems to indicate the chips are related, perhaps some sound expert can comment on that ?
http://www.alsa-project.org/alsa-doc/index.php?vendor=vendor-Digigram#matrix
re,
wh
>
> is there a more descriptive name that might be used that describes
> what that field is *for*?
>
> rday
>
>
>
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2007-02-12 18:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-12 12:54 [KJ] need a better name for existing "FIELD_SIZE" macro under Robert P. J. Day
2007-02-12 16:33 ` [KJ] need a better name for existing "FIELD_SIZE" macro sound/ walter harms
2007-02-12 16:54 ` Robert P. J. Day
2007-02-12 18:12 ` walter harms [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D0AE10.6090705@bfs.de \
--to=wharms@bfs.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.