From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: alan@lxorguk.ukuu.org.uk, ric@emc.com, edmudama@gmail.com,
linux-ide@vger.kernel.org
Subject: Re: [PATCH 5/5] ahci: consider SDB FIS containing spurious NCQ completions HSM violation
Date: Tue, 20 Feb 2007 10:46:58 -0500 [thread overview]
Message-ID: <45DB17F2.5000707@garzik.org> (raw)
In-Reply-To: <11704009511903-git-send-email-htejun@gmail.com>
Tejun Heo wrote:
> SDB FIS containing spurious NCQ completions is a clear protocol
> violation. Currently, only some Maxtors with early firmware revisions
> are showing this problem. Those firmwares have other NCQ related
> problems including buggy NCQ error reporting and occasional lock up
> after NCQ errors.
>
> Consider spurious NCQ completions HSM violation and freeze the port
> after it. EH will turn off NCQ after this happens several times.
> Eventually drives which show this behavior should be blacklisted for
> NCQ.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> ---
> drivers/ata/ahci.c | 26 +++++++++++++-------------
> 1 files changed, 13 insertions(+), 13 deletions(-)
ACK, but patch does not apply to current #upstream
next prev parent reply other threads:[~2007-02-20 15:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-02 7:22 asdf Tejun Heo
2007-02-02 7:22 ` [PATCH 1/5] libata: improve ata_down_xfermask_limit() Tejun Heo
2007-02-20 15:46 ` Jeff Garzik
2007-02-02 7:22 ` [PATCH 2/5] libata: improve probe failure handling Tejun Heo
2007-02-02 7:22 ` [PATCH 3/5] libata: put some intelligence into EH speed down sequence Tejun Heo
2007-02-02 7:22 ` [PATCH 5/5] ahci: consider SDB FIS containing spurious NCQ completions HSM violation Tejun Heo
2007-02-20 15:46 ` Jeff Garzik [this message]
2007-02-21 7:34 ` [PATCH 5/5] ahci: consider SDB FIS containing spurious NCQ completions HSM violation (regenerated) Tejun Heo
2007-02-23 10:37 ` Jeff Garzik
2007-02-02 7:22 ` [PATCH 4/5] libata: kill ATA_DNXFER_ANY Tejun Heo
2007-02-02 7:24 ` Subject is [PATCH,RESEND] libata: put some intelligence into speed down sequence Tejun Heo
2007-02-02 16:59 ` asdf Ric Wheeler
2007-02-03 4:07 ` asdf Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2007-02-02 7:09 [PATCHSET] ata_piix: improve combined mode handling Tejun Heo
2007-02-02 7:09 ` [PATCH 5/5] ahci: consider SDB FIS containing spurious NCQ completions HSM violation Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45DB17F2.5000707@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=edmudama@gmail.com \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=ric@emc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.