__attribute__ annotations and struct types

__attribute__ annotations and struct types

[Daniel Drake]

gcc-4.1.1 accepts this as valid code:

struct __attribute__((__aligned__(16))) foo {
    int a;
};

sparse doesn't like it:

	test.c:7:8: error: Trying to use reserved word '__attribute__' 
	as identifier

I'm not sure if this is a bug that people are interested in solving, as
the more common form works in both gcc and sparse:

struct foo {
    int a;
} __attribute__((__aligned__(16)));

Thanks,
-- 
Daniel Drake
Brontes Technologies, A 3M Company

[PATCH] Re: __attribute__ annotations and struct types

[Christopher Li]

On Wed, Feb 14, 2007 at 03:01:54PM -0500, Daniel Drake wrote:
> sparse doesn't like it:
> 
> 	test.c:7:8: error: Trying to use reserved word '__attribute__' 
> 	as identifier

Can you please try this:

Chris

Handle structure attribute.

struct __attribute__((__aligned__(16))) foo {
    int a;
};

Signed-Off-By: Christopher Li <sparse@chrisli.org>

Index: sparse/parse.c
===================================================================
--- sparse.orig/parse.c	2007-02-14 12:37:17.000000000 -0800
+++ sparse/parse.c	2007-02-14 12:40:48.000000000 -0800
@@ -34,6 +34,7 @@ struct symbol_list *function_computed_ta
 struct statement_list *function_computed_goto_list;
 
 static struct token *statement(struct token *token, struct statement **tree);
+static struct token *handle_attributes(struct token *token, struct ctype *ctype);
 
 // Add a symbol to the list of function-local symbols
 static void fn_local_symbol(struct symbol *sym)
@@ -156,6 +157,7 @@ static struct token *struct_union_enum_s
 	struct position *repos;
 
 	ctype->modifiers = 0;
+	token = handle_attributes(token, ctype);
 	if (token_type(token) == TOKEN_IDENT) {
 		sym = lookup_symbol(token->ident, NS_STRUCT);
 		if (!sym ||

Re: [PATCH] Re: __attribute__ annotations and struct types

[Daniel Drake]

On Wed, 2007-02-14 at 12:15 -0800, Christopher Li wrote:
> On Wed, Feb 14, 2007 at 03:01:54PM -0500, Daniel Drake wrote:
> > sparse doesn't like it:
> > 
> > 	test.c:7:8: error: Trying to use reserved word '__attribute__' 
> > 	as identifier
> 
> Can you please try this:
> 
> Chris
> 
> Handle structure attribute.

Thanks for the quick response, works nicely!

-- 
Daniel Drake
Brontes Technologies, A 3M Company

Re: [PATCH] Re: __attribute__ annotations and struct types

[Randy Dunlap]

On Wed, 14 Feb 2007 16:02:07 -0500 Daniel Drake wrote:

> On Wed, 2007-02-14 at 12:15 -0800, Christopher Li wrote:
> > On Wed, Feb 14, 2007 at 03:01:54PM -0500, Daniel Drake wrote:
> > > sparse doesn't like it:
> > > 
> > > 	test.c:7:8: error: Trying to use reserved word '__attribute__' 
> > > 	as identifier
> > 
> > Can you please try this:
> > 
> > Chris
> > 
> > Handle structure attribute.
> 
> Thanks for the quick response, works nicely!

so now drivers/kvm/* should be less nasty  ;)

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: [PATCH] Re: __attribute__ annotations and struct types

[Josh Triplett]

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

Daniel Drake wrote:
> On Wed, 2007-02-14 at 12:15 -0800, Christopher Li wrote:
>> On Wed, Feb 14, 2007 at 03:01:54PM -0500, Daniel Drake wrote:
>>> sparse doesn't like it:
>>>
>>> 	test.c:7:8: error: Trying to use reserved word '__attribute__' 
>>> 	as identifier
>> Can you please try this:
>>
>> Chris
>>
>> Handle structure attribute.
> 
> Thanks for the quick response, works nicely!

Applied, along with a test case.

- Josh Triplett



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 252 bytes --]