From: "H. Peter Anvin" <hpa@zytor.com>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
trivial@kernel.org
Subject: Re: [PATCH] Remove redundant #ifdef __KERNEL__ checks.
Date: Mon, 26 Feb 2007 11:18:57 -0800 [thread overview]
Message-ID: <45E332A1.6080504@zytor.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0702260442160.15535@CPE00045a9c397f-CM001225dbafb6>
Robert P. J. Day wrote:
> On Sun, 25 Feb 2007, H. Peter Anvin wrote:
>
>> Robert P. J. Day wrote:
>>> Remove the redundant intermediate checks for __KERNEL__ since, as
>>> soon as one ends, the next one starts.
>>>
>>> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
>>>
>> However, what's much worse is that this already has put series of
>> constants which are part of the ABI under __KERNEL__. This is a
>> very bad thing.
>
> i'm sure i'm just being dense but i have no clue what you're referring
> to. AFAICT, that patch simply removed some redundant preprocessor
> directives. am i missing something?
>
I'm referring to the the patch that caused the redundant ifdefs, which
was a recent change which among other things broke klibc.
-hpa
next prev parent reply other threads:[~2007-02-26 19:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-25 20:11 [PATCH] Remove redundant #ifdef __KERNEL__ checks Robert P. J. Day
2007-02-26 7:55 ` H. Peter Anvin
2007-02-26 9:44 ` Robert P. J. Day
2007-02-26 19:18 ` H. Peter Anvin [this message]
2007-02-26 21:16 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E332A1.6080504@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.