[PATCH] Remove redundant #ifdef __KERNEL__ checks.

[PATCH] Remove redundant #ifdef __KERNEL__ checks.

[Robert P. J. Day]

  Remove the redundant intermediate checks for __KERNEL__ since, as
soon as one ends, the next one starts.

Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>

---

diff --git a/include/linux/stat.h b/include/linux/stat.h
index 4f8539c..a3d6342 100644
--- a/include/linux/stat.h
+++ b/include/linux/stat.h
@@ -5,10 +5,6 @@

 #include <asm/stat.h>

-#endif
-
-#ifdef __KERNEL__
-
 #define S_IFMT  00170000
 #define S_IFSOCK 0140000
 #define S_IFLNK	 0120000
@@ -44,9 +40,6 @@
 #define S_IWOTH 00002
 #define S_IXOTH 00001

-#endif
-
-#ifdef __KERNEL__
 #define S_IRWXUGO	(S_IRWXU|S_IRWXG|S_IRWXO)
 #define S_IALLUGO	(S_ISUID|S_ISGID|S_ISVTX|S_IRWXUGO)
 #define S_IRUGO		(S_IRUSR|S_IRGRP|S_IROTH)

-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

Re: [PATCH] Remove redundant #ifdef __KERNEL__ checks.

[H. Peter Anvin]

Robert P. J. Day wrote:
>   Remove the redundant intermediate checks for __KERNEL__ since, as
> soon as one ends, the next one starts.
> 
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> 

However, what's much worse is that this already has put series of 
constants which are part of the ABI under __KERNEL__.  This is a very 
bad thing.

	-hpa

Re: [PATCH] Remove redundant #ifdef __KERNEL__ checks.

[Robert P. J. Day]

On Sun, 25 Feb 2007, H. Peter Anvin wrote:

> Robert P. J. Day wrote:
> >   Remove the redundant intermediate checks for __KERNEL__ since, as
> > soon as one ends, the next one starts.
> >
> > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> >
>
> However, what's much worse is that this already has put series of
> constants which are part of the ABI under __KERNEL__.  This is a
> very bad thing.

i'm sure i'm just being dense but i have no clue what you're referring
to.  AFAICT, that patch simply removed some redundant preprocessor
directives.  am i missing something?

rday

-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

Re: [PATCH] Remove redundant #ifdef __KERNEL__ checks.

[H. Peter Anvin]

Robert P. J. Day wrote:
> On Sun, 25 Feb 2007, H. Peter Anvin wrote:
> 
>> Robert P. J. Day wrote:
>>>   Remove the redundant intermediate checks for __KERNEL__ since, as
>>> soon as one ends, the next one starts.
>>>
>>> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
>>>
>> However, what's much worse is that this already has put series of
>> constants which are part of the ABI under __KERNEL__.  This is a
>> very bad thing.
> 
> i'm sure i'm just being dense but i have no clue what you're referring
> to.  AFAICT, that patch simply removed some redundant preprocessor
> directives.  am i missing something?
> 

I'm referring to the the patch that caused the redundant ifdefs, which 
was a recent change which among other things broke klibc.

	-hpa

Re: [PATCH] Remove redundant #ifdef __KERNEL__ checks.

[Robert P. J. Day]

On Mon, 26 Feb 2007, H. Peter Anvin wrote:

> Robert P. J. Day wrote:
> > On Sun, 25 Feb 2007, H. Peter Anvin wrote:
> >
> > > Robert P. J. Day wrote:
> > > >   Remove the redundant intermediate checks for __KERNEL__ since, as
> > > > soon as one ends, the next one starts.
> > > >
> > > > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> > > >
> > > However, what's much worse is that this already has put series of
> > > constants which are part of the ABI under __KERNEL__.  This is a
> > > very bad thing.
> >
> > i'm sure i'm just being dense but i have no clue what you're
> > referring to.  AFAICT, that patch simply removed some redundant
> > preprocessor directives.  am i missing something?

> I'm referring to the the patch that caused the redundant ifdefs,
> which was a recent change which among other things broke klibc.

ah, i didn't realize that the redundant ifdef's themselves were a
symptom of another problem.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================