From: Jeff Garzik <jeff@garzik.org>
To: Roland Dreier <rdreier@cisco.com>
Cc: Stephen Hemminger <shemminger@linux-foundation.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH, RESEND] chelsio: Fix non-NAPI compile
Date: Tue, 27 Feb 2007 04:28:07 -0500 [thread overview]
Message-ID: <45E3F9A7.4000706@garzik.org> (raw)
In-Reply-To: <ada1wkczfti.fsf_-_@cisco.com>
Roland Dreier wrote:
> Chelsio without NAPI enabled has been broken (won't compile) since
> 3de00b89 ("chelsio: NAPI speed improvement"):
>
> drivers/net/chelsio/sge.c: In function `t1_interrupt`:
> drivers/net/chelsio/sge.c:1716: error: `Q` undeclared (first use in this function)
>
> The change below seems to add back in the declaration and
> initialization of `Q` that was removed by mistake, and at least makes
> the driver compile for me, although I have no hardware and hence no
> way to test whether this actually works.
>
> Signed-off-by: Roland Dreier <rolandd@cisco.com>
> ---
> Jeff, I haven't seen any response from Stephen but Divy from Chelsio
> seemed to agree with this patch, so can you please merge it? Right
> now the build is broken with CONFIG_CHELSIO_T1_NAPI=n.
applied
prev parent reply other threads:[~2007-02-27 9:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-20 23:57 [PATCH 0/3] chelsio 10G driver cleanups Stephen Hemminger
2007-02-20 23:58 ` [PATCH 1/3] chelsio: remove unused code for 1G boards Stephen Hemminger
2007-02-27 9:32 ` Jeff Garzik
2007-02-20 23:58 ` [PATCH 2/3] chelsio: use C99 style initialization Stephen Hemminger
2007-02-20 23:58 ` [PATCH 3/3] chelsio: use const for virtual functions Stephen Hemminger
2007-02-21 7:59 ` [PATCH] chelsio: Fix non-NAPI compile Roland Dreier
2007-02-21 8:05 ` Divy Le Ray
2007-02-26 22:58 ` [PATCH, RESEND] " Roland Dreier
2007-02-26 23:00 ` Stephen Hemminger
2007-02-27 9:28 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E3F9A7.4000706@garzik.org \
--to=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.