From: Roland Dreier <rdreier@cisco.com>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Jeff Garzik <jgarzik@pobox.com>, netdev@vger.kernel.org
Subject: [PATCH] chelsio: Fix non-NAPI compile
Date: Tue, 20 Feb 2007 23:59:28 -0800 [thread overview]
Message-ID: <adamz38c55r.fsf@cisco.com> (raw)
In-Reply-To: <20070220235759.102686172@linux-foundation.org> (Stephen Hemminger's message of "Tue, 20 Feb 2007 15:57:59 -0800")
Chelsio without NAPI enabled has been broken (won't compile) since
3de00b89 ("chelsio: NAPI speed improvement"):
drivers/net/chelsio/sge.c: In function `t1_interrupt`:
drivers/net/chelsio/sge.c:1716: error: `Q` undeclared (first use in this function)
The change below seems to add back in the declaration and
initialization of `Q` that was removed by mistake, and at least makes
the driver compile for me, although I have no hardware and hence no
way to test whether this actually works.
Signed-off-by: Roland Dreier <rolandd@cisco.com>
---
Hi Stephen, since you seem to be looking after this driver a little
bit (and since you broke it ;), I'll send this patch to you.
If this seems right to you, please merge it (although perhaps it would
make more sense just to kill the non-NAPI code, since no one noticed
it didn't compile).
diff --git a/drivers/net/chelsio/sge.c b/drivers/net/chelsio/sge.c
index 89a6827..326d4a6 100644
--- a/drivers/net/chelsio/sge.c
+++ b/drivers/net/chelsio/sge.c
@@ -1696,6 +1696,7 @@ irqreturn_t t1_interrupt(int irq, void *cookie)
{
int work_done;
struct adapter *adapter = cookie;
+ struct respQ *Q = &adapter->sge->respQ;
spin_lock(&adapter->async_lock);
next prev parent reply other threads:[~2007-02-21 7:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-20 23:57 [PATCH 0/3] chelsio 10G driver cleanups Stephen Hemminger
2007-02-20 23:58 ` [PATCH 1/3] chelsio: remove unused code for 1G boards Stephen Hemminger
2007-02-27 9:32 ` Jeff Garzik
2007-02-20 23:58 ` [PATCH 2/3] chelsio: use C99 style initialization Stephen Hemminger
2007-02-20 23:58 ` [PATCH 3/3] chelsio: use const for virtual functions Stephen Hemminger
2007-02-21 7:59 ` Roland Dreier [this message]
2007-02-21 8:05 ` [PATCH] chelsio: Fix non-NAPI compile Divy Le Ray
2007-02-26 22:58 ` [PATCH, RESEND] " Roland Dreier
2007-02-26 23:00 ` Stephen Hemminger
2007-02-27 9:28 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adamz38c55r.fsf@cisco.com \
--to=rdreier@cisco.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.