[Xenomai-help] Compile-time error with xenomai x86_64 port (probably dualcore related)

[Xenomai-help] Compile-time error with xenomai x86_64 port (probably dualcore related)

[Matthias Scheer]

[-- Attachment #1: Type: text/plain, Size: 1023 bytes --]

Dear developers,

I'm trying to compile the latest /trunk version together with the adeos
x86_64 patch v1.00.04. The kernel version is 2.6.19.5. The compiling is
done on an Athlon 64 X2 and stops with these error messages:

  CC      kernel/xenomai/nucleus/pod.o
kernel/xenomai/nucleus/pod.c:944:48: error: macro "cpus_equal" passed 3
arguments, but takes just 2
kernel/xenomai/nucleus/pod.c: In function ‘xnpod_start_thread’:
kernel/xenomai/nucleus/pod.c:944: error: ‘cpus_equal’ undeclared (first
use in this function)
kernel/xenomai/nucleus/pod.c:944: error: (Each undeclared identifier is
reported only once
kernel/xenomai/nucleus/pod.c:944: error: for each function it appears in.)

Notice the _macro "cpus_equal"_ error, which eventually uses the
identifier CPU_MASK_ALL which contains more than one element on a
dualcore system. Does this explanation make sense? And is there a easy
way to fix it? (maybe with a variable number of arguments)

Thanks for your time,
Matthias Scheer



[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 6092 bytes --]

Re: [Xenomai-help] Compile-time error with xenomai x86_64 port (probably dualcore related)

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 1481 bytes --]

Matthias Scheer wrote:
> Dear developers,
> 
> I'm trying to compile the latest /trunk version together with the adeos
> x86_64 patch v1.00.04. The kernel version is 2.6.19.5. The compiling is
> done on an Athlon 64 X2 and stops with these error messages:
> 
>   CC      kernel/xenomai/nucleus/pod.o
> kernel/xenomai/nucleus/pod.c:944:48: error: macro "cpus_equal" passed 3
> arguments, but takes just 2
> kernel/xenomai/nucleus/pod.c: In function ‘xnpod_start_thread’:
> kernel/xenomai/nucleus/pod.c:944: error: ‘cpus_equal’ undeclared (first
> use in this function)
> kernel/xenomai/nucleus/pod.c:944: error: (Each undeclared identifier is
> reported only once
> kernel/xenomai/nucleus/pod.c:944: error: for each function it appears in.)
> 
> Notice the _macro "cpus_equal"_ error, which eventually uses the
> identifier CPU_MASK_ALL which contains more than one element on a
> dualcore system. Does this explanation make sense? And is there a easy
> way to fix it? (maybe with a variable number of arguments)
> 

Does this help?

--- include/asm-generic/system.h        (Revision 2262)
+++ include/asm-generic/system.h        (Arbeitskopie)
@@ -32,6 +32,7 @@
 #include <linux/errno.h>
 #include <linux/vmalloc.h>
 #include <linux/mm.h>
+#include <linux/cpumask.h>
 #include <asm/uaccess.h>
 #include <asm/param.h>
 #include <asm/mmu_context.h>

[At least it is cleaner than relying on cpumask.h being implicitly
included.]

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]

Re: [Xenomai-help] Compile-time error with xenomai x86_64 port (probably dualcore related)

[Matthias Scheer]

[-- Attachment #1: Type: text/plain, Size: 807 bytes --]

Hi, thanx for the reply,

I'm sorry but including linux/cpumask.h doesn't fix the problem. The
error stays the same. Any more tips?

Matthias Scheer

>> I'm trying to compile the latest /trunk version together with the adeos
>> x86_64 patch v1.00.04. The kernel version is 2.6.19.5. The compiling is
>> done on an Athlon 64 X2 and stops with these error messages:
> 
> Does this help?
> 
> --- include/asm-generic/system.h        (Revision 2262)
> +++ include/asm-generic/system.h        (Arbeitskopie)
> @@ -32,6 +32,7 @@
>  #include <linux/errno.h>
>  #include <linux/vmalloc.h>
>  #include <linux/mm.h>
> +#include <linux/cpumask.h>
>  #include <asm/uaccess.h>
>  #include <asm/param.h>
>  #include <asm/mmu_context.h>
> 
> [At least it is cleaner than relying on cpumask.h being implicitly
> included.]

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 6092 bytes --]

Re: [Xenomai-help] Compile-time error with xenomai x86_64 port (probably dualcore related)

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

Matthias Scheer wrote:
> Hi, thanx for the reply,
> 
> I'm sorry but including linux/cpumask.h doesn't fix the problem. The
> error stays the same. Any more tips?

Please post your .config then.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 250 bytes --]

Re: [Xenomai-help] Compile-time error with xenomai x86_64 port (probably dualcore related)

[Matthias Scheer]

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

Jan Kiszka wrote:
>>> I'm sorry but including linux/cpumask.h doesn't fix the problem. The
>> error stays the same. Any more tips?
> 
> Please post your .config then.

Using a clean defconfig together with your patch fixed it.

Thanx again.

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 6092 bytes --]

Re: [Xenomai-help] Compile-time error with xenomai x86_64 port (probably dualcore related)

[Philippe Gerum]

On Wed, 2007-02-28 at 14:55 +0100, Matthias Scheer wrote:
> Jan Kiszka wrote:
> >>> I'm sorry but including linux/cpumask.h doesn't fix the problem. The
> >> error stays the same. Any more tips?
> > 
> > Please post your .config then.
> 
> Using a clean defconfig together with your patch fixed it.
> 

Does the bug trigger again if you remove the patch while retaining your
defconfig?

> Thanx again.
> _______________________________________________
> Xenomai-help mailing list
> Xenomai-help@domain.hid
> https://mail.gna.org/listinfo/xenomai-help
-- 
Philippe.

Re: [Xenomai-help] Compile-time error with xenomai x86_64 port (probably dualcore related)

[Matthias Scheer]

[-- Attachment #1: Type: text/plain, Size: 394 bytes --]

Philippe Gerum wrote:
>> Using a clean defconfig together with your patch fixed it.
> 
> Does the bug trigger again if you remove the patch while retaining your
> defconfig?

It seems the patch wasn't causing any different behaviour, as the bug
doesn't reappear. I'm going to enable options step by step to see which
one triggered the bug in the first place.

I'll let you guys know.

Matthias

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 6092 bytes --]

Re: [Xenomai-help] Compile-time error with xenomai x86_64 port (probably dualcore related)

[Matthias Scheer]

[-- Attachment #1: Type: text/plain, Size: 356 bytes --]

Matthias Scheer wrote:
> It seems the patch wasn't causing any different behaviour, as the bug
> doesn't reappear. I'm going to enable options step by step to see which
> one triggered the bug in the first place.
> 
> I'll let you guys know.

CONFIG_NR_CPUS was set too high (128). After reducing the number to 32,
compilation of pod.o succeeds.

Matthias

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/x-pkcs7-signature, Size: 6092 bytes --]