From: Avi Kivity <avi@qumranet.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Add -name option
Date: Sun, 04 Mar 2007 11:30:37 +0200 [thread overview]
Message-ID: <45EA91BD.8030405@qumranet.com> (raw)
In-Reply-To: <45EA38D2.7050903@codemonkey.ws>
Anthony Liguori wrote:
> This option helps differentiate between guests when running more than
> one instance of QEMU. It adds a string to the SDL window title and to
> the VNC server title.
>
> Having a name associated with a guest is also terribly useful for
> management tools as it gives a standard way to identify guests to the
> user.
>
>
> - vnc_write_u32(vs, 4);
> - vnc_write(vs, "QEMU", 4);
> + if (qemu_name)
> + size = snprintf(buf, sizeof(buf), "QEMU (%s)", qemu_name);
> + else
> + size = snprintf(buf, sizeof(buf), "QEMU");
> +
Perhaps in the modern style:
snprintf("%s - QEMU", sizeof, qemu_name)
?
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
next prev parent reply other threads:[~2007-03-04 9:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-04 3:11 [Qemu-devel] [PATCH] Add -name option Anthony Liguori
2007-03-04 9:30 ` Avi Kivity [this message]
2007-03-04 17:11 ` Anthony Liguori
2007-03-04 17:23 ` Avi Kivity
2007-03-04 20:00 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45EA91BD.8030405@qumranet.com \
--to=avi@qumranet.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.