All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre Ossman <ossman@cendio.se>
To: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>
Subject: [PATCH] Improve parameter constraints in alsa-pulse
Date: Mon, 05 Mar 2007 14:33:18 +0100	[thread overview]
Message-ID: <45EC1C1E.101@cendio.se> (raw)


[-- Attachment #1.1.1: Type: text/plain, Size: 238 bytes --]

Remove parameter constraints where we actually have none. Also, restrict
total buffer size to 4 MB as current versions of the PulseAudio server
will refuse streams larger than that.

Signed-off-by: Pierre Ossman <ossman@cendio.se>


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.1.2: params.patch --]
[-- Type: text/x-patch; name="params.patch", Size: 878 bytes --]

diff -r ea810fbf4cd0 pulse/pcm_pulse.c
--- a/pulse/pcm_pulse.c	Mon Feb 26 10:21:21 2007 +0100
+++ b/pulse/pcm_pulse.c	Fri Mar 02 16:41:07 2007 +0100
@@ -643,23 +643,8 @@ static int pulse_hw_constraint(snd_pcm_p
     if (err < 0)
         return err;
 
-    err = snd_pcm_ioplug_set_param_minmax(io, SND_PCM_IOPLUG_HW_RATE,
-        8000, 48000);
-    if (err < 0)
-        return err;
-
-    err = snd_pcm_ioplug_set_param_minmax(io, SND_PCM_IOPLUG_HW_PERIOD_BYTES,
-        1, 4294967295U);
-    if (err < 0)
-        return err;
-
-    err = snd_pcm_ioplug_set_param_minmax(io, SND_PCM_IOPLUG_HW_PERIODS,
-        2, 4294967295U);
-    if (err < 0)
-        return err;
-
     err = snd_pcm_ioplug_set_param_minmax(io, SND_PCM_IOPLUG_HW_BUFFER_BYTES,
-        1, 4294967295U);
+        1, 4 * 1024 * 1024);
     if (err < 0)
         return err;
 

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 251 bytes --]

[-- Attachment #2: Type: text/plain, Size: 345 bytes --]

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

[-- Attachment #3: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

             reply	other threads:[~2007-03-05 13:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-05 13:33 Pierre Ossman [this message]
2007-03-07 21:22 ` [PATCH] Improve parameter constraints in alsa-pulse Takashi Iwai
2007-03-08 13:54   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45EC1C1E.101@cendio.se \
    --to=ossman@cendio.se \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.