[PATCH] Improve parameter constraints in alsa-pulse

[PATCH] Improve parameter constraints in alsa-pulse

[Pierre Ossman]

[-- Attachment #1.1.1: Type: text/plain, Size: 238 bytes --]

Remove parameter constraints where we actually have none. Also, restrict
total buffer size to 4 MB as current versions of the PulseAudio server
will refuse streams larger than that.

Signed-off-by: Pierre Ossman <ossman@cendio.se>


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.1.2: params.patch --]
[-- Type: text/x-patch; name="params.patch", Size: 878 bytes --]

diff -r ea810fbf4cd0 pulse/pcm_pulse.c
--- a/pulse/pcm_pulse.c	Mon Feb 26 10:21:21 2007 +0100
+++ b/pulse/pcm_pulse.c	Fri Mar 02 16:41:07 2007 +0100
@@ -643,23 +643,8 @@ static int pulse_hw_constraint(snd_pcm_p
     if (err < 0)
         return err;
 
-    err = snd_pcm_ioplug_set_param_minmax(io, SND_PCM_IOPLUG_HW_RATE,
-        8000, 48000);
-    if (err < 0)
-        return err;
-
-    err = snd_pcm_ioplug_set_param_minmax(io, SND_PCM_IOPLUG_HW_PERIOD_BYTES,
-        1, 4294967295U);
-    if (err < 0)
-        return err;
-
-    err = snd_pcm_ioplug_set_param_minmax(io, SND_PCM_IOPLUG_HW_PERIODS,
-        2, 4294967295U);
-    if (err < 0)
-        return err;
-
     err = snd_pcm_ioplug_set_param_minmax(io, SND_PCM_IOPLUG_HW_BUFFER_BYTES,
-        1, 4294967295U);
+        1, 4 * 1024 * 1024);
     if (err < 0)
         return err;
 

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 251 bytes --]

[-- Attachment #2: Type: text/plain, Size: 345 bytes --]

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

[-- Attachment #3: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Re: [PATCH] Improve parameter constraints in alsa-pulse

[Takashi Iwai]

At Mon, 05 Mar 2007 14:33:18 +0100,
Pierre Ossman wrote:
> 
> Remove parameter constraints where we actually have none. Also, restrict
> total buffer size to 4 MB as current versions of the PulseAudio server
> will refuse streams larger than that.
> 
> Signed-off-by: Pierre Ossman <ossman@cendio.se>

Thanks.  The patch is on my local tree and I'll push it as soon as the
HG server is recovered.


Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Re: [PATCH] Improve parameter constraints in alsa-pulse

[Takashi Iwai]

At Wed, 07 Mar 2007 22:22:32 +0100,
I wrote:
> 
> At Mon, 05 Mar 2007 14:33:18 +0100,
> Pierre Ossman wrote:
> > 
> > Remove parameter constraints where we actually have none. Also, restrict
> > total buffer size to 4 MB as current versions of the PulseAudio server
> > will refuse streams larger than that.
> > 
> > Signed-off-by: Pierre Ossman <ossman@cendio.se>
> 
> Thanks.  The patch is on my local tree and I'll push it as soon as the
> HG server is recovered.

Now it's on ALSA HG tree.


Takashi

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV