[Bluez-devel] sdp_uuid32_to_uuid128, lack of declaration

[Bluez-devel] sdp_uuid32_to_uuid128, lack of declaration

[milosz danielewski]

Why there are no sdp_uuid32_to_uuid128 declaration in sdp_lib.h
(bluez-libs-devel 3.7.1)? It would be useful, but in such situation I
cannot use it...

regards
milosz danielewski

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] sdp_uuid32_to_uuid128, lack of declaration

[Marcel Holtmann]

Hi Milosz,

> Why there are no sdp_uuid32_to_uuid128 declaration in sdp_lib.h
> (bluez-libs-devel 3.7.1)? It would be useful, but in such situation I
> cannot use it...

I think that is simply because nobody needed them before. Feel free to
implement them and send a patch. However UUID32 is the most unused UUID
type. In general you should either use UUID16 for well known profile and
service identifiers or UUID128 for your own identifiers.

Regards

Marcel



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] sdp_uuid32_to_uuid128, lack of declaration

[Albert Huang]

How about these?

uuid_t *sdp_uuid32_create(uuid_t *uuid, uint32_t data);
uuid_t *sdp_uuid_to_uuid128(uuid_t *uuid);


On 3/4/07, milosz danielewski <master@apnet.pl> wrote:
> Why there are no sdp_uuid32_to_uuid128 declaration in sdp_lib.h
> (bluez-libs-devel 3.7.1)? It would be useful, but in such situation I
> cannot use it...
>
> regards
> milosz danielewski
>
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys-and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> Bluez-devel mailing list
> Bluez-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/bluez-devel
>

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] sdp_uuid32_to_uuid128, lack of declaration

[milosz danielewski]

Marcel Holtmann <marcel <at> holtmann.org> writes:

> 
> Hi Milosz,
> 
> > Why there are no sdp_uuid32_to_uuid128 declaration in sdp_lib.h
> > (bluez-libs-devel 3.7.1)? It would be useful, but in such situation I
> > cannot use it...
> 
> I think that is simply because nobody needed them before. Feel free to
> implement them and send a patch.

 As far, as I can see it's already implemented, just not exposed in header file.

> However UUID32 is the most unused UUID
> type. In general you should either use UUID16 for well known profile and
> service identifiers or UUID128 for your own identifiers.

 I've started to implement jsr82. When I create java object representing UUID
it's most convenient to pass 16 byte array from native C to Java. So, when I
iterate over service attributes, have to properly convert SDP_UUID32 to uuid128.
That's why I need to use sdp_uuid32_to_uuid128 (which is already implemented and
working). Only problem is ugly warning "implicit declaration".

milosz danielewski


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] sdp_uuid32_to_uuid128, lack of declaration

[milosz danielewski]

Marcel Holtmann wrote:
>>  As far, as I can see it's already implemented, just not exposed in header file.
> then send a patch to fix this. Sounds like a really simple bug.

 As I am newbie here, what's the policy of sending patches? Should I
send it to bluez-devel list, or directly to you or whatever?

milosz danielewski

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] sdp_uuid32_to_uuid128, lack of declaration

[Marcel Holtmann]

Hi Milosz,

> > > Why there are no sdp_uuid32_to_uuid128 declaration in sdp_lib.h
> > > (bluez-libs-devel 3.7.1)? It would be useful, but in such situation I
> > > cannot use it...
> > 
> > I think that is simply because nobody needed them before. Feel free to
> > implement them and send a patch.
> 
>  As far, as I can see it's already implemented, just not exposed in header file.
> 
> > However UUID32 is the most unused UUID
> > type. In general you should either use UUID16 for well known profile and
> > service identifiers or UUID128 for your own identifiers.
> 
>  I've started to implement jsr82. When I create java object representing UUID
> it's most convenient to pass 16 byte array from native C to Java. So, when I
> iterate over service attributes, have to properly convert SDP_UUID32 to uuid128.
> That's why I need to use sdp_uuid32_to_uuid128 (which is already implemented and
> working). Only problem is ugly warning "implicit declaration".

then send a patch to fix this. Sounds like a really simple bug.

Regards

Marcel



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] sdp_uuid32_to_uuid128, lack of declaration

[milosz danielewski]

[-- Attachment #1: Type: text/plain, Size: 336 bytes --]

Marcel Holtmann wrote:
> Hi Milosz,
> 
>>  As I am newbie here, what's the policy of sending patches? Should I
>> send it to bluez-devel list, or directly to you or whatever?
> 
> create a unified diff with your changes against the latest CVS code and
> send it to the BlueZ developer mailing list.

here it goes...

milosz danielewski

[-- Attachment #2: sdp_lib.h.patch --]
[-- Type: text/x-patch, Size: 665 bytes --]

Index: sdp_lib.h
===================================================================
RCS file: /cvsroot/bluez/libs/include/sdp_lib.h,v
retrieving revision 1.29
diff -u -r1.29 sdp_lib.h
--- sdp_lib.h	13 Jan 2007 17:50:06 -0000	1.29
+++ sdp_lib.h	5 Mar 2007 20:10:25 -0000
@@ -475,6 +475,7 @@
 int sdp_uuid128_cmp(const void *p1, const void *p2);
 uuid_t *sdp_uuid_to_uuid128(uuid_t *uuid);
 void sdp_uuid16_to_uuid128(uuid_t *uuid128, uuid_t *uuid16);
+void sdp_uuid32_to_uuid128(uuid_t *uuid128, uuid_t *uuid32);
 int sdp_uuid128_to_uuid(uuid_t *uuid);
 int sdp_uuid_to_proto(uuid_t *uuid);
 int sdp_uuid_extract(const uint8_t *buffer, uuid_t *uuid, int *scanned);

[-- Attachment #3: Type: text/plain, Size: 345 bytes --]

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

[-- Attachment #4: Type: text/plain, Size: 164 bytes --]

_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] sdp_uuid32_to_uuid128, lack of declaration

[Marcel Holtmann]

Hi Milosz,

> >>  As far, as I can see it's already implemented, just not exposed in header file.
> > then send a patch to fix this. Sounds like a really simple bug.
> 
>  As I am newbie here, what's the policy of sending patches? Should I
> send it to bluez-devel list, or directly to you or whatever?

create a unified diff with your changes against the latest CVS code and
send it to the BlueZ developer mailing list.

Regards

Marcel



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel

Re: [Bluez-devel] sdp_uuid32_to_uuid128, lack of declaration

[Marcel Holtmann]

Hi Milosz,

> >>  As I am newbie here, what's the policy of sending patches? Should I
> >> send it to bluez-devel list, or directly to you or whatever?
> > 
> > create a unified diff with your changes against the latest CVS code and
> > send it to the BlueZ developer mailing list.
> 
> here it goes...

looks good to me. Patch has been applied and committed. Thanks.

Regards

Marcel



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Bluez-devel mailing list
Bluez-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/bluez-devel