* [PATCH 1/1] - platform_kernel_launch_event is noop on generic kernel
@ 2007-02-28 19:45 ` John Keller
0 siblings, 0 replies; 10+ messages in thread
From: John Keller @ 2007-02-28 19:45 UTC (permalink / raw)
To: fastboot; +Cc: jlan, linux-ia64, linux-kernel, John Keller
Add a missing #define for the platform_kernel_launch_event.
Without this fix, a call to platform_kernel_launch_event()
becomes a noop on generic kernels. SN systems require this
fix to successfully kdump/kexec from certain hardware errors.
Signed-off-by: John Keller <jpk@sgi.com>
---
Index: linux-2.6/include/asm-ia64/machvec.h
=================================--- linux-2.6.orig/include/asm-ia64/machvec.h 2007-02-28 08:39:45.764537727 -0600
+++ linux-2.6/include/asm-ia64/machvec.h 2007-02-28 08:40:01.254467899 -0600
@@ -168,6 +168,7 @@ extern void machvec_tlb_migrate_finish (
# define platform_setup_msi_irq ia64_mv.setup_msi_irq
# define platform_teardown_msi_irq ia64_mv.teardown_msi_irq
# define platform_pci_fixup_bus ia64_mv.pci_fixup_bus
+# define platform_kernel_launch_event ia64_mv.kernel_launch_event
# endif
/* __attribute__((__aligned__(16))) is required to make size of the
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/1] - platform_kernel_launch_event is noop on generic kernel
@ 2007-02-28 19:45 ` John Keller
0 siblings, 0 replies; 10+ messages in thread
From: John Keller @ 2007-02-28 19:45 UTC (permalink / raw)
To: fastboot; +Cc: jlan, linux-ia64, linux-kernel, John Keller
Add a missing #define for the platform_kernel_launch_event.
Without this fix, a call to platform_kernel_launch_event()
becomes a noop on generic kernels. SN systems require this
fix to successfully kdump/kexec from certain hardware errors.
Signed-off-by: John Keller <jpk@sgi.com>
---
Index: linux-2.6/include/asm-ia64/machvec.h
===================================================================
--- linux-2.6.orig/include/asm-ia64/machvec.h 2007-02-28 08:39:45.764537727 -0600
+++ linux-2.6/include/asm-ia64/machvec.h 2007-02-28 08:40:01.254467899 -0600
@@ -168,6 +168,7 @@ extern void machvec_tlb_migrate_finish (
# define platform_setup_msi_irq ia64_mv.setup_msi_irq
# define platform_teardown_msi_irq ia64_mv.teardown_msi_irq
# define platform_pci_fixup_bus ia64_mv.pci_fixup_bus
+# define platform_kernel_launch_event ia64_mv.kernel_launch_event
# endif
/* __attribute__((__aligned__(16))) is required to make size of the
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Fastboot] [PATCH 1/1] - platform_kernel_launch_event is noop on generic kernel
2007-02-28 19:45 ` John Keller
@ 2007-03-01 4:22 ` Horms
-1 siblings, 0 replies; 10+ messages in thread
From: Horms @ 2007-03-01 4:22 UTC (permalink / raw)
To: John Keller; +Cc: fastboot, linux-ia64, linux-kernel
On Wed, Feb 28, 2007 at 01:45:17PM -0600, John Keller wrote:
> Add a missing #define for the platform_kernel_launch_event.
> Without this fix, a call to platform_kernel_launch_event()
> becomes a noop on generic kernels. SN systems require this
> fix to successfully kdump/kexec from certain hardware errors.
>
> Signed-off-by: John Keller <jpk@sgi.com>
I made a similar change when porting to xen, but I hadn't thought
to see if mainline linux needs it to.
Acked-by: Simon Horman <horms@verge.net.au>
--
Horms
H: http://www.vergenet.net/~horms/
W: http://www.valinux.co.jp/en/
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Fastboot] [PATCH 1/1] - platform_kernel_launch_event is noop on generic kernel
@ 2007-03-01 4:22 ` Horms
0 siblings, 0 replies; 10+ messages in thread
From: Horms @ 2007-03-01 4:22 UTC (permalink / raw)
To: John Keller; +Cc: fastboot, linux-ia64, linux-kernel
On Wed, Feb 28, 2007 at 01:45:17PM -0600, John Keller wrote:
> Add a missing #define for the platform_kernel_launch_event.
> Without this fix, a call to platform_kernel_launch_event()
> becomes a noop on generic kernels. SN systems require this
> fix to successfully kdump/kexec from certain hardware errors.
>
> Signed-off-by: John Keller <jpk@sgi.com>
I made a similar change when porting to xen, but I hadn't thought
to see if mainline linux needs it to.
Acked-by: Simon Horman <horms@verge.net.au>
--
Horms
H: http://www.vergenet.net/~horms/
W: http://www.valinux.co.jp/en/
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Fastboot] [PATCH 1/1] - platform_kernel_launch_event is noop on generic kernel
2007-03-01 4:22 ` Horms
@ 2007-03-01 12:57 ` Bernhard Walle
-1 siblings, 0 replies; 10+ messages in thread
From: Bernhard Walle @ 2007-03-01 12:57 UTC (permalink / raw)
To: linux-ia64, linux-kernel
* Horms <horms@verge.net.au> [2007-03-01 05:22]:
> On Wed, Feb 28, 2007 at 01:45:17PM -0600, John Keller wrote:
> > Add a missing #define for the platform_kernel_launch_event.
> > Without this fix, a call to platform_kernel_launch_event()
> > becomes a noop on generic kernels. SN systems require this
> > fix to successfully kdump/kexec from certain hardware errors.
> >
> > Signed-off-by: John Keller <jpk@sgi.com>
>
> I made a similar change when porting to xen, but I hadn't thought
> to see if mainline linux needs it to.
>
> Acked-by: Simon Horman <horms@verge.net.au>
I think there's an additional change needed. Without that, it leads to
a NULL pointer dereference.
---
include/asm-ia64/machvec.h | 2 ++
1 file changed, 2 insertions(+)
Index: b/include/asm-ia64/machvec.h
=================================--- a/include/asm-ia64/machvec.h
+++ b/include/asm-ia64/machvec.h
@@ -168,6 +168,7 @@ extern void machvec_tlb_migrate_finish (
# define platform_setup_msi_irq ia64_mv.setup_msi_irq
# define platform_teardown_msi_irq ia64_mv.teardown_msi_irq
# define platform_pci_fixup_bus ia64_mv.pci_fixup_bus
+# define platform_kernel_launch_event ia64_mv.kernel_launch_event
# endif
/* __attribute__((__aligned__(16))) is required to make size of the
@@ -269,6 +270,7 @@ struct ia64_machine_vector {
platform_setup_msi_irq, \
platform_teardown_msi_irq, \
platform_pci_fixup_bus, \
+ platform_kernel_launch_event \
}
extern struct ia64_machine_vector ia64_mv;
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Fastboot] [PATCH 1/1] - platform_kernel_launch_event is noop on generic kernel
@ 2007-03-01 12:57 ` Bernhard Walle
0 siblings, 0 replies; 10+ messages in thread
From: Bernhard Walle @ 2007-03-01 12:57 UTC (permalink / raw)
To: linux-ia64, linux-kernel
* Horms <horms@verge.net.au> [2007-03-01 05:22]:
> On Wed, Feb 28, 2007 at 01:45:17PM -0600, John Keller wrote:
> > Add a missing #define for the platform_kernel_launch_event.
> > Without this fix, a call to platform_kernel_launch_event()
> > becomes a noop on generic kernels. SN systems require this
> > fix to successfully kdump/kexec from certain hardware errors.
> >
> > Signed-off-by: John Keller <jpk@sgi.com>
>
> I made a similar change when porting to xen, but I hadn't thought
> to see if mainline linux needs it to.
>
> Acked-by: Simon Horman <horms@verge.net.au>
I think there's an additional change needed. Without that, it leads to
a NULL pointer dereference.
---
include/asm-ia64/machvec.h | 2 ++
1 file changed, 2 insertions(+)
Index: b/include/asm-ia64/machvec.h
===================================================================
--- a/include/asm-ia64/machvec.h
+++ b/include/asm-ia64/machvec.h
@@ -168,6 +168,7 @@ extern void machvec_tlb_migrate_finish (
# define platform_setup_msi_irq ia64_mv.setup_msi_irq
# define platform_teardown_msi_irq ia64_mv.teardown_msi_irq
# define platform_pci_fixup_bus ia64_mv.pci_fixup_bus
+# define platform_kernel_launch_event ia64_mv.kernel_launch_event
# endif
/* __attribute__((__aligned__(16))) is required to make size of the
@@ -269,6 +270,7 @@ struct ia64_machine_vector {
platform_setup_msi_irq, \
platform_teardown_msi_irq, \
platform_pci_fixup_bus, \
+ platform_kernel_launch_event \
}
extern struct ia64_machine_vector ia64_mv;
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Fastboot] [PATCH 1/1] - platform_kernel_launch_event is noop on generic kernel
2007-03-01 12:57 ` Bernhard Walle
@ 2007-03-01 13:03 ` Bernhard Walle
-1 siblings, 0 replies; 10+ messages in thread
From: Bernhard Walle @ 2007-03-01 13:03 UTC (permalink / raw)
To: linux-ia64, linux-kernel
* Bernhard Walle <bwalle@suse.de> [2007-03-01 13:57]:
> * Horms <horms@verge.net.au> [2007-03-01 05:22]:
> > On Wed, Feb 28, 2007 at 01:45:17PM -0600, John Keller wrote:
> > > Add a missing #define for the platform_kernel_launch_event.
> > > Without this fix, a call to platform_kernel_launch_event()
> > > becomes a noop on generic kernels. SN systems require this
> > > fix to successfully kdump/kexec from certain hardware errors.
> > >
> > > Signed-off-by: John Keller <jpk@sgi.com>
> >
> > I made a similar change when porting to xen, but I hadn't thought
> > to see if mainline linux needs it to.
> >
> > Acked-by: Simon Horman <horms@verge.net.au>
>
> I think there's an additional change needed. Without that, it leads to
> a NULL pointer dereference.
Maybe I should also get my editor right ... ;):
---
include/asm-ia64/machvec.h | 2 ++
1 file changed, 2 insertions(+)
Index: b/include/asm-ia64/machvec.h
=================================--- a/include/asm-ia64/machvec.h
+++ b/include/asm-ia64/machvec.h
@@ -168,6 +168,7 @@ extern void machvec_tlb_migrate_finish (
# define platform_setup_msi_irq ia64_mv.setup_msi_irq
# define platform_teardown_msi_irq ia64_mv.teardown_msi_irq
# define platform_pci_fixup_bus ia64_mv.pci_fixup_bus
+# define platform_kernel_launch_event ia64_mv.kernel_launch_event
# endif
/* __attribute__((__aligned__(16))) is required to make size of the
@@ -269,6 +270,7 @@ struct ia64_machine_vector {
platform_setup_msi_irq, \
platform_teardown_msi_irq, \
platform_pci_fixup_bus, \
+ platform_kernel_launch_event \
}
extern struct ia64_machine_vector ia64_mv;
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Fastboot] [PATCH 1/1] - platform_kernel_launch_event is noop on generic kernel
@ 2007-03-01 13:03 ` Bernhard Walle
0 siblings, 0 replies; 10+ messages in thread
From: Bernhard Walle @ 2007-03-01 13:03 UTC (permalink / raw)
To: linux-ia64, linux-kernel
* Bernhard Walle <bwalle@suse.de> [2007-03-01 13:57]:
> * Horms <horms@verge.net.au> [2007-03-01 05:22]:
> > On Wed, Feb 28, 2007 at 01:45:17PM -0600, John Keller wrote:
> > > Add a missing #define for the platform_kernel_launch_event.
> > > Without this fix, a call to platform_kernel_launch_event()
> > > becomes a noop on generic kernels. SN systems require this
> > > fix to successfully kdump/kexec from certain hardware errors.
> > >
> > > Signed-off-by: John Keller <jpk@sgi.com>
> >
> > I made a similar change when porting to xen, but I hadn't thought
> > to see if mainline linux needs it to.
> >
> > Acked-by: Simon Horman <horms@verge.net.au>
>
> I think there's an additional change needed. Without that, it leads to
> a NULL pointer dereference.
Maybe I should also get my editor right ... ;):
---
include/asm-ia64/machvec.h | 2 ++
1 file changed, 2 insertions(+)
Index: b/include/asm-ia64/machvec.h
===================================================================
--- a/include/asm-ia64/machvec.h
+++ b/include/asm-ia64/machvec.h
@@ -168,6 +168,7 @@ extern void machvec_tlb_migrate_finish (
# define platform_setup_msi_irq ia64_mv.setup_msi_irq
# define platform_teardown_msi_irq ia64_mv.teardown_msi_irq
# define platform_pci_fixup_bus ia64_mv.pci_fixup_bus
+# define platform_kernel_launch_event ia64_mv.kernel_launch_event
# endif
/* __attribute__((__aligned__(16))) is required to make size of the
@@ -269,6 +270,7 @@ struct ia64_machine_vector {
platform_setup_msi_irq, \
platform_teardown_msi_irq, \
platform_pci_fixup_bus, \
+ platform_kernel_launch_event \
}
extern struct ia64_machine_vector ia64_mv;
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Fastboot] [PATCH 1/1] - platform_kernel_launch_event is noop
2007-03-01 13:03 ` Bernhard Walle
@ 2007-03-06 2:40 ` Jay Lan
-1 siblings, 0 replies; 10+ messages in thread
From: Jay Lan @ 2007-03-06 2:40 UTC (permalink / raw)
To: linux-ia64, linux-kernel
Bernhard Walle wrote:
> * Bernhard Walle <bwalle@suse.de> [2007-03-01 13:57]:
>> * Horms <horms@verge.net.au> [2007-03-01 05:22]:
>>> On Wed, Feb 28, 2007 at 01:45:17PM -0600, John Keller wrote:
>>>> Add a missing #define for the platform_kernel_launch_event.
>>>> Without this fix, a call to platform_kernel_launch_event()
>>>> becomes a noop on generic kernels. SN systems require this
>>>> fix to successfully kdump/kexec from certain hardware errors.
>>>>
>>>> Signed-off-by: John Keller <jpk@sgi.com>
>>> I made a similar change when porting to xen, but I hadn't thought
>>> to see if mainline linux needs it to.
>>>
>>> Acked-by: Simon Horman <horms@verge.net.au>
>> I think there's an additional change needed. Without that, it leads to
>> a NULL pointer dereference.
Yep, it is needed. The missing line was in Jack's original patch
but was lost somehow in 2.6.20.
Acked-by: Jay Lan <jlan@sgi.com>
>
> Maybe I should also get my editor right ... ;):
>
> ---
> include/asm-ia64/machvec.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> Index: b/include/asm-ia64/machvec.h
> =================================> --- a/include/asm-ia64/machvec.h
> +++ b/include/asm-ia64/machvec.h
> @@ -168,6 +168,7 @@ extern void machvec_tlb_migrate_finish (
> # define platform_setup_msi_irq ia64_mv.setup_msi_irq
> # define platform_teardown_msi_irq ia64_mv.teardown_msi_irq
> # define platform_pci_fixup_bus ia64_mv.pci_fixup_bus
> +# define platform_kernel_launch_event ia64_mv.kernel_launch_event
> # endif
>
> /* __attribute__((__aligned__(16))) is required to make size of the
> @@ -269,6 +270,7 @@ struct ia64_machine_vector {
> platform_setup_msi_irq, \
> platform_teardown_msi_irq, \
> platform_pci_fixup_bus, \
> + platform_kernel_launch_event \
> }
>
> extern struct ia64_machine_vector ia64_mv;
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [Fastboot] [PATCH 1/1] - platform_kernel_launch_event is noop on generic kernel
@ 2007-03-06 2:40 ` Jay Lan
0 siblings, 0 replies; 10+ messages in thread
From: Jay Lan @ 2007-03-06 2:40 UTC (permalink / raw)
To: linux-ia64, linux-kernel
Bernhard Walle wrote:
> * Bernhard Walle <bwalle@suse.de> [2007-03-01 13:57]:
>> * Horms <horms@verge.net.au> [2007-03-01 05:22]:
>>> On Wed, Feb 28, 2007 at 01:45:17PM -0600, John Keller wrote:
>>>> Add a missing #define for the platform_kernel_launch_event.
>>>> Without this fix, a call to platform_kernel_launch_event()
>>>> becomes a noop on generic kernels. SN systems require this
>>>> fix to successfully kdump/kexec from certain hardware errors.
>>>>
>>>> Signed-off-by: John Keller <jpk@sgi.com>
>>> I made a similar change when porting to xen, but I hadn't thought
>>> to see if mainline linux needs it to.
>>>
>>> Acked-by: Simon Horman <horms@verge.net.au>
>> I think there's an additional change needed. Without that, it leads to
>> a NULL pointer dereference.
Yep, it is needed. The missing line was in Jack's original patch
but was lost somehow in 2.6.20.
Acked-by: Jay Lan <jlan@sgi.com>
>
> Maybe I should also get my editor right ... ;):
>
> ---
> include/asm-ia64/machvec.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> Index: b/include/asm-ia64/machvec.h
> ===================================================================
> --- a/include/asm-ia64/machvec.h
> +++ b/include/asm-ia64/machvec.h
> @@ -168,6 +168,7 @@ extern void machvec_tlb_migrate_finish (
> # define platform_setup_msi_irq ia64_mv.setup_msi_irq
> # define platform_teardown_msi_irq ia64_mv.teardown_msi_irq
> # define platform_pci_fixup_bus ia64_mv.pci_fixup_bus
> +# define platform_kernel_launch_event ia64_mv.kernel_launch_event
> # endif
>
> /* __attribute__((__aligned__(16))) is required to make size of the
> @@ -269,6 +270,7 @@ struct ia64_machine_vector {
> platform_setup_msi_irq, \
> platform_teardown_msi_irq, \
> platform_pci_fixup_bus, \
> + platform_kernel_launch_event \
> }
>
> extern struct ia64_machine_vector ia64_mv;
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ia64" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2007-03-06 2:41 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-28 19:45 [PATCH 1/1] - platform_kernel_launch_event is noop on generic kernel John Keller
2007-02-28 19:45 ` John Keller
2007-03-01 4:22 ` [Fastboot] " Horms
2007-03-01 4:22 ` Horms
2007-03-01 12:57 ` Bernhard Walle
2007-03-01 12:57 ` Bernhard Walle
2007-03-01 13:03 ` Bernhard Walle
2007-03-01 13:03 ` Bernhard Walle
2007-03-06 2:40 ` [Fastboot] [PATCH 1/1] - platform_kernel_launch_event is noop Jay Lan
2007-03-06 2:40 ` [Fastboot] [PATCH 1/1] - platform_kernel_launch_event is noop on generic kernel Jay Lan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.