[PATCH] Reiser4 for 2.6.21-rc1

[PATCH] Reiser4 for 2.6.21-rc1

[Laurent Riffard]

Hello,

Please find my reiser4 patch for 2.6.21-rc1 at

http://laurent.riffard.free.fr/reiser4/reiser4-for-2.6.21-rc1/

There is 45 patches in this series. It should include all the reiser4 
for linux-mm stuff. Cryptocompress plugin is untested.


First patch is the Reiser4 patch for kernel 2.6.18 
(http://ftp.namesys.com/pub/reiser4-for-2.6/2.6.18/reiser4-for-2.6.18-3.patch.gz),
updated to apply cleanly on top of 2.6.21-rc1 kernel.

The 13 following patches are either bug-fix from reiserfs mailing-list 
or updates to compile cleanly against vanille kernel.

The last 30 patches come from linux-mm.


Adrian Bunk (3):
       reiser4-possible-cleanups-2
       fs-reiser4-possible-cleanups-2
       fs-reiser4-more-possible-cleanups

Alexander Zarochentsev (9):
       reiser4-reiser4_drop_page-dont-call-remove_from_page_cache
       reiser4-get-rid-of-semaphores-wherever-it-is-possible
 
reiser4-decribe-new-atom-locking-and-nested-atom-locks-to-lock-validator
       reiser4-use-generic-file-read
       reiser4-simplify-reading-of-partially-converted-files
       reiser4-use-page_offset
       reiser4-use-reiser4_gfp_mask_get-in-reiser4-inode-allocation
       reiser4-re-add-page_count-check-to-reiser4_releasepage
       reiser4-restore-fibmap-ioctl-support-for-packed-files

Andrew Morton (2):
       reiser4-test_clear_page_dirty
       reiser4-temp-fix

Andrew Wade (3):
       Reiser4: fix use after free in jrelse_tail
       Reiser4: release d_ref
       Reiser4: release d_ref (fix)

Edward Shishkin (17):
       Reiser4 for 2.6.18
       reiser4-generic_file_read-fix
       reiser4-rename-generic_sounding_globalspatch
       reiser4-use-generic-file-read-fix-readpages-unix-file
       reiser4-format-subversion-numbers-heir-set-and-file-conversion
 
reiser4-format-subversion-numbers-heir-set-and-file-conversion-fix-readpages-cryptcompress
       reiser4-cleanups-in-lzo-compression-library
       reiser4-get-rid-of-deprecated-crypto-api
       reiser4-get-rid-of-deprecated-crypto-api-build-fix
       reiser4-fix-missed-unlock-and-exit_context
       reiser4-use-list_head-instead-of-struct-blocknr
       reiser4-use-list_empty-instead-of-list_empty_careful-for
       reiser4-update-comments-fix-write-and-truncate-cryptcompress
       reiser4-fix-write_extent-1
       reiser4-fix-readpage_cryptcompress
       reiser4-improve-estimation-for-number-of-nodes-occupied
       reiser4-drop-check_cryptcompress

Laurent Riffard (8):
       Reiser4: cometics changes in mm/filemap.c.
       Reiser4: fix calls to kmem_cache_destroy
       Reiser4: Replace inode.u.generic_ip with inode.i_private
       Reiser4: inode.i_blksize suppression
       Reiser4: remove unnecessary config.h includes.
       slab: remove SLAB_KERNEL
       reiser4: remove kmem_cache_t
       Reiser4: Add includes linux/freezer.h

Randy Dunlap (1):
       reiser4-use-null-for-pointers

Vladimir Saveliev (2):
       reiser4-fix-gcc-ws-compains
       linux-2.6.20-rc4-mm1 Reiser4 filesystem freeze and corruption


Disclaimer: I'm not a filesystem guru, nor I'm affiliated with Namesys. 
These patches just suit my needs. It works for me and I hope it will 
help somebody else.
-- 
laurent

Re: [PATCH] Reiser4 for 2.6.21-rc1

[Laurent Riffard]

Oh,
I just saw a reiser4-for-2.6.19 available at 
http://ftp.namesys.com/pub/reiser4-for-2.6/2.6.19 . But there is no 
reiser4-for-2.6.20.

Is anyone interested in such a patch? I think I can backport my patches 
to this kernel.
-- 
laurent

Re: [PATCH] Reiser4 for 2.6.21-rc1

[Nicolas STRANSKY]

Le 02.03.2007 21:35, Laurent Riffard a écrit :
> Oh,
> I just saw a reiser4-for-2.6.19 available at
> http://ftp.namesys.com/pub/reiser4-for-2.6/2.6.19 . But there is no
> reiser4-for-2.6.20.
> 
> Is anyone interested in such a patch? I think I can backport my patches
> to this kernel.

I think many people would be interested by such a patch. There has
already been one attempt here :
http://permalink.gmane.org/gmane.comp.file-systems.reiserfs.general/20511
But nothing official has come up yet.

Best regards,
-- 
Nico
Par nature, le réceptacle se présente comme le porte-empreinte de
toutes choses. Il est absolument dépourvu des formes de toutes
les espèces de choses qu'il est susceptible de recevoir.
	-+- Platon -+-

Re: [PATCH] Reiser4 for 2.6.21-rc1

[Laurent Riffard]

Le 05.03.2007 18:20, Nicolas STRANSKY a écrit :
> Le 02.03.2007 21:35, Laurent Riffard a écrit :
>> Oh,
>> I just saw a reiser4-for-2.6.19 available at
>> http://ftp.namesys.com/pub/reiser4-for-2.6/2.6.19 . But there is no
>> reiser4-for-2.6.20.
>>
>> Is anyone interested in such a patch? I think I can backport my patches
>> to this kernel.
> 
> I think many people would be interested by such a patch. There has
> already been one attempt here :
> http://permalink.gmane.org/gmane.comp.file-systems.reiserfs.general/20511
> But nothing official has come up yet.
> 
> Best regards,

Ingo, I apologize: I noticed your mail some weeks ago but I forgot it and 
I didn't dig the archives...

Actually, I posted a reiser4 patch for 2.6.21-rc1 friday but this 
announce never reached the list (I'm afraid the list is unmaintained 
now...).

A few minutes later, I sent another mail to offer a patch for 2.6.20 
(that one reached the list). I then realized that reiser4-for-2.6.21-rc1 
does apply cleanly on Linux 2.6.20.

So here is the announce I made friday:
<====================
Hello,

Please find my reiser4 patch for 2.6.21-rc1 at 
http://laurent.riffard.free.fr/reiser4/reiser4-for-2.6.21-rc1/
There is 45 patches in this series. It should include all the reiser4 
for linux-mm stuff. Cryptocompress plugin is untested.

First patch is the Reiser4 patch for kernel 2.6.18
(http://ftp.namesys.com/pub/reiser4-for-2.6/2.6.18/reiser4-for-2.6.18-3.patch.gz),
updated to apply cleanly on top of 2.6.21-rc1 kernel.

The 13 following patches are either bug-fix from reiserfs mailing-list
or updates to compile cleanly against vanilla kernel.

The last 30 patches come from linux-mm.


Adrian Bunk (3):
      reiser4-possible-cleanups-2
      fs-reiser4-possible-cleanups-2
      fs-reiser4-more-possible-cleanups

Alexander Zarochentsev (9):
      reiser4-reiser4_drop_page-dont-call-remove_from_page_cache
      reiser4-get-rid-of-semaphores-wherever-it-is-possible

reiser4-decribe-new-atom-locking-and-nested-atom-locks-to-lock-validator
      reiser4-use-generic-file-read
      reiser4-simplify-reading-of-partially-converted-files
      reiser4-use-page_offset
      reiser4-use-reiser4_gfp_mask_get-in-reiser4-inode-allocation
      reiser4-re-add-page_count-check-to-reiser4_releasepage
      reiser4-restore-fibmap-ioctl-support-for-packed-files

Andrew Morton (2):
      reiser4-test_clear_page_dirty
      reiser4-temp-fix

Andrew Wade (3):
      Reiser4: fix use after free in jrelse_tail
      Reiser4: release d_ref
      Reiser4: release d_ref (fix)

Edward Shishkin (17):
      Reiser4 for 2.6.18
      reiser4-generic_file_read-fix
      reiser4-rename-generic_sounding_globalspatch
      reiser4-use-generic-file-read-fix-readpages-unix-file
      reiser4-format-subversion-numbers-heir-set-and-file-conversion

reiser4-format-subversion-numbers-heir-set-and-file-conversion-fix-readpages-cryptcompress
      reiser4-cleanups-in-lzo-compression-library
      reiser4-get-rid-of-deprecated-crypto-api
      reiser4-get-rid-of-deprecated-crypto-api-build-fix
      reiser4-fix-missed-unlock-and-exit_context
      reiser4-use-list_head-instead-of-struct-blocknr
      reiser4-use-list_empty-instead-of-list_empty_careful-for
      reiser4-update-comments-fix-write-and-truncate-cryptcompress
      reiser4-fix-write_extent-1
      reiser4-fix-readpage_cryptcompress
      reiser4-improve-estimation-for-number-of-nodes-occupied
      reiser4-drop-check_cryptcompress

Laurent Riffard (8):
      Reiser4: cometics changes in mm/filemap.c.
      Reiser4: fix calls to kmem_cache_destroy
      Reiser4: Replace inode.u.generic_ip with inode.i_private
      Reiser4: inode.i_blksize suppression
      Reiser4: remove unnecessary config.h includes.
      slab: remove SLAB_KERNEL
      reiser4: remove kmem_cache_t
      Reiser4: Add includes linux/freezer.h

Randy Dunlap (1):
      reiser4-use-null-for-pointers

Vladimir Saveliev (2):
      reiser4-fix-gcc-ws-compains
      linux-2.6.20-rc4-mm1 Reiser4 filesystem freeze and corruption


Disclaimer: I'm not a filesystem guru, nor I'm affiliated with Namesys. 
These patches just suit my needs. It works for me and I hope it will 
help somebody else. 
===============================================>

-- 
laurent

Re: [PATCH] Reiser4 for 2.6.21-rc1

[Edward Shishkin]

Thanks to everyone for your help.
I hope the list works now.

Edward.
 
Laurent Riffard wrote:

> Le 05.03.2007 18:20, Nicolas STRANSKY a écrit :
>
>> Le 02.03.2007 21:35, Laurent Riffard a écrit :
>>
>>> Oh,
>>> I just saw a reiser4-for-2.6.19 available at
>>> http://ftp.namesys.com/pub/reiser4-for-2.6/2.6.19 . But there is no
>>> reiser4-for-2.6.20.
>>>
>>> Is anyone interested in such a patch? I think I can backport my patches
>>> to this kernel.
>>
>>
>> I think many people would be interested by such a patch. There has
>> already been one attempt here :
>> http://permalink.gmane.org/gmane.comp.file-systems.reiserfs.general/20511 
>>
>> But nothing official has come up yet.
>>
>> Best regards,
>
>
> Ingo, I apologize: I noticed your mail some weeks ago but I forgot it 
> and I didn't dig the archives...
>
> Actually, I posted a reiser4 patch for 2.6.21-rc1 friday but this 
> announce never reached the list (I'm afraid the list is unmaintained 
> now...).
>
> A few minutes later, I sent another mail to offer a patch for 2.6.20 
> (that one reached the list). I then realized that 
> reiser4-for-2.6.21-rc1 does apply cleanly on Linux 2.6.20.
>
> So here is the announce I made friday:
> <====================
> Hello,
>
> Please find my reiser4 patch for 2.6.21-rc1 at 
> http://laurent.riffard.free.fr/reiser4/reiser4-for-2.6.21-rc1/
> There is 45 patches in this series. It should include all the reiser4 
> for linux-mm stuff. Cryptocompress plugin is untested.
>
> First patch is the Reiser4 patch for kernel 2.6.18
> (http://ftp.namesys.com/pub/reiser4-for-2.6/2.6.18/reiser4-for-2.6.18-3.patch.gz), 
>
> updated to apply cleanly on top of 2.6.21-rc1 kernel.
>
> The 13 following patches are either bug-fix from reiserfs mailing-list
> or updates to compile cleanly against vanilla kernel.
>
> The last 30 patches come from linux-mm.
>
>
> Adrian Bunk (3):
>      reiser4-possible-cleanups-2
>      fs-reiser4-possible-cleanups-2
>      fs-reiser4-more-possible-cleanups
>
> Alexander Zarochentsev (9):
>      reiser4-reiser4_drop_page-dont-call-remove_from_page_cache
>      reiser4-get-rid-of-semaphores-wherever-it-is-possible
>
> reiser4-decribe-new-atom-locking-and-nested-atom-locks-to-lock-validator
>      reiser4-use-generic-file-read
>      reiser4-simplify-reading-of-partially-converted-files
>      reiser4-use-page_offset
>      reiser4-use-reiser4_gfp_mask_get-in-reiser4-inode-allocation
>      reiser4-re-add-page_count-check-to-reiser4_releasepage
>      reiser4-restore-fibmap-ioctl-support-for-packed-files
>
> Andrew Morton (2):
>      reiser4-test_clear_page_dirty
>      reiser4-temp-fix
>
> Andrew Wade (3):
>      Reiser4: fix use after free in jrelse_tail
>      Reiser4: release d_ref
>      Reiser4: release d_ref (fix)
>
> Edward Shishkin (17):
>      Reiser4 for 2.6.18
>      reiser4-generic_file_read-fix
>      reiser4-rename-generic_sounding_globalspatch
>      reiser4-use-generic-file-read-fix-readpages-unix-file
>      reiser4-format-subversion-numbers-heir-set-and-file-conversion
>
> reiser4-format-subversion-numbers-heir-set-and-file-conversion-fix-readpages-cryptcompress 
>
>      reiser4-cleanups-in-lzo-compression-library
>      reiser4-get-rid-of-deprecated-crypto-api
>      reiser4-get-rid-of-deprecated-crypto-api-build-fix
>      reiser4-fix-missed-unlock-and-exit_context
>      reiser4-use-list_head-instead-of-struct-blocknr
>      reiser4-use-list_empty-instead-of-list_empty_careful-for
>      reiser4-update-comments-fix-write-and-truncate-cryptcompress
>      reiser4-fix-write_extent-1
>      reiser4-fix-readpage_cryptcompress
>      reiser4-improve-estimation-for-number-of-nodes-occupied
>      reiser4-drop-check_cryptcompress
>
> Laurent Riffard (8):
>      Reiser4: cometics changes in mm/filemap.c.
>      Reiser4: fix calls to kmem_cache_destroy
>      Reiser4: Replace inode.u.generic_ip with inode.i_private
>      Reiser4: inode.i_blksize suppression
>      Reiser4: remove unnecessary config.h includes.
>      slab: remove SLAB_KERNEL
>      reiser4: remove kmem_cache_t
>      Reiser4: Add includes linux/freezer.h
>
> Randy Dunlap (1):
>      reiser4-use-null-for-pointers
>
> Vladimir Saveliev (2):
>      reiser4-fix-gcc-ws-compains
>      linux-2.6.20-rc4-mm1 Reiser4 filesystem freeze and corruption
>
>
> Disclaimer: I'm not a filesystem guru, nor I'm affiliated with 
> Namesys. These patches just suit my needs. It works for me and I hope 
> it will help somebody else. 
> ===============================================>
>

reiser4 panic in do_readpage_extent

[Devils-Hawk]

Recently tried switching from 2.6.18 + reiser4-for-2.6.18-r3.patch.gz, 
which works perfectly fine to 2.6.19 + reiser4-for-2.6.19-r3.patch.gz
I also tried 2.6.20 laurent riffard's reiser4-for-2.6.20. The last both 
die somewhere during init when one of the 2 following asserts fails:
extent_file_ops, Line 1160: assert("nikita-2688"),j)
extent_file_ops, Line 1161: assert("vs-1426"),jnode_page(j) == NULL )

fs was fsck'ed with reiser4progs-1.0.5

regards DevH

Re: reiser4 panic in do_readpage_extent

[Edward Shishkin]

Devils-Hawk wrote:

> Recently tried switching from 2.6.18 + reiser4-for-2.6.18-r3.patch.gz, 
> which works perfectly fine to 2.6.19 + reiser4-for-2.6.19-r3.patch.gz
> I also tried 2.6.20 laurent riffard's reiser4-for-2.6.20. The last 
> both die somewhere during init when one of the 2 following asserts fails:
> extent_file_ops, Line 1160: assert("nikita-2688"),j)
> extent_file_ops, Line 1161: assert("vs-1426"),jnode_page(j) == NULL )
>

It seems, new file_read is not happy.
Thanks for the report, we'll take a look.

Edward.

> fs was fsck'ed with reiser4progs-1.0.5
>
> regards DevH
>
>

Re: reiser4 panic in do_readpage_extent

[Edward Shishkin]

[-- Attachment #1: Type: text/plain, Size: 591 bytes --]

Devils-Hawk wrote:

> Recently tried switching from 2.6.18 + reiser4-for-2.6.18-r3.patch.gz, 
> which works perfectly fine to 2.6.19 + reiser4-for-2.6.19-r3.patch.gz
> I also tried 2.6.20 laurent riffard's reiser4-for-2.6.20. The last 
> both die somewhere during init when one of the 2 following asserts fails:
> extent_file_ops, Line 1160: assert("nikita-2688"),j)
> extent_file_ops, Line 1161: assert("vs-1426"),jnode_page(j) == NULL )
>
> fs was fsck'ed with reiser4progs-1.0.5
>
> regards DevH
>
>

Would you please try the attached patch over reiser4-for-2.6.[19, 20]

Thanks,
Edward.

[-- Attachment #2: reiser4-handle-race-in-readpages-filler.patch --]
[-- Type: text/x-patch, Size: 542 bytes --]

Handle possible race:
do not proceed uf_readpages_filler if page is already uptodate.

Signed-off-by: Edward Shishkin <edward@namesys.com>
---
 linux-2.6.20-mm2/fs/reiser4/plugin/file/file.c |    4 ++++
 1 files changed, 4 insertions(+)

--- linux-2.6.20-mm2/fs/reiser4/plugin/file/file.c.orig
+++ linux-2.6.20-mm2/fs/reiser4/plugin/file/file.c
@@ -1619,6 +1619,10 @@
 		lock_page(page);
 		cbk_done = 1;
 	}
+	if (PageUptodate(page)) {
+		unlock_page(page);
+		return 0;
+	}
 	ret = zload(rc->coord.node);
 	if (ret) {
 		unlock_page(page);

Re: reiser4 panic in do_readpage_extent

[Devils-Hawk]

The problem still persists also trying to boot multiple times it 
sometimes triggers much earlier in the boot process than it did before.

regards devh

Edward Shishkin wrote:
> 
> Would you please try the attached patch over reiser4-for-2.6.[19, 20]
> 
> Thanks,
> Edward.
> 

Re: reiser4 panic in do_readpage_extent

[Edward Shishkin]

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

Devils-Hawk wrote:

> The problem still persists also trying to boot multiple times it 
> sometimes triggers much earlier in the boot process than it did before.
>

Hmm.. can not reproduce it..
The attached patch (against reiser4-for-2.6[19, 20]) allows to dump stack
and some useful info noted as edward-200X among other boot messages.
Would you please send it.

Thanks,
Edward.

> regards devh
>
> Edward Shishkin wrote:
>
>>
>> Would you please try the attached patch over reiser4-for-2.6.[19, 20]
>>
>> Thanks,
>> Edward.
>>
>
>
>


[-- Attachment #2: dump_stack.patch --]
[-- Type: text/x-patch, Size: 1556 bytes --]

Handle possible race:
do not proceed uf_readpages_filler if page is already uptodate.
Print debugging info.

Signed-off-by: Edward Shishkin <edward@namesys.com>
---
 linux-2.6.20-mm2/fs/reiser4/plugin/file/file.c            |    4 +++
 linux-2.6.20-mm2/fs/reiser4/plugin/item/extent_file_ops.c |   17 ++++++++++++++
 2 files changed, 21 insertions(+)

--- linux-2.6.20-mm2/fs/reiser4/plugin/file/file.c.orig
+++ linux-2.6.20-mm2/fs/reiser4/plugin/file/file.c
@@ -1619,6 +1619,10 @@
 		lock_page(page);
 		cbk_done = 1;
 	}
+	if (PageUptodate(page)) {
+		unlock_page(page);
+		return 0;
+	}
 	ret = zload(rc->coord.node);
 	if (ret) {
 		unlock_page(page);
--- linux-2.6.20-mm2/fs/reiser4/plugin/item/extent_file_ops.c.orig
+++ linux-2.6.20-mm2/fs/reiser4/plugin/item/extent_file_ops.c
@@ -1157,7 +1157,24 @@
 
 	case UNALLOCATED_EXTENT:
 		j = jfind(mapping, index);
+		if (j == NULL) {
+			dump_stack();
+			printk("edward-2000: oid = %llu\n",
+			       (unsigned long long)oid);
+			printk("edward-2001: Jnode not found\n");
+		}
 		assert("nikita-2688", j);
+		if (jnode_page(j) != NULL) {
+			dump_stack();
+			printk("edward-2002: oid = %llu\n",
+			       (unsigned long long)oid);
+			printk("edward-2003: read page  %p of idx %lu\n",
+			       page, page->index);
+			printk("edward-2004: jnode page %p of idx %lu\n",
+			       jnode_page(j), jnode_page(j)->index);
+			printk("edward-2005: jnode blknr =  %llu\n",
+			       (unsigned long long)(*jnode_get_block(j)));
+		}
 		assert("vs-1426", jnode_page(j) == NULL);
 
 		spin_lock_jnode(j);

Re: [PATCH] Reiser4 for 2.6.21-rc1

[Laurent Riffard]

Le 06.03.2007 10:21, Christian Trefzer a écrit :
> Hello Laurent,
> 
> I've been using reiser4 with compression extensively during the past
> months, and so I followed its development in -mm pretty closely,
> applying reiser4-internal patches to my ancient 2.6.19-rc6-mm2 tree.
> Your patch applies cleanly against current -stable and vanilla kernels,
> nice job!  Yet the changelog of the newest -mm patchset yields two new
> patches by Edward Shishkin, which also apply cleanly on top of your
> patch.  I've been using them for days now without incident, so I think
> they might be alright ; )  In order to keep these patches unmodified, I
> will attach them both to this e-mail.

Thanks for pointing out these 2 patches. I added them and I just updated 
http://laurent.riffard.free.fr/reiser4/reiser4-for-2.6.20 and 
http://laurent.riffard.free.fr/reiser4/reiser4-for-2.6.21-rc1.

-- 
laurent