* libata: Fix host->simplex_claimed != ap typo
@ 2007-03-08 14:17 OGAWA Hirofumi
2007-03-08 14:24 ` Jeff Garzik
2007-03-08 16:01 ` Alan Cox
0 siblings, 2 replies; 6+ messages in thread
From: OGAWA Hirofumi @ 2007-03-08 14:17 UTC (permalink / raw)
To: Jeff Garzik, Alan Cox; +Cc: Andrew Morton, linux-kernel
Hi,
the following patch is needed to boot my laptop using pata_ali.ko, at least.
Please apply.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Fix typo. "host->simplex_claimed != ap" should be "==", not "!=".
Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
---
drivers/ata/libata-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/ata/libata-core.c~ata-fix-simplex-handling-fix drivers/ata/libata-core.c
--- linux-2.6/drivers/ata/libata-core.c~ata-fix-simplex-handling-fix 2007-03-08 07:31:49.000000000 +0900
+++ linux-2.6-hirofumi/drivers/ata/libata-core.c 2007-03-08 07:31:59.000000000 +0900
@@ -3455,7 +3455,7 @@ static void ata_dev_xfermask(struct ata_
"device is on DMA blacklist, disabling DMA\n");
}
- if ((host->flags & ATA_HOST_SIMPLEX) && host->simplex_claimed != ap) {
+ if ((host->flags & ATA_HOST_SIMPLEX) && host->simplex_claimed == ap) {
xfer_mask &= ~(ATA_MASK_MWDMA | ATA_MASK_UDMA);
ata_dev_printk(dev, KERN_WARNING, "simplex DMA is claimed by "
"other device, disabling DMA\n");
_
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: libata: Fix host->simplex_claimed != ap typo
2007-03-08 14:17 libata: Fix host->simplex_claimed != ap typo OGAWA Hirofumi
@ 2007-03-08 14:24 ` Jeff Garzik
2007-03-08 16:01 ` Alan Cox
1 sibling, 0 replies; 6+ messages in thread
From: Jeff Garzik @ 2007-03-08 14:24 UTC (permalink / raw)
To: OGAWA Hirofumi; +Cc: Alan Cox, Andrew Morton, linux-kernel
OGAWA Hirofumi wrote:
> Hi,
>
> the following patch is needed to boot my laptop using pata_ali.ko, at least.
> Please apply.
Someone else caught this as well. This will go upstream today.
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: libata: Fix host->simplex_claimed != ap typo
2007-03-08 16:01 ` Alan Cox
@ 2007-03-08 15:18 ` Jeff Garzik
2007-03-08 16:25 ` Alan Cox
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Garzik @ 2007-03-08 15:18 UTC (permalink / raw)
To: Alan Cox; +Cc: OGAWA Hirofumi, Alan Cox, Andrew Morton, linux-kernel
Alan Cox wrote:
> On Thu, 08 Mar 2007 23:17:00 +0900
> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> wrote:
>
>> Hi,
>>
>> the following patch is needed to boot my laptop using pata_ali.ko, at least.
>> Please apply.
>
> NAK - correct fix is to check != && != NULL. The correct fix was posted
> to the list earlier by Vojtech.
You mean Petr Vandrovec I presume?
Jeff
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: libata: Fix host->simplex_claimed != ap typo
2007-03-08 14:17 libata: Fix host->simplex_claimed != ap typo OGAWA Hirofumi
2007-03-08 14:24 ` Jeff Garzik
@ 2007-03-08 16:01 ` Alan Cox
2007-03-08 15:18 ` Jeff Garzik
1 sibling, 1 reply; 6+ messages in thread
From: Alan Cox @ 2007-03-08 16:01 UTC (permalink / raw)
To: OGAWA Hirofumi; +Cc: Jeff Garzik, Alan Cox, Andrew Morton, linux-kernel
On Thu, 08 Mar 2007 23:17:00 +0900
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> wrote:
> Hi,
>
> the following patch is needed to boot my laptop using pata_ali.ko, at least.
> Please apply.
NAK - correct fix is to check != && != NULL. The correct fix was posted
to the list earlier by Vojtech.
Alan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: libata: Fix host->simplex_claimed != ap typo
2007-03-08 15:18 ` Jeff Garzik
@ 2007-03-08 16:25 ` Alan Cox
2007-03-08 20:24 ` OGAWA Hirofumi
0 siblings, 1 reply; 6+ messages in thread
From: Alan Cox @ 2007-03-08 16:25 UTC (permalink / raw)
To: Jeff Garzik; +Cc: OGAWA Hirofumi, Alan Cox, Andrew Morton, linux-kernel
On Thu, 08 Mar 2007 10:18:24 -0500
Jeff Garzik <jeff@garzik.org> wrote:
> Alan Cox wrote:
> > On Thu, 08 Mar 2007 23:17:00 +0900
> > OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> wrote:
> >
> >> Hi,
> >>
> >> the following patch is needed to boot my laptop using pata_ali.ko, at least.
> >> Please apply.
> >
> > NAK - correct fix is to check != && != NULL. The correct fix was posted
> > to the list earlier by Vojtech.
>
> You mean Petr Vandrovec I presume?
Sorry got the wrong person - I do indeed
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: libata: Fix host->simplex_claimed != ap typo
2007-03-08 16:25 ` Alan Cox
@ 2007-03-08 20:24 ` OGAWA Hirofumi
0 siblings, 0 replies; 6+ messages in thread
From: OGAWA Hirofumi @ 2007-03-08 20:24 UTC (permalink / raw)
To: Alan Cox; +Cc: Jeff Garzik, Alan Cox, Andrew Morton, linux-kernel
Alan Cox <alan@lxorguk.ukuu.org.uk> writes:
> On Thu, 08 Mar 2007 10:18:24 -0500
> Jeff Garzik <jeff@garzik.org> wrote:
>
>> Alan Cox wrote:
>> > On Thu, 08 Mar 2007 23:17:00 +0900
>> > OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> wrote:
>> >
>> >> Hi,
>> >>
>> >> the following patch is needed to boot my laptop using pata_ali.ko, at least.
>> >> Please apply.
>> >
>> > NAK - correct fix is to check != && != NULL. The correct fix was posted
>> > to the list earlier by Vojtech.
>>
>> You mean Petr Vandrovec I presume?
>
> Sorry got the wrong person - I do indeed
I found the Petr's patch in linux-ide and confirmed it. Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-03-08 20:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-08 14:17 libata: Fix host->simplex_claimed != ap typo OGAWA Hirofumi
2007-03-08 14:24 ` Jeff Garzik
2007-03-08 16:01 ` Alan Cox
2007-03-08 15:18 ` Jeff Garzik
2007-03-08 16:25 ` Alan Cox
2007-03-08 20:24 ` OGAWA Hirofumi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.