All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Cushman <rcushman_linux@earthlink.net>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Adrian Bunk <bunk@stusta.de>,
	Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
	Jaroslav Kysela <perex@suse.cz>,
	linux-kernel@vger.kernel.org
Subject: Re: mm snapshot broken-out-2007-03-05-02-22.tar.gz uploaded
Date: Thu, 08 Mar 2007 14:28:07 -0500	[thread overview]
Message-ID: <45F063C7.3030503@earthlink.net> (raw)
In-Reply-To: <s5hvehbmuvb.wl%tiwai@suse.de>

Takashi Iwai wrote:
> At Thu, 08 Mar 2007 12:05:49 -0500,
> Randy Cushman wrote:
>   
>> Takashi Iwai wrote:
>>     
>>> At Thu, 8 Mar 2007 17:52:43 +0100,
>>> Michal Piotrowski wrote:
>>>   
>>>       
>>>> On 08/03/07, Takashi Iwai <tiwai@suse.de> wrote:
>>>>     
>>>>         
>>>>> At Thu, 08 Mar 2007 16:42:26 +0100,
>>>>> Michal Piotrowski wrote:
>>>>>       
>>>>>           
>>>>>>> Also, it'd be helpful if you compare
>>>>>>> /proc/asound/card0/codec97#0/ac97#0-0+regs file before and after the
>>>>>>> patch.  This reveals which register bits differ actually.
>>>>>>>           
>>>>>>>               
>>>>>> a2.txt is form 2.6.21-rc3 witchout 831466f4ad2b5fe23dff77edbe6a7c244435e973
>>>>>>
>>>>>> diff -uprN a2.txt /proc/asound/card0/codec97#0/ac97#0-0+regs
>>>>>> --- a2.txt      2007-03-08 16:36:47.000000000 +0100
>>>>>> +++ /proc/asound/card0/codec97#0/ac97#0-0+regs  2007-03-08 16:36:49.447083597 +0100
>>>>>> @@ -56,8 +56,8 @@
>>>>>>  0:6e = 0000
>>>>>>  0:70 = 0000
>>>>>>  0:72 = 0004
>>>>>> -0:74 = 1001
>>>>>> -0:76 = 64a4
>>>>>> +0:74 = 1201
>>>>>> +0:76 = 7ca4
>>>>>>  0:78 = 000c
>>>>>>  0:7a = 0000
>>>>>>  0:7c = 4144
>>>>>>         
>>>>>>             
>>>>> OK, some wrong bits there.  Could you try the patch below?
>>>>>       
>>>>>           
>>>> Problem fixed. Thanks!
>>>>
>>>> (speaker-test -c6 -Dplug:surround51 is still broken)
>>>>     
>>>>         
>>> Hm, how about turning off "Spread Front To..." control and run
>>> speaker-test?
>>>
>>>
>>> Takashi
>>>
>>>
>>>   
>>>       
>> Michal and Takashi,
>>
>> I've been researching your issue this morning.  I just noticed that your 
>> exchange had ensued.
>>
>> I configured my AD1986-based system as closely as I could to match your 
>> AD1985 mixer settings.  In doing so, I experienced results similar to 
>> what I'm assuming you described:  Only front channel sound came out of 
>> the surround and c/lfe jacks.
>>
>> Here is what I had to change to get the appropriate multichannel sound:
>>
>> 1) The command "speaker-test -c6" does not work on my system.  I have to 
>> use "speaker-test -Dsurround51 -c6"  (Perhaps this is related to running 
>> an old version of speaker-test.)
>>
>> 2) I disabled "Spread Front to Surround and Center/LFE"
>>
>> The explanation for 2) is this:  There can be only one source for each 
>> of the Surround and Center/LFE jacks active at one time.  When "Spread 
>> Front to Surround and Center/LFE" is disabled, the surround channels go 
>> to the the jacks; when this control is enabled, ONLY the front channels 
>> go to the surround and c/lfe jacks.
>>
>> Considering the register values Michal provided and Takashi's patch:
>>
>> The logic of the code is as follows:  (Slightly simplifying,) functions 
>> is_shared_linein() and is_shared_micin() return TRUE if the mixer is 
>> configured for shared jacks AND NOT for 6 channel mode.  In this case it 
>> is appropriate to
>> set these bits (LODIS and CLDIS).
>>     
>
> Yep.  So, can you confirm that my fix is OK?
> Then I'll queue it up to ALSA tree.
>
>
> thanks,
>
> Takashi
>
>
>   
Takashi,

I need to think this through before I can confirm.  Something doesn't 
seem right.

Let me figure out why I wrote ad1986_update_jacks() to be so different 
from ad1888_update_jacks().

I'll keep you posted.

Randy Cushman



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

WARNING: multiple messages have this Message-ID (diff)
From: Randy Cushman <rcushman_linux@earthlink.net>
To: Takashi Iwai <tiwai@suse.de>
Cc: Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
	Jaroslav Kysela <perex@suse.cz>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	Adrian Bunk <bunk@stusta.de>
Subject: Re: mm snapshot broken-out-2007-03-05-02-22.tar.gz uploaded
Date: Thu, 08 Mar 2007 14:28:07 -0500	[thread overview]
Message-ID: <45F063C7.3030503@earthlink.net> (raw)
In-Reply-To: <s5hvehbmuvb.wl%tiwai@suse.de>

Takashi Iwai wrote:
> At Thu, 08 Mar 2007 12:05:49 -0500,
> Randy Cushman wrote:
>   
>> Takashi Iwai wrote:
>>     
>>> At Thu, 8 Mar 2007 17:52:43 +0100,
>>> Michal Piotrowski wrote:
>>>   
>>>       
>>>> On 08/03/07, Takashi Iwai <tiwai@suse.de> wrote:
>>>>     
>>>>         
>>>>> At Thu, 08 Mar 2007 16:42:26 +0100,
>>>>> Michal Piotrowski wrote:
>>>>>       
>>>>>           
>>>>>>> Also, it'd be helpful if you compare
>>>>>>> /proc/asound/card0/codec97#0/ac97#0-0+regs file before and after the
>>>>>>> patch.  This reveals which register bits differ actually.
>>>>>>>           
>>>>>>>               
>>>>>> a2.txt is form 2.6.21-rc3 witchout 831466f4ad2b5fe23dff77edbe6a7c244435e973
>>>>>>
>>>>>> diff -uprN a2.txt /proc/asound/card0/codec97#0/ac97#0-0+regs
>>>>>> --- a2.txt      2007-03-08 16:36:47.000000000 +0100
>>>>>> +++ /proc/asound/card0/codec97#0/ac97#0-0+regs  2007-03-08 16:36:49.447083597 +0100
>>>>>> @@ -56,8 +56,8 @@
>>>>>>  0:6e = 0000
>>>>>>  0:70 = 0000
>>>>>>  0:72 = 0004
>>>>>> -0:74 = 1001
>>>>>> -0:76 = 64a4
>>>>>> +0:74 = 1201
>>>>>> +0:76 = 7ca4
>>>>>>  0:78 = 000c
>>>>>>  0:7a = 0000
>>>>>>  0:7c = 4144
>>>>>>         
>>>>>>             
>>>>> OK, some wrong bits there.  Could you try the patch below?
>>>>>       
>>>>>           
>>>> Problem fixed. Thanks!
>>>>
>>>> (speaker-test -c6 -Dplug:surround51 is still broken)
>>>>     
>>>>         
>>> Hm, how about turning off "Spread Front To..." control and run
>>> speaker-test?
>>>
>>>
>>> Takashi
>>>
>>>
>>>   
>>>       
>> Michal and Takashi,
>>
>> I've been researching your issue this morning.  I just noticed that your 
>> exchange had ensued.
>>
>> I configured my AD1986-based system as closely as I could to match your 
>> AD1985 mixer settings.  In doing so, I experienced results similar to 
>> what I'm assuming you described:  Only front channel sound came out of 
>> the surround and c/lfe jacks.
>>
>> Here is what I had to change to get the appropriate multichannel sound:
>>
>> 1) The command "speaker-test -c6" does not work on my system.  I have to 
>> use "speaker-test -Dsurround51 -c6"  (Perhaps this is related to running 
>> an old version of speaker-test.)
>>
>> 2) I disabled "Spread Front to Surround and Center/LFE"
>>
>> The explanation for 2) is this:  There can be only one source for each 
>> of the Surround and Center/LFE jacks active at one time.  When "Spread 
>> Front to Surround and Center/LFE" is disabled, the surround channels go 
>> to the the jacks; when this control is enabled, ONLY the front channels 
>> go to the surround and c/lfe jacks.
>>
>> Considering the register values Michal provided and Takashi's patch:
>>
>> The logic of the code is as follows:  (Slightly simplifying,) functions 
>> is_shared_linein() and is_shared_micin() return TRUE if the mixer is 
>> configured for shared jacks AND NOT for 6 channel mode.  In this case it 
>> is appropriate to
>> set these bits (LODIS and CLDIS).
>>     
>
> Yep.  So, can you confirm that my fix is OK?
> Then I'll queue it up to ALSA tree.
>
>
> thanks,
>
> Takashi
>
>
>   
Takashi,

I need to think this through before I can confirm.  Something doesn't 
seem right.

Let me figure out why I wrote ad1986_update_jacks() to be so different 
from ad1888_update_jacks().

I'll keep you posted.

Randy Cushman



  reply	other threads:[~2007-03-08 19:28 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-05 10:24 mm snapshot broken-out-2007-03-05-02-22.tar.gz uploaded akpm
2007-03-05 14:49 ` Michal Piotrowski
2007-03-05 14:49 ` Michal Piotrowski
2007-03-07 11:36   ` Michal Piotrowski
2007-03-07 11:36   ` Michal Piotrowski
2007-03-07 18:47     ` Andrew Morton
2007-03-07 18:47       ` Andrew Morton
2007-03-07 19:41       ` Michal Piotrowski
2007-03-07 19:50         ` Andrew Morton
2007-03-07 19:50           ` Andrew Morton
2007-03-07 20:39           ` Takashi Iwai
2007-03-07 20:39             ` Takashi Iwai
2007-03-07 22:22             ` Michal Piotrowski
2007-03-07 22:22               ` Michal Piotrowski
2007-03-07 22:44               ` Takashi Iwai
2007-03-07 22:44                 ` Takashi Iwai
2007-03-08 15:42                 ` Michal Piotrowski
2007-03-08 15:42                   ` Michal Piotrowski
2007-03-08 15:46                   ` Michal Piotrowski
2007-03-08 15:55                   ` Takashi Iwai
2007-03-08 15:55                     ` Takashi Iwai
2007-03-08 16:26                     ` Michal Piotrowski
2007-03-08 16:28                       ` Takashi Iwai
2007-03-08 16:28                       ` Takashi Iwai
2007-03-08 15:58                   ` Takashi Iwai
2007-03-08 15:58                     ` Takashi Iwai
2007-03-08 16:23                     ` Michal Piotrowski
2007-03-08 16:23                       ` Michal Piotrowski
2007-03-08 16:15                   ` Takashi Iwai
2007-03-08 16:15                     ` Takashi Iwai
2007-03-08 16:52                     ` Michal Piotrowski
2007-03-08 16:52                       ` Michal Piotrowski
2007-03-08 16:54                       ` Takashi Iwai
2007-03-08 16:54                         ` Takashi Iwai
2007-03-08 17:05                         ` Michal Piotrowski
2007-03-08 17:05                           ` Michal Piotrowski
2007-03-08 17:05                         ` Randy Cushman
2007-03-08 17:05                           ` Randy Cushman
2007-03-08 18:51                           ` Takashi Iwai
2007-03-08 18:51                             ` Takashi Iwai
2007-03-08 19:28                             ` Randy Cushman [this message]
2007-03-08 19:28                               ` Randy Cushman
2007-03-08 23:05                             ` Patch: Shared jack control logic for AD1985 and others Randy Cushman
2007-03-09 14:22                               ` Takashi Iwai
2007-03-07 22:16           ` mm snapshot broken-out-2007-03-05-02-22.tar.gz uploaded Michal Piotrowski
2007-03-07 22:16             ` Michal Piotrowski
2007-03-05 15:53 ` Michal Piotrowski
2007-03-05 18:02 ` Michal Piotrowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45F063C7.3030503@earthlink.net \
    --to=rcushman_linux@earthlink.net \
    --cc=alsa-devel@alsa-project.org \
    --cc=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.k.k.piotrowski@gmail.com \
    --cc=perex@suse.cz \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.