* [Cluster-devel] [PATCH] dlm: Fix uninitialised variable in receiving
@ 2007-03-13 17:08 Patrick Caulfield
2007-03-13 17:11 ` Robert Peterson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Patrick Caulfield @ 2007-03-13 17:08 UTC (permalink / raw)
To: cluster-devel.redhat.com
The length of the second element of the kvec array was not initialised before
being added to the first one. This could cause invalid lengths to be passed to
kernel_recvmsg
Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com>
--
patrick
-------------- next part --------------
A non-text attachment was scrubbed...
Name: lowcomms.patch
Type: text/x-patch
Size: 390 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/cluster-devel/attachments/20070313/8a38a5bc/attachment.bin>
^ permalink raw reply [flat|nested] 4+ messages in thread* [Cluster-devel] [PATCH] dlm: Fix uninitialised variable in receiving
2007-03-13 17:08 [Cluster-devel] [PATCH] dlm: Fix uninitialised variable in receiving Patrick Caulfield
@ 2007-03-13 17:11 ` Robert Peterson
2007-03-13 17:34 ` Patrick Caulfield
2007-03-14 11:58 ` Steven Whitehouse
2 siblings, 0 replies; 4+ messages in thread
From: Robert Peterson @ 2007-03-13 17:11 UTC (permalink / raw)
To: cluster-devel.redhat.com
Patrick Caulfield wrote:
> The length of the second element of the kvec array was not initialised before
> being added to the first one. This could cause invalid lengths to be passed to
> kernel_recvmsg
>
> Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com>
>
>
> ------------------------------------------------------------------------
>
> diff --git a/fs/dlm/lowcomms-tcp.c b/fs/dlm/lowcomms-tcp.c
> index 07e0a12..9bfe7fb 100644
> --- a/fs/dlm/lowcomms-tcp.c
> +++ b/fs/dlm/lowcomms-tcp.c
> @@ -299,6 +299,7 @@ static int receive_from_sock(struct connection *con)
> */
> iov[0].iov_len = con->cb.base - cbuf_data(&con->cb);
> iov[0].iov_base = page_address(con->rx_page) + cbuf_data(&con->cb);
> + iov[1].iov_len = 0;
> nvec = 1;
>
> /*
ACK
This is a necessary fix.
Bob Peterson
Red Hat Cluster Suite
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Cluster-devel] [PATCH] dlm: Fix uninitialised variable in receiving
2007-03-13 17:08 [Cluster-devel] [PATCH] dlm: Fix uninitialised variable in receiving Patrick Caulfield
2007-03-13 17:11 ` Robert Peterson
@ 2007-03-13 17:34 ` Patrick Caulfield
2007-03-14 11:58 ` Steven Whitehouse
2 siblings, 0 replies; 4+ messages in thread
From: Patrick Caulfield @ 2007-03-13 17:34 UTC (permalink / raw)
To: cluster-devel.redhat.com
Patrick Caulfield wrote:
> The length of the second element of the kvec array was not initialised before
> being added to the first one. This could cause invalid lengths to be passed to
> kernel_recvmsg
>
> Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com>
>
>
> ------------------------------------------------------------------------
>
> diff --git a/fs/dlm/lowcomms-tcp.c b/fs/dlm/lowcomms-tcp.c
> index 07e0a12..9bfe7fb 100644
> --- a/fs/dlm/lowcomms-tcp.c
> +++ b/fs/dlm/lowcomms-tcp.c
> @@ -299,6 +299,7 @@ static int receive_from_sock(struct connection *con)
> */
> iov[0].iov_len = con->cb.base - cbuf_data(&con->cb);
> iov[0].iov_base = page_address(con->rx_page) + cbuf_data(&con->cb);
> + iov[1].iov_len = 0;
> nvec = 1;
>
> /*
Just to add that this is already in RHEL5, but it needs to go upstream.
--
patrick
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Cluster-devel] [PATCH] dlm: Fix uninitialised variable in receiving
2007-03-13 17:08 [Cluster-devel] [PATCH] dlm: Fix uninitialised variable in receiving Patrick Caulfield
2007-03-13 17:11 ` Robert Peterson
2007-03-13 17:34 ` Patrick Caulfield
@ 2007-03-14 11:58 ` Steven Whitehouse
2 siblings, 0 replies; 4+ messages in thread
From: Steven Whitehouse @ 2007-03-14 11:58 UTC (permalink / raw)
To: cluster-devel.redhat.com
Hi,
Now in the -nmw git tree. Thanks,
Steve.
On Tue, 2007-03-13 at 17:08 +0000, Patrick Caulfield wrote:
> The length of the second element of the kvec array was not initialised before
> being added to the first one. This could cause invalid lengths to be passed to
> kernel_recvmsg
>
> Signed-Off-By: Patrick Caulfield <pcaulfie@redhat.com>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-03-14 11:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-03-13 17:08 [Cluster-devel] [PATCH] dlm: Fix uninitialised variable in receiving Patrick Caulfield
2007-03-13 17:11 ` Robert Peterson
2007-03-13 17:34 ` Patrick Caulfield
2007-03-14 11:58 ` Steven Whitehouse
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.