From: Zachary Amsden <zach@vmware.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Virtualization Mailing List <virtualization@lists.osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
john stultz <johnstul@us.ibm.com>
Subject: Re: [PATCH/RFC] replace get_scheduled_cycles with sched_clock paravirt_op
Date: Wed, 14 Mar 2007 12:34:23 -0800 [thread overview]
Message-ID: <45F85C4F.10704@vmware.com> (raw)
In-Reply-To: <45F847E2.7040102@goop.org>
Jeremy Fitzhardinge wrote:
> Subject: Add a sched_clock paravirt_op
>
> The tsc-based get_scheduled_cycles interface is not a good match for
> Xen's runstate accounting, which reports everything in nanoseconds.
>
> This patch replaces this interface with a sched_clock interface, which
> matches both Xen and VMI's requirements.
>
> In order to do this, we:
> 1. replace get_scheduled_cycles with sched_clock
> 2. hoist cycles_2_ns into a common header
> 3. update vmi accordingly
>
> One thing to note: because sched_clock is implemented as a weak function in
> kernel/sched.c, we must define a real function in order to override this weak
> binding. This means the usual paravirt_ops technique of using an inline
> function won't work in this case.
>
Acked-by: Zachary Amsden <zach@vmware.com>
WARNING: multiple messages have this Message-ID (diff)
From: Zachary Amsden <zach@vmware.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Dan Hecht <dhecht@vmware.com>,
Virtualization Mailing List <virtualization@lists.osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
john stultz <johnstul@us.ibm.com>
Subject: Re: [PATCH/RFC] replace get_scheduled_cycles with sched_clock paravirt_op
Date: Wed, 14 Mar 2007 12:34:23 -0800 [thread overview]
Message-ID: <45F85C4F.10704@vmware.com> (raw)
In-Reply-To: <45F847E2.7040102@goop.org>
Jeremy Fitzhardinge wrote:
> Subject: Add a sched_clock paravirt_op
>
> The tsc-based get_scheduled_cycles interface is not a good match for
> Xen's runstate accounting, which reports everything in nanoseconds.
>
> This patch replaces this interface with a sched_clock interface, which
> matches both Xen and VMI's requirements.
>
> In order to do this, we:
> 1. replace get_scheduled_cycles with sched_clock
> 2. hoist cycles_2_ns into a common header
> 3. update vmi accordingly
>
> One thing to note: because sched_clock is implemented as a weak function in
> kernel/sched.c, we must define a real function in order to override this weak
> binding. This means the usual paravirt_ops technique of using an inline
> function won't work in this case.
>
Acked-by: Zachary Amsden <zach@vmware.com>
next prev parent reply other threads:[~2007-03-14 20:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-14 19:07 [PATCH/RFC] replace get_scheduled_cycles with sched_clock paravirt_op Jeremy Fitzhardinge
2007-03-14 20:34 ` Zachary Amsden [this message]
2007-03-14 20:34 ` Zachary Amsden
2007-03-17 0:30 ` Andrew Morton
2007-03-17 0:43 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45F85C4F.10704@vmware.com \
--to=zach@vmware.com \
--cc=jeremy@goop.org \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.