All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: rmk+lkml@arm.linux.org.uk
Cc: Tejun Heo <htejun@gmail.com>,
	gregkh@suse.de, linux-kernel@vger.kernel.org,
	linux-pci@atrey.karlin.mff.cuni.cz,
	michal.k.k.piotrowski@gmail.com, linux-ide@vger.kernel.org,
	tglx@linutronix.de, shemminger@linux-foundation.org,
	mlord@pobox.com, linux-pm@lists.osdl.org
Subject: Re: [PATCH/RFC] PCI prepare/activate instead of enable to avoid IRQ storm and rogue DMA access
Date: Wed, 14 Mar 2007 18:34:11 -0400	[thread overview]
Message-ID: <45F87863.9040408@garzik.org> (raw)
In-Reply-To: <20070314215605.GA7194@flint.arm.linux.org.uk>

Russell King wrote:
> pci_enable_device() doesn't deal with this; in most PCI setups I've
> seen, there is no control at PCI level over whether a device generates
> an interrupt on the bus.  Certainly the memory and io command enables

PCI grew an interrupt enable while you weren't looking: 
PCI_COMMAND_INTX_DISABLE

No idea about ARM, but almost all PCI devices made in the past few years 
support that bit.

Unless you are using a PCI Express device (maybe PCI-X too?), though, 
you cannot count on the bit's presence.  It was added in PCI 2.3 I 
think.  Older PCI devices certainly do not have this standardized bit.

	Jeff



  reply	other threads:[~2007-03-14 22:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-14 15:23 [PATCH/RFC] PCI prepare/activate instead of enable to avoid IRQ storm and rogue DMA access Tejun Heo
2007-03-14 17:04 ` Alan Stern
2007-03-14 17:04   ` [linux-pm] " Alan Stern
2007-03-14 17:07 ` Stephen Hemminger
2007-03-14 17:07   ` Stephen Hemminger
2007-03-15  2:37   ` Tejun Heo
2007-03-15  6:45     ` Grant Grundler
2007-03-16 21:21     ` Stephen Hemminger
2007-03-14 21:46 ` Andi Kleen
2007-03-15  2:39   ` Tejun Heo
2007-03-15 10:17     ` Andi Kleen
2007-03-15 10:17       ` Andi Kleen
2007-03-15 11:41   ` Vivek Goyal
2007-03-14 21:56 ` Russell King
2007-03-14 22:34   ` Jeff Garzik [this message]
2007-03-14 22:58     ` Russell King
2007-03-14 23:16       ` Jeff Garzik
2007-03-15  5:47       ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45F87863.9040408@garzik.org \
    --to=jeff@garzik.org \
    --cc=gregkh@suse.de \
    --cc=htejun@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=linux-pm@lists.osdl.org \
    --cc=michal.k.k.piotrowski@gmail.com \
    --cc=mlord@pobox.com \
    --cc=rmk+lkml@arm.linux.org.uk \
    --cc=shemminger@linux-foundation.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.