All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Bob Stewart <bob@evoria.net>
Cc: Mark Lord <liml@rtr.ca>, linux-ide@vger.kernel.org
Subject: Re: sata_inic162x driver for 2.6.19 timeouts etc
Date: Fri, 16 Mar 2007 14:17:33 +0900	[thread overview]
Message-ID: <45FA286D.8050705@gmail.com> (raw)
In-Reply-To: <20070315182005.944.qmail@web812.biz.mail.mud.yahoo.com>

Bob Stewart wrote:
> --- Tejun Heo <htejun@gmail.com> wrote:
> 
>> The driver is seriously broken regarding LBA48 support.  The timeout
>> goes away if max_sectors is decreased to ATA_MAX_SECTORS - 1, doh.  But
>> both the reading and writing are seriously broken.  I can't tell whether
>> they end up in the wrong sectors or garbage is transferred to/from the
>> right sectors.
> 
> I couldn't figure it out, either.  There were some times early on that I
> failed it all the way down to PIO4 and it worked just fine.  But, with DMA
> forget it.  

Hmmm... I played a bit with POLLING LBA48 but no luck.  I always got HSM
violation.

>> I'm really close to marking this device broken or we'll need to
>> implement a mechanism to veto LBA48 device from LLD (may be negative
>> return from ->dev_config).
> 
> Are you sure it's an LBA48 issue?  I was never sure how to check
> this but in my banging around, I never saw anything in the HOB fields.

Pretty sure.  If I write sequentially, the first sector out of LBA28
range gives me timeout (with 256 sector requests).  If I make a
filesystem insider LBA28 range proper, I can fsck it using another
controller and vice versa but if I do it outside of LBA48 range (using
255 sector requests), nothing gets written or read properly.

>> Reading the sunix driver, I can't find any relevant workaround.  It
>> never seems to initialize ctl address.  I'm curious whether the sunix
>> driver can do LBA48.  Bob, are you interested in testing this?
> 
> Sure.  I'll need to reorganize hardware again, but it'll give me something
> to do till the steelhead start their spring run.  :)

Have no idea what the steelhead is but thanks.  :-)

-- 
tejun

  reply	other threads:[~2007-03-16  5:17 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-02  6:29 [PATCH] libata: add 150ms between completion of hardreset and status checking Tejun Heo
2007-02-03 22:07 ` Bob Stewart
2007-02-04  2:36   ` Tejun Heo
2007-02-04  2:46     ` sata_inic162x driver for 2.6.19 timeouts etc Bob Stewart
2007-02-05 17:29       ` Mark Lord
2007-02-05 21:55         ` Bob Stewart
2007-02-06 14:42           ` Mark Lord
2007-03-15 17:40           ` Tejun Heo
2007-03-15 18:20             ` Bob Stewart
2007-03-16  5:17               ` Tejun Heo [this message]
2007-03-16  5:53                 ` Bob Stewart
2007-03-16  6:00                   ` Tejun Heo
2007-03-16  6:02                     ` Bob Stewart
2007-03-24  6:48                       ` Bob Stewart
2007-03-24  7:38                         ` Tejun Heo
2007-03-24  9:59                           ` Bob Stewart
2007-03-27  4:57                           ` Jeff Garzik
2007-03-27  5:19                             ` Bob Stewart
2007-03-27 14:23                             ` Mark Lord
2007-03-27 16:24                               ` Alan Cox
2007-03-28  1:20                           ` Bob Stewart
2007-03-28  5:21                             ` Bob Stewart
2008-08-24 23:50                           ` Old Thread: " Bob Stewart
2008-08-25  8:39                             ` Tejun Heo
2008-08-25 14:39                               ` Bob Stewart
2007-03-15 19:16             ` Alan Cox
2007-03-15 20:16               ` Jeff Garzik
2007-03-16  5:23                 ` Tejun Heo
2007-03-16 12:23                   ` Mark Lord
2007-03-16 14:55                     ` Alan Cox
2007-03-16 15:21                   ` Jeff Garzik
2007-03-17  2:09                     ` Tejun Heo
2007-03-16 15:23                   ` Jeff Garzik
2007-03-15 20:16             ` Jeff Garzik
2007-03-15 20:43             ` Bob Stewart
2007-03-16  5:13               ` Tejun Heo
2007-02-07  0:43 ` [PATCH] libata: add 150ms between completion of hardreset and status checking Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45FA286D.8050705@gmail.com \
    --to=htejun@gmail.com \
    --cc=bob@evoria.net \
    --cc=liml@rtr.ca \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.