All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>, Bob Stewart <bob@evoria.net>,
	Mark Lord <liml@rtr.ca>,
	linux-ide@vger.kernel.org
Subject: Re: sata_inic162x driver for 2.6.19 timeouts etc
Date: Fri, 16 Mar 2007 14:23:18 +0900	[thread overview]
Message-ID: <45FA29C6.4070601@gmail.com> (raw)
In-Reply-To: <45F9A9A3.8050800@garzik.org>

Jeff Garzik wrote:
> Alan Cox wrote:
>>> both the reading and writing are seriously broken.  I can't tell whether
>>> they end up in the wrong sectors or garbage is transferred to/from the
>>> right sectors.
>>
>> Does this occur regardless of which interface you use (the register
>> shadow or the DMA command engine ?)
> 
> I'm curious of this as well.

Oh well, I never got around to get the ADMA mode working.  The sunix
driver is TF/quasi-BMDMA based (w/o CONTROL register so I'm pretty sure
they have some problem with LBA48).  The docs[1] I have only have
register description and nothing about the programming model.  Me being
not familiar with ADMA, my try didn't go very far.  IIRC, I couldn't
nudge the controller into the ADMA mode.  Is ADMA some kind of
standardized programming interface?

Ah... another thing to note.  The sata_inic162x uses 0xFF status after
reset before it receives the first D2H Reg FIS from the device thus
making libata believe that there's no device attached to the port.  I
have no idea why they had to use 0xFF for that but they did.  :-(

It seems we'll have to consider 0xFF a valid wait state if SCR is valid
and indicates device presence.  Well, that sounds like a good idea anyway.

Thanks.

-- 
tejun

  reply	other threads:[~2007-03-16  5:23 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-02  6:29 [PATCH] libata: add 150ms between completion of hardreset and status checking Tejun Heo
2007-02-03 22:07 ` Bob Stewart
2007-02-04  2:36   ` Tejun Heo
2007-02-04  2:46     ` sata_inic162x driver for 2.6.19 timeouts etc Bob Stewart
2007-02-05 17:29       ` Mark Lord
2007-02-05 21:55         ` Bob Stewart
2007-02-06 14:42           ` Mark Lord
2007-03-15 17:40           ` Tejun Heo
2007-03-15 18:20             ` Bob Stewart
2007-03-16  5:17               ` Tejun Heo
2007-03-16  5:53                 ` Bob Stewart
2007-03-16  6:00                   ` Tejun Heo
2007-03-16  6:02                     ` Bob Stewart
2007-03-24  6:48                       ` Bob Stewart
2007-03-24  7:38                         ` Tejun Heo
2007-03-24  9:59                           ` Bob Stewart
2007-03-27  4:57                           ` Jeff Garzik
2007-03-27  5:19                             ` Bob Stewart
2007-03-27 14:23                             ` Mark Lord
2007-03-27 16:24                               ` Alan Cox
2007-03-28  1:20                           ` Bob Stewart
2007-03-28  5:21                             ` Bob Stewart
2008-08-24 23:50                           ` Old Thread: " Bob Stewart
2008-08-25  8:39                             ` Tejun Heo
2008-08-25 14:39                               ` Bob Stewart
2007-03-15 19:16             ` Alan Cox
2007-03-15 20:16               ` Jeff Garzik
2007-03-16  5:23                 ` Tejun Heo [this message]
2007-03-16 12:23                   ` Mark Lord
2007-03-16 14:55                     ` Alan Cox
2007-03-16 15:21                   ` Jeff Garzik
2007-03-17  2:09                     ` Tejun Heo
2007-03-16 15:23                   ` Jeff Garzik
2007-03-15 20:16             ` Jeff Garzik
2007-03-15 20:43             ` Bob Stewart
2007-03-16  5:13               ` Tejun Heo
2007-02-07  0:43 ` [PATCH] libata: add 150ms between completion of hardreset and status checking Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45FA29C6.4070601@gmail.com \
    --to=htejun@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bob@evoria.net \
    --cc=jeff@garzik.org \
    --cc=liml@rtr.ca \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.