All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Attempt to bring bos back to VRAM after eviction
@ 2025-08-28 15:42 Thomas Hellström
  2025-08-28 15:59 ` Matthew Auld
                   ` (4 more replies)
  0 siblings, 5 replies; 11+ messages in thread
From: Thomas Hellström @ 2025-08-28 15:42 UTC (permalink / raw)
  To: intel-xe; +Cc: Thomas Hellström, Matthew Brost, Matthew Auld, stable

VRAM+TT bos that are evicted from VRAM to TT may remain in
TT also after a revalidation following eviction or suspend.

This manifests itself as applications becoming sluggish
after buffer objects get evicted or after a resume from
suspend or hibernation.

If the bo supports placement in both VRAM and TT, and
we are on DGFX, mark the TT placement as fallback. This means
that it is tried only after VRAM + eviction.

This flaw has probably been present since the xe module was
upstreamed but use a Fixes: commit below where backporting is
likely to be simple. For earlier versions we need to open-
code the fallback algorithm in the driver.

Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/5995
Fixes: a78a8da51b36 ("drm/ttm: replace busy placement with flags v6")
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: <stable@vger.kernel.org> # v6.9+
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
---
 drivers/gpu/drm/xe/xe_bo.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c
index 4faf15d5fa6d..64dea4e478bd 100644
--- a/drivers/gpu/drm/xe/xe_bo.c
+++ b/drivers/gpu/drm/xe/xe_bo.c
@@ -188,6 +188,8 @@ static void try_add_system(struct xe_device *xe, struct xe_bo *bo,
 
 		bo->placements[*c] = (struct ttm_place) {
 			.mem_type = XE_PL_TT,
+			.flags = (IS_DGFX(xe) && (bo_flags & XE_BO_FLAG_VRAM_MASK)) ?
+			TTM_PL_FLAG_FALLBACK : 0,
 		};
 		*c += 1;
 	}
-- 
2.50.1


^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2025-08-29 11:21 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-28 15:42 [PATCH] drm/xe: Attempt to bring bos back to VRAM after eviction Thomas Hellström
2025-08-28 15:59 ` Matthew Auld
2025-08-28 16:06   ` Thomas Hellström
2025-08-28 16:27     ` Matthew Auld
2025-08-28 18:06       ` Thomas Hellström
2025-08-28 18:06 ` ✓ CI.KUnit: success for " Patchwork
2025-08-28 19:12 ` ✗ Xe.CI.BAT: failure " Patchwork
2025-08-29  1:06 ` ✗ Xe.CI.Full: " Patchwork
2025-08-29  7:42 ` [PATCH] " Maarten Lankhorst
2025-08-29 10:55   ` Thomas Hellström
2025-08-29 11:21     ` Maarten Lankhorst

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.