All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: "Heiko Stübner" <heiko@sntech.de>, "Rob Herring" <robh@kernel.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
	Heiko Stuebner <heiko.stuebner@theobroma-systems.com>,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RESEND 1/2] dt-bindings: phy: drop #clock-cells from rockchip,px30-dsi-dphy
Date: Fri, 20 Dec 2019 16:51:28 +0530	[thread overview]
Message-ID: <45c59145-5705-90f9-ff0e-c84cf8d17e8b@ti.com> (raw)
In-Reply-To: <12525836.FhlgEYrHGb@diego>



On 16/12/19 11:31 pm, Heiko Stübner wrote:
> Hi Rob,
> 
> Am Montag, 16. Dezember 2019, 18:56:15 CET schrieb Rob Herring:
>> On Mon, 16 Dec 2019 13:24:47 +0100, Heiko Stuebner wrote:
>>> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>>>
>>> Further review of the dsi components for the px30 revealed that the
>>> phy shouldn't expose the pll as clock but instead handle settings
>>> via phy parameters.
>>>
>>> As the phy binding is new and not used anywhere yet, just drop them
>>> so they don't get used.
>>>
>>> Fixes: 3817c7961179 ("dt-bindings: phy: add yaml binding for rockchip,px30-dsi-dphy")
>>> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>>> ---
>>> Hi Kishon,
>>>
>>> maybe suitable as a fix for 5.5-rc?
>>>
>>> Thanks
>>> Heiko
>>>
>>>  .../devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml      | 5 -----
>>>  1 file changed, 5 deletions(-)
>>>
>>
>> Please add Acked-by/Reviewed-by tags when posting new versions. However,
>> there's no need to repost patches *only* to add the tags. The upstream
>> maintainer will do that for acks received on the version they apply.
>>
>> If a tag was not added on purpose, please state why and what changed.
> 
> sorry about that. The original response somehow did not thread correctly
> in my mail client, probably some fault on my side, so I've only found your
> mail just now by digging hard.
> 
> @Kishon, the original mail already got an
> 
> Acked-by: Rob Herring <robh@kernel.org>

merged now, Thanks!

-Kishon

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com>
To: "Heiko Stübner" <heiko@sntech.de>, "Rob Herring" <robh@kernel.org>
Cc: <robh+dt@kernel.org>, <mark.rutland@arm.com>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-rockchip@lists.infradead.org>,
	Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Subject: Re: [PATCH RESEND 1/2] dt-bindings: phy: drop #clock-cells from rockchip,px30-dsi-dphy
Date: Fri, 20 Dec 2019 16:51:28 +0530	[thread overview]
Message-ID: <45c59145-5705-90f9-ff0e-c84cf8d17e8b@ti.com> (raw)
In-Reply-To: <12525836.FhlgEYrHGb@diego>



On 16/12/19 11:31 pm, Heiko Stübner wrote:
> Hi Rob,
> 
> Am Montag, 16. Dezember 2019, 18:56:15 CET schrieb Rob Herring:
>> On Mon, 16 Dec 2019 13:24:47 +0100, Heiko Stuebner wrote:
>>> From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>>>
>>> Further review of the dsi components for the px30 revealed that the
>>> phy shouldn't expose the pll as clock but instead handle settings
>>> via phy parameters.
>>>
>>> As the phy binding is new and not used anywhere yet, just drop them
>>> so they don't get used.
>>>
>>> Fixes: 3817c7961179 ("dt-bindings: phy: add yaml binding for rockchip,px30-dsi-dphy")
>>> Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
>>> ---
>>> Hi Kishon,
>>>
>>> maybe suitable as a fix for 5.5-rc?
>>>
>>> Thanks
>>> Heiko
>>>
>>>  .../devicetree/bindings/phy/rockchip,px30-dsi-dphy.yaml      | 5 -----
>>>  1 file changed, 5 deletions(-)
>>>
>>
>> Please add Acked-by/Reviewed-by tags when posting new versions. However,
>> there's no need to repost patches *only* to add the tags. The upstream
>> maintainer will do that for acks received on the version they apply.
>>
>> If a tag was not added on purpose, please state why and what changed.
> 
> sorry about that. The original response somehow did not thread correctly
> in my mail client, probably some fault on my side, so I've only found your
> mail just now by digging hard.
> 
> @Kishon, the original mail already got an
> 
> Acked-by: Rob Herring <robh@kernel.org>

merged now, Thanks!

-Kishon

  reply	other threads:[~2019-12-20 11:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16 12:24 [PATCH RESEND 1/2] dt-bindings: phy: drop #clock-cells from rockchip,px30-dsi-dphy Heiko Stuebner
2019-12-16 12:24 ` [PATCH RESEND 1/2] dt-bindings: phy: drop #clock-cells from rockchip, px30-dsi-dphy Heiko Stuebner
2019-12-16 12:24 ` [PATCH RESEND 2/2] phy/rockchip: inno-dsidphy: generalize parameter handling Heiko Stuebner
2019-12-16 12:24   ` Heiko Stuebner
2019-12-16 17:56 ` [PATCH RESEND 1/2] dt-bindings: phy: drop #clock-cells from rockchip,px30-dsi-dphy Rob Herring
2019-12-16 17:56   ` Rob Herring
2019-12-16 17:56   ` Rob Herring
2019-12-16 18:01   ` [PATCH RESEND 1/2] dt-bindings: phy: drop #clock-cells from rockchip, px30-dsi-dphy Heiko Stübner
2019-12-16 18:01     ` [PATCH RESEND 1/2] dt-bindings: phy: drop #clock-cells from rockchip,px30-dsi-dphy Heiko Stübner
2019-12-16 18:01     ` [PATCH RESEND 1/2] dt-bindings: phy: drop #clock-cells from rockchip, px30-dsi-dphy Heiko Stübner
2019-12-20 11:21     ` Kishon Vijay Abraham I [this message]
2019-12-20 11:21       ` [PATCH RESEND 1/2] dt-bindings: phy: drop #clock-cells from rockchip,px30-dsi-dphy Kishon Vijay Abraham I
     [not found]       ` <45c59145-5705-90f9-ff0e-c84cf8d17e8b-l0cyMroinI0@public.gmane.org>
2019-12-20 11:37         ` [PATCH RESEND 1/2] dt-bindings: phy: drop #clock-cells from rockchip, px30-dsi-dphy Heiko Stübner
2019-12-20 11:37           ` [PATCH RESEND 1/2] dt-bindings: phy: drop #clock-cells from rockchip,px30-dsi-dphy Heiko Stübner
2019-12-20 11:37           ` [PATCH RESEND 1/2] dt-bindings: phy: drop #clock-cells from rockchip, px30-dsi-dphy Heiko Stübner
2019-12-20 11:52           ` [PATCH RESEND 1/2] dt-bindings: phy: drop #clock-cells from rockchip,px30-dsi-dphy Kishon Vijay Abraham I
2019-12-20 11:52             ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45c59145-5705-90f9-ff0e-c84cf8d17e8b@ti.com \
    --to=kishon@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko.stuebner@theobroma-systems.com \
    --cc=heiko@sntech.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.