All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Dan Carpenter <dan.carpenter@linaro.org>,
	Jinjie Ruan <ruanjinjie@huawei.com>
Cc: netdev@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Eric Dumazet <edumazet@google.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	Simon Horman <horms@kernel.org>, Jakub Kicinski <kuba@kernel.org>,
	Jacob Keller <jacob.e.keller@intel.com>,
	intel-wired-lan@lists.osuosl.org, Paolo Abeni <pabeni@redhat.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH net-next 2/2] ixgbe: fix end of loop test in ixgbe_set_vf_macvlan()
Date: Mon, 9 Oct 2023 08:18:29 -0700	[thread overview]
Message-ID: <45de79fd-5763-bb55-22b2-0bfd64873c4f@intel.com> (raw)
In-Reply-To: <34603f41-1d51-48df-9bca-a28fd5b27a53@moroto.mountain>

On 10/5/2023 6:58 AM, Dan Carpenter wrote:
> The list iterator in a list_for_each_entry() loop can never be NULL.
> If the loop exits without hitting a break then the iterator points
> to an offset off the list head and dereferencing it is an out of
> bounds access.
> 
> Before we transitioned to using list_for_each_entry() loops, then
> it was possible for "entry" to be NULL and the comments mention
> this.  I have updated the comments to match the new code.
> 
> Fixes: c1fec890458a ("ethernet/intel: Use list_for_each_entry() helper")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>


_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

WARNING: multiple messages have this Message-ID (diff)
From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Dan Carpenter <dan.carpenter@linaro.org>,
	Jinjie Ruan <ruanjinjie@huawei.com>
Cc: <intel-wired-lan@lists.osuosl.org>,
	<kernel-janitors@vger.kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	Simon Horman <horms@kernel.org>, <netdev@vger.kernel.org>,
	Jacob Keller <jacob.e.keller@intel.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH net-next 2/2] ixgbe: fix end of loop test in ixgbe_set_vf_macvlan()
Date: Mon, 9 Oct 2023 08:18:29 -0700	[thread overview]
Message-ID: <45de79fd-5763-bb55-22b2-0bfd64873c4f@intel.com> (raw)
In-Reply-To: <34603f41-1d51-48df-9bca-a28fd5b27a53@moroto.mountain>

On 10/5/2023 6:58 AM, Dan Carpenter wrote:
> The list iterator in a list_for_each_entry() loop can never be NULL.
> If the loop exits without hitting a break then the iterator points
> to an offset off the list head and dereferencing it is an out of
> bounds access.
> 
> Before we transitioned to using list_for_each_entry() loops, then
> it was possible for "entry" to be NULL and the comments mention
> this.  I have updated the comments to match the new code.
> 
> Fixes: c1fec890458a ("ethernet/intel: Use list_for_each_entry() helper")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Reviewed-by: Jesse Brandeburg <jesse.brandeburg@intel.com>



  parent reply	other threads:[~2023-10-09 15:19 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-05 13:57 [Intel-wired-lan] [PATCH net-next 1/2] igb: Fix an end of loop test Dan Carpenter
2023-10-05 13:57 ` Dan Carpenter
2023-10-05 13:58 ` [Intel-wired-lan] [PATCH net-next 2/2] ixgbe: fix end of loop test in ixgbe_set_vf_macvlan() Dan Carpenter
2023-10-05 13:58   ` Dan Carpenter
2023-10-06 11:21   ` [Intel-wired-lan] " Simon Horman
2023-10-06 11:21     ` Simon Horman
2023-10-09 15:18   ` Jesse Brandeburg [this message]
2023-10-09 15:18     ` [Intel-wired-lan] " Jesse Brandeburg
2023-10-16 10:25     ` Romanowski, Rafal
2023-10-16 10:25       ` Romanowski, Rafal
2023-10-06 11:20 ` [Intel-wired-lan] [PATCH net-next 1/2] igb: Fix an end of loop test Simon Horman
2023-10-06 11:20   ` Simon Horman
2023-10-09 15:17 ` [Intel-wired-lan] " Jesse Brandeburg
2023-10-09 15:17   ` Jesse Brandeburg
2023-10-16 10:25   ` [Intel-wired-lan] " Romanowski, Rafal
2023-10-16 10:25     ` Romanowski, Rafal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45de79fd-5763-bb55-22b2-0bfd64873c4f@intel.com \
    --to=jesse.brandeburg@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=dan.carpenter@linaro.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jacob.e.keller@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ruanjinjie@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.