[lm-sensors] [PATCH] coretemp 2/3 Add the coretemp driver

[lm-sensors] [PATCH] coretemp 2/3 Add the coretemp driver

[Rudolf Marek]

Hello Jean,

This is just the fixed version of the driver (the small typo Nicolas pointed 
out). Please can you test/apply to your stack once we know it is OK and once the 
1/3 patch is applied?

Thanks,

This patch adds the support for the digital temperature sensor found in recent 
Intel Core CPUs.

Signed-off-by: Rudolf Marek <r.marek at assembler.cz>

Rudolf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: add-coretemp-driver.patch
Type: text/x-patch
Size: 12657 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20070320/13d3ad68/attachment.bin 

[lm-sensors] [PATCH] coretemp 2/3 Add the coretemp driver

[Nicolas Boichat]

Rudolf Marek wrote:
> Hello Jean,
> 
> This is just the fixed version of the driver (the small typo Nicolas
> pointed out). Please can you test/apply to your stack once we know it is
> OK and once the 1/3 patch is applied?
> 
> Thanks,
> 
> This patch adds the support for the digital temperature sensor found in
> recent Intel Core CPUs.
> 
> Signed-off-by: Rudolf Marek <r.marek at assembler.cz>

Tested on my Macbook Pro (Core Duo), works fine.

Best regards,

Nicolas

[lm-sensors] [PATCH] coretemp 2/3 Add the coretemp driver

[Jean Delvare]

On Tue, 20 Mar 2007 23:55:12 +0100, Rudolf Marek wrote:
> Hello Jean,
> 
> This is just the fixed version of the driver (the small typo Nicolas pointed 
> out). Please can you test/apply to your stack once we know it is OK and once the 
> 1/3 patch is applied?
> 
> Thanks,
> 
> This patch adds the support for the digital temperature sensor found in recent 
> Intel Core CPUs.
> 
> Signed-off-by: Rudolf Marek <r.marek at assembler.cz>

Applied, thanks.

-- 
Jean Delvare

Re: [lm-sensors] [PATCH] coretemp 2/3 Add the coretemp driver

[George T. Joseph (development)]

This may be a little late, but how about a module parameter that sets
tjmax (and suppresses the warning). This way if the detection logic
fails for some reason, the driver can still be used if the user knows
what the tjmax for their processor is.

> -----Original Message-----
> From: lm-sensors-bounces@lm-sensors.org 
> [mailto:lm-sensors-bounces@lm-sensors.org] On Behalf Of Rudolf Marek
> Sent: Tuesday, March 20, 2007 4:55 PM
> To: LM Sensors
> Cc: bytes@linuxgazette.net; Alexey Dobriyan; 
> nicolas@boichat.ch; jpiszcz@lucidpixels.com
> Subject: [lm-sensors] [PATCH] coretemp 2/3 Add the coretemp driver
> 
> Hello Jean,
> 
> This is just the fixed version of the driver (the small typo 
> Nicolas pointed 
> out). Please can you test/apply to your stack once we know it 
> is OK and once the 
> 1/3 patch is applied?
> 
> Thanks,
> 
> This patch adds the support for the digital temperature 
> sensor found in recent 
> Intel Core CPUs.
> 
> Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
> 
> Rudolf
> 

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

Re: [lm-sensors] [PATCH] coretemp 2/3 Add the coretemp driver

[Jean Delvare]

Hi George,

On Thu, 29 Mar 2007 17:16:32 -0600, George T. Joseph wrote:
> This may be a little late, but how about a module parameter that sets
> tjmax (and suppresses the warning). This way if the detection logic
> fails for some reason, the driver can still be used if the user knows
> what the tjmax for their processor is.

If this is only an option, I guess it cannot hurt. I have no strong
opinion on the feature itself, Rudolf will know better. But at any
rate, it's not too late - open source code is _meant_ to be improved
over time.

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors