From: Rik van Riel <riel@redhat.com>
To: Nikita Danilov <nikita@clusterfs.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [RFC][PATCH] split file and anonymous page queues #3
Date: Wed, 21 Mar 2007 07:24:09 -0400 [thread overview]
Message-ID: <460115D9.7030806@redhat.com> (raw)
In-Reply-To: <17920.61568.770999.626623@gargle.gargle.HOWL>
Nikita Danilov wrote:
> Rik van Riel writes:
> > [ OK, I suck. I edited yesterday's email with the new info, but forgot
> > to change the attachment to today's patch. Here is today's patch. ]
> >
> > Split the anonymous and file backed pages out onto their own pageout
> > queues. This we do not unnecessarily churn through lots of anonymous
> > pages when we do not want to swap them out anyway.
>
> Won't this re-introduce problems similar to ones due to split
> inactive_clean/inactive_dirty queues we had in the past?
>
> For example, by rotating anon queues faster than file queues, kernel
> would end up reclaiming anon pages that are hotter (in "absolute" LRU
> order) than some file pages.
That is why we check the fraction of referenced pages in each
queue. Please look at the get_scan_ratio() and shrink_zone()
code in my patch.
--
Politics is the struggle between those who want to make their country
the best in the world, and those who believe it already is. Each group
calls the other unpatriotic.
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: Nikita Danilov <nikita@clusterfs.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [RFC][PATCH] split file and anonymous page queues #3
Date: Wed, 21 Mar 2007 07:24:09 -0400 [thread overview]
Message-ID: <460115D9.7030806@redhat.com> (raw)
In-Reply-To: <17920.61568.770999.626623@gargle.gargle.HOWL>
Nikita Danilov wrote:
> Rik van Riel writes:
> > [ OK, I suck. I edited yesterday's email with the new info, but forgot
> > to change the attachment to today's patch. Here is today's patch. ]
> >
> > Split the anonymous and file backed pages out onto their own pageout
> > queues. This we do not unnecessarily churn through lots of anonymous
> > pages when we do not want to swap them out anyway.
>
> Won't this re-introduce problems similar to ones due to split
> inactive_clean/inactive_dirty queues we had in the past?
>
> For example, by rotating anon queues faster than file queues, kernel
> would end up reclaiming anon pages that are hotter (in "absolute" LRU
> order) than some file pages.
That is why we check the fraction of referenced pages in each
queue. Please look at the get_scan_ratio() and shrink_zone()
code in my patch.
--
Politics is the struggle between those who want to make their country
the best in the world, and those who believe it already is. Each group
calls the other unpatriotic.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-03-21 11:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-20 22:08 [RFC][PATCH] split file and anonymous page queues #3 Rik van Riel
2007-03-21 1:07 ` Matt Mackall
2007-03-21 1:07 ` Matt Mackall
2007-03-21 19:11 ` Rik van Riel
2007-03-21 8:44 ` Nikita Danilov
2007-03-21 8:44 ` Nikita Danilov
2007-03-21 11:24 ` Rik van Riel [this message]
2007-03-21 11:24 ` Rik van Riel
2007-03-21 11:48 ` Nikita Danilov
2007-03-21 11:48 ` Nikita Danilov
2007-03-21 12:01 ` Rik van Riel
2007-03-21 12:01 ` Rik van Riel
2007-03-21 12:03 ` Rik van Riel
2007-03-21 12:03 ` Rik van Riel
2007-03-21 15:29 ` Nikita Danilov
2007-03-21 15:29 ` Nikita Danilov
2007-03-21 16:08 ` Rik van Riel
2007-03-21 16:08 ` Rik van Riel
2007-03-21 22:18 ` Nikita Danilov
2007-03-21 22:18 ` Nikita Danilov
2007-03-21 16:12 ` Chuck Ebbert
2007-03-21 16:12 ` Chuck Ebbert
2007-03-21 16:56 ` Rik van Riel
2007-03-21 16:56 ` Rik van Riel
-- strict thread matches above, loose matches on Subject: below --
2007-03-20 22:06 Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=460115D9.7030806@redhat.com \
--to=riel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nikita@clusterfs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.