All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Patrick McHardy <kaber@trash.net>
Cc: Netfilter Development Mailinglist <netfilter-devel@lists.netfilter.org>
Subject: Re: NFNL_NFA_NEST
Date: Wed, 21 Mar 2007 23:54:14 +0100	[thread overview]
Message-ID: <4601B796.5030100@netfilter.org> (raw)
In-Reply-To: <4600BDBB.8020205@trash.net>

Patrick McHardy wrote:
> One of the worst mistakes in nfnetlink in my opinion was the
> introduction of the NFNL_NFA_NEST bit. It prevents us from
> using a large part of the generic netlink stuff, since that
> just interprets it as a really huge attribute type. Since
> its not used even for anything, this is really annoying.

I'm using this bit to convert attribute headers from host byte order to
network byte order in conntrackd. I'm unsure about how I would do the
conversion if we remove such bit.

> Unfortunately there is no easy way to get rid of it, current
> userspace code sends it to the kernel, so even if we stop
> including it in the kernel, we need to deal with it for
> compatibilty.

We have a field in the nfnetlink that contains the protocol version that
we can use for this kind of changes without breaking backward.

-- 
The dawn of the fourth age of Linux firewalling is coming; a time of
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris

  parent reply	other threads:[~2007-03-21 22:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-21  5:08 NFNL_NFA_NEST Patrick McHardy
2007-03-21 10:04 ` NFNL_NFA_NEST Jozsef Kadlecsik
2007-03-21 10:13   ` NFNL_NFA_NEST Patrick McHardy
2007-03-21 10:39     ` NFNL_NFA_NEST Jozsef Kadlecsik
2007-03-21 22:54 ` Pablo Neira Ayuso [this message]
2007-03-22 11:00   ` NFNL_NFA_NEST Patrick McHardy
2007-03-22 13:18     ` NFNL_NFA_NEST Pablo Neira Ayuso
2007-03-22 13:29       ` NFNL_NFA_NEST Patrick McHardy
2007-03-22 16:44         ` NFNL_NFA_NEST Pablo Neira Ayuso
2007-03-22 17:01           ` NFNL_NFA_NEST Patrick McHardy
2007-03-23 12:18             ` NFNL_NFA_NEST Pablo Neira Ayuso
2007-03-23 12:55               ` NFNL_NFA_NEST Pablo Neira Ayuso
2007-03-23 13:01                 ` NFNL_NFA_NEST Patrick McHardy
2007-03-23 13:00               ` NFNL_NFA_NEST Patrick McHardy
2007-03-23 17:37                 ` NFNL_NFA_NEST Pablo Neira Ayuso
2007-03-24 10:49                   ` NFNL_NFA_NEST Patrick McHardy
2007-03-24 11:30                     ` NFNL_NFA_NEST Pablo Neira Ayuso
2007-03-24 14:37                       ` NFNL_NFA_NEST Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4601B796.5030100@netfilter.org \
    --to=pablo@netfilter.org \
    --cc=kaber@trash.net \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.