Re: NFNL_NFA_NEST

[Patrick McHardy <kaber@trash.net>]

Pablo Neira Ayuso wrote:
> Patrick McHardy wrote:
> 
>>Not really. The NEST bit allows to walk nested structures without
>>being aware of the structure. So all you need to do is make it aware
>>of which attributes are nested - something you need anyway for
>>parsing I suppose.
> 
> 
> OK, then I have two choices here, define a proxy function that is
> structure aware to convert TL to network byte order that will be almost
> a copy and paste of the parsing part, or alternatively integrate the
> byte order conversion as an option for the build/parse functions, as for
> now the latter seems more natural to me.


I guess it should be possible to define a couple of structures that
hold the information about which attributes are nested and build a
simple conversion function based on that.

>>Yes, we should probably wait for at least one year.
> 
> 
> Fine with it. I'm about to release a new version of libnfnetlink, should
> we stop sending the nested bit thing to kernel since now?


Yes, the kernel doesn't need them in any case. Which gives me an
idea, we could just stop sending them in userspace and still
include them in the kernel, if that makes life easier for you.